Ticket #992 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Use X-forwarded-for whenever it is available to set remote IP address

Reported by: rgrp Owned by: rgrp
Priority: minor Milestone: ckan-v1.3
Component: ckan Keywords: bitesize
Cc: Repository:
Theme:

Description

At the moment we only use X-forwarded to determine remote user address when remote-addr header is 127.0.0.1. However if a site is behind a cache remote_addr will always be the IP of the cache.

We should fix this by using x-forwarded-for header whenever available and only use remote-addr when it is not available.

Cost: 10m

Change History

comment:1 Changed 3 years ago by rgrp

  • Milestone changed from ckan-v1.4-sprint-2 to ckan-v1.3

comment:2 Changed 3 years ago by rgrp

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in cset:08548ef8f0e9

Note: See TracTickets for help on using tickets.