{23} Trac comments (3729 matches)

Results (101 - 200 of 3729)

1 2 3 4 5 6 7 8 9 10 11 12
Ticket Posixtime Author Newvalue
#2642 1345113645000000 shevski done
#2856 1345107503000000 toby fixed now gives 404 The issue of not wanting a 404 is outside the scope of this ticket as it's a whole activity stream issue and needs dev buy in etc
#2857 1345107097000000 toby dashboard hidden in phase 3 we can fix up in phase 4
#2852 1345106515000000 toby text updated and red again
#2853 1345104231000000 toby @both notices now blue
#2855 1345104178000000 shevski I cleared my cache and it's working now
#2852 1345104027000000 shevski Red is fine here Can we amend the message to: Cannot create new harvest jobs on inactive sources. First, please change the source status to 'active'.
#2853 1345103841000000 toby @ira, I'll change to notice will do for the other one too
#2852 1345103634000000 toby I think it should stay red but you can argue
#2852 1345103409000000 toby @ira, Please review the fix I think adriá did
#2855 1345103314000000 toby @ira, this works for me at the given link try refreshing the page in case it's a cache issue
#2856 1345049793000000 shevski server error URL: http://s031.okserver.org:2375/apps/49a509f7-4eb6-456f-b1fc-87cfde90c60d
#2853 1345049201000000 amercader The message it is pretty self-explanatory, but I'm happy to lower it to warning. We can't know the scheduled time because it depends on how is set up on the server (generally a cron job every x minutes).
#2843 1345035045000000 ross Add existing dataset doesn't make a lot of sense because they can only belong to a single organization. Best would be to fix the organisation template to remove Add Existing.
#2772 1345027445000000 seanh Transifex was updated and translators notified, translations were made and pulled into 1.8
#2728 1345023944000000 toby Issue with not re-indexing datasets when group is updated - needs proper fix as part of phase 4
#2780 1345023811000000 toby This is a new feature moving to phase 4
#2808 1344944258000000 aron.carroll Close in 97d92ba
#2836 1344859911000000 toby I'd quite like some general css like this <span class="hover-for-help">[thing to hover over] <div class="help-text">Help text</div> </span> This is for the qa extension but seems like a general need .hover-for-help .help-text{ display:none; } .hover-for-help:hover .help-text{ display:block; position:absolute; padding:3px; }
#2841 1344857415000000 aron.carroll Fixed in a317fb9
#2834 1344856692000000 aron.carroll Done in 092d257
#2839 1344854522000000 toby this is fixed in https://github.com/okfn/ckan/pull/88
#2836 1344853957000000 toby @aron, I'd love it if we could pass it as an arg ie form.input(...., extra_info=<something escaped if not literal()>) also while we're at it I'd also really like form.input(...., help_info=<something>) that would give a (?) icon with a :hover {display:block} div - that make sense?
#2840 1344852538000000 aron.carroll Fixed in f7bc1c9. This can be flipped back by adding a class of {{{.tagline-right}}} to the hgoup element.
#2836 1344852009000000 aron.carroll Yeah you can pass an html block into a macro like so: https://github.com/okfn/ckan/blob/2375-demo-theme-development/ckan/templates/package/snippets/resource_form.html#L44-48 What do you think? If it's useful I'll document it.
#2837 1344851271000000 aron.carroll Fixed alignment issues in Firefox as of a6fa5a0. Can't do anything about visual display of checkboxes as they're controlled by the vendor. We could replace them with images, if this is going to be required then please create a new ticket for the next phase.
#2837 1344847819000000 toby http://localhost:5000/testing/primer essentially it's a black not grey outline also errored one isn't red
#2837 1344847463000000 aron.carroll Checkboxes created with {{{ form.checkbox() }}} should be styled correctly. Got a link to an example?
#2642 1344601299000000 toby @ira, can you review this http://s031.okserver.org:2375/harvest The add/edit form isn't perfect I have no idea how to use this extension so my testing has been limited make a new ticket for any problems - Also for now we only care about major issues @adriá would be nice if you could also see if it's working correctly
#2827 1344549139000000 toby Fixed and pushed to s031
#2819 1344545479000000 toby works in dev branch for /apps http://localhost:5000/dataset/1-kmwaterfractionfromnationaltopographicdatabasemapscanada/related
#2818 1344545331000000 toby check schema
#2817 1344544901000000 toby works in dev branch - may not be on s031 yet also please include urls in bug reports if possible - thanks
#2461 1344543838000000 toby stop the error
#2787 1344543473000000 toby Closing as too general and part of any plugin update
#2832 1344542984000000 toby duplicate of #2718 closing
#2824 1344532640000000 aron.carroll All fixed
#2801 1344531016000000 aron.carroll Now able to display the full text of related items as of e83df46
#2826 1344528004000000 toby fixed, issue was url_for_static @ira, good to test the site in english ie url like /en/dataset change language to something then english it will help catch these issues
#2826 1344527309000000 shevski @Toby do you know what's happened? Don't think this was the case before. Should pre-fill with standard image when there's no group image URL
#2824 1344527130000000 shevski @aron any ideas?
#2801 1344526719000000 aron.carroll Not sure it is. I'm just implementing a toggle on description so it works the same way as on the datahub.
#2801 1344526607000000 shevski @Aron / Ross is it worth having a separate page for related items? E.g. like on pd.eu http://publicdata.eu/app/irail
#2812 1344524290000000 toby @markw, Actually I see you also want some text changes please don't add unrelated discussions to tickets as it causes noise is disruptive and I just end up closing tickets as won't fix etc. I have updated the text as it was assigned to me and so i am still keeping this closed as I did as requested. Can you an ira sort this out between yourselves and create a new ticket when you have agreement Thanks
#2812 1344523785000000 toby @markw I think you are talking about a different ticket closing
#2812 1344521102000000 markw That's still fairly terrible. Also surely the auth stuff is part of Ross's Organizations stuff? It doesn't matter much if it's implemented yet, that's why this is a demo. But anyway, here is a more generic but readable version based on Ira's text above: Groups allow you to group users and data together so that they are easier to manage. Group owners can assign roles and authorisations, giving each project or department control of its own data publishing. Users can browse or search by group, making it easier to find the data they are looking for.
#2781 1344510922000000 aron.carroll Fixed as of 7c86e31
#2722 1344510010000000 aron.carroll Done in 8769233. I think the overlap issue was fixed for the dataset search a while ago. Let me know if it remains.
#2680 1344509493000000 toby closing this ticket as remaining work too vague undelete group added as #2830
#2812 1344509156000000 toby changed
#2828 1344507533000000 toby @ira this is the correct behaviour as this is a partially added dataset - rewritten ticket as it has a nice number :)
#2812 1344507240000000 shevski Current text does need updating, but I think we need an explanation along the lines of: "Groups allow you to group together datasets under a organisation (for example, the Department of Health) or topic (e.g. Transport, Health) so make it easier for users to browse datasets by theme. Groups also enable you to assign roles and authorisation to members of the group - i.e. individuals can be given the right to publish datasets from a particular organisation." But even that could be clearer. Mark's text could be misleading since we haven't currently implemented private datasets or the right auth settings.
#2699 1344507133000000 toby @ira, This is probably void now due to yesterdays dev meeting but will keep alive - moving out of phase 3 as not happening anytime soon and dependent on ross's organisation work will probably move to ckan 2.0 milestone
#2700 1344505614000000 aron.carroll Cool, done in bf23242
#2755 1344505304000000 toby this is dependent on #2790 (pending) and #2356 (waiting merge) other fixes have been done therefore closing this even if the effects won't be seen till those fixes are merged
#2707 1344504846000000 toby Formmating done other requests moved to new tickets as low priority for effort needed Title fixes translations etc http://trac.ckan.org/ticket/2822 Ordering of fields http://trac.ckan.org/ticket/2823
#2748 1344503744000000 aron.carroll Moving this to phase 4 until we decide what to do about the edit/save workflow
#2813 1344445419000000 toby http://demo.ckan.org/dataset/afterfibre group box wants a title link is not clickable maybe reorder stuff
#2812 1344445200000000 toby @ira, do you want this change?
#2700 1344358941000000 toby @aron you should have the flags close if complete
#2722 1344358667000000 toby @aron, can you re-add the dropdown and sort the overlap issue not sure which template it's in
#2809 1344347814000000 aron.carroll Fixed in 84a4123
#2554 1344338036000000 ross Reducing the priority of this at present, may become more relevant after the LOD3 plenary
#2545 1344337973000000 ross Up at http://datagm.ckanhosted.com
#2807 1344270190000000 aron.carroll Fixed in 9a6d0be
#2804 1344269865000000 aron.carroll Done in 38f824b
#2802 1344269446000000 aron.carroll Cool, this is in as of 8b72d1f8e9ba
#2458 1344262256000000 aron.carroll Made changes as of 9729f1c 1. Clicking a tag now takes you to the search page 2. When clicking the tabs the location now updates so you can bookmark pages. 3. Not sure how datasets are rated. 4. Text changes made.
#2700 1344258748000000 toby @aron, re flags it'd be nice to have more as the languages are not so fixed maybe that's too much work for this phase and is more wishlist @shevski, The language capitalisations should be correct they are from babel not us anyhow
#2802 1344258233000000 toby @aron I've done most of this to test get strings {{{ python setup.py extract_messages }}} mangle the zh_TW creates .po/.mo files - I may need to fix plurals {{{ paster trans mangle -c .ini }}} create .js files only zh_TW will be correct due to other .po/.mo files being 1.7 ones {{{ paster trans js -c .ini }}} /api/i18n/zh_TW should be correct please note we do not have en.js I'm returning {} I think this is the correct response (maybe something else as we should just use the default _('...') strings - maybe we need to do something else for what it's worth pojson does not provide the format you wanted so I adapted it reassign if you need fixes
#2700 1344256383000000 aron.carroll Okay could you give me any pointers you want to add. Plus ask Sam to create a flags for the missing countries. Cheers.
#2803 1344256274000000 aron.carroll Done in 3b2427e
#2785 1344256089000000 shevski I would say leave as phase 4 for now
#2702 1344255984000000 shevski this is just a placeholder reminding me that need to create these tickets. Will pick out the main things and close this eventually
#2644 1344255836000000 shevski I think this requires some thought & probably a discussion. For example need to be clear on the purpose of a user dashboard vs say a publisher dashboard. I image a publisher dashboard would have the stats to datasets belonging to that group (e.g. views, downloads, comments, shares, ratings), issues reported (when we get that extension working), call to action to add a new dataset (that adds it to the group). User dashboards I'm less clear about. May be we can talk about this on Tues/Wed? Or skype today
#2700 1344254979000000 shevski As long as languages are actually in their own standard of capitalisation, i don't mind. currently looks random
#2458 1344254847000000 shevski This looks great. 4 small things: 1. clicking on a tag in 'top tags' takes you to old unstyled page, e.g. http://s031.okserver.org:2375/en/tag/economics. Should take you to search faceted by that tag. 2. I'd love to be able to link directly to e.g. the 'top tags' view - any way to do this? 3. Is there any way to rate datasets at the moment? If not, can we hide that option for now? 4. On 'Revisions to Datasets per week' can we rename this 'Dataset revisions per week' and can we change the orange icon/index in the table to 'all dataset revisions' instead of referencing 'packages'
#2805 1344254760000000 toby Arg I think this is my fault
#2797 1344250973000000 aron.carroll Just a classname issue. Fixed in f927598 and documented
#2700 1344245069000000 toby @ira, languages are in their own language Capitalisation is English Imperialism so I think we shouldn't do this
#2700 1344244373000000 shevski Language names should all start with a cap letter, seems random currently. Slovenia flag (last one) missing a shield Is the Suomi just Finnish? May be a darker blue. I would find some pointers useful: e.g. "Shqipe (Albanian)"
#2642 1344243797000000 shevski Would like to have this for next week for a demo if possible
#2785 1344243731000000 shevski I think it's a nice to have, esp if we give it an intuitive UI Rufus is keen for this also
#2751 1344243046000000 toby @aron, The pip install polib is needed this is a deployment requirement so not in the pip-requirements.txt Not sure where it should live we use it elsewhere so may already be in there somewhere not sure why you needed the egg_inf
#2751 1344240974000000 aron.carroll I tried {{{paster trans mangler -c datahub.ini}} I also had to {{{ pip install polib }}} and run {{{ python setup.py egg_inf }}} I find it hard to believe out coverage is that poor, I've just been through a random selection of templates and they all have appropriate calls to {{{_()}} or {{{ {% trans %} }}}. Will look once I get this running.
#2322 1344086640000000 rgrp Can I confirm this is in v1.8 ...
#2751 1344015002000000 toby This is now possible via the `paster trans mangler` the initial verdict is that our translation coverage is extremely poor and we need a full template review - maybe there is a jinja2 i18n solution but I think not without `{% trans %}` Moving to phase 4 - also I'm just holding this ticket and will be allocating to aron's successor Publishers vs Groups is more complex than I think is appreciated, is it really worth the time and effort just to make everyone using ckan confused? Anyhow that discussion is not part of this ticket as it is not in-scope
#2774 1344009350000000 toby for now shall we just include it in the page? let me know how you want it included eg var = {}, fn({}), $(fn({})) etc
#2774 1344008312000000 aron.carroll I'm happy to just make ajax requests to public/base/i18n/<locale>.js, however this will use the language set in the <html lang> attribute. So if this file doesn't exist then we'll get a 404 and show the english. If we want something more sophisticated, determine an appropriate fallback etc, then I think the API is the way to go. Or we could get CKAN to determine the appropriate language file and include it in the page source...
#2774 1343993956000000 toby @aron I've created some js translations note that they are untranslated except for zh_TW which is mangled. At the moment they are just a json blob in public/base/i18n/<locale>.js What more do you need? It seems to me that you just need either `some_var = {json}` or `some_function({json})` let me know your preference or do we want this purely as an ajax call? If it's ajax I think we want a common approach like in http://trac.ckan.org/ticket/2698 which I prefer to a unhelpful response
#2701 1343949913000000 toby track is shit - missing helpers return `''`
#2701 1343949850000000 toby > Would be good to decide on the "one" way to do this. As the new extension guru/deity I say helper functions are the future - my word is the law a) a missing helper just returns '' so they can be added to templates even when not implemented, a missing template gives a 500 b) helper functions hide the implementation which I think is a good thing c) helpers are just soooooooo cool - plus they are new and shiny (what am I saying?) As far as moving the phase I'm not too fussed we can be ahead on phase 4
#2704 1343948227000000 toby @aron, I don't like auto submit as people may think (reasonably) that their changes are discarded. We could catch all clicks and then ask the user if they've changed something but this feels a little crazy - better than the browser dialog. hmmm maybe we should discuss this ticket with the other backlog of undecided/unsure personally I think we need to review the whole edit/view/delete logic as it feels real poor from my perspective - I need to edit something to delete it - that is a wtf imho let's work out what we are doing before wasting energy on this
#2781 1343947526000000 toby @aron please try with ckan.plugins = stats in your .ini ie without the demo theme being used
#2644 1343925546000000 aron.carroll Updated the theme in 2b81958, seems very similar in functionality to the profile page...
#2701 1343920314000000 aron.carroll BTW moved this to phase three as I consider it done.
#2701 1343920287000000 aron.carroll I've updated the disqus extension (in development branch) and added the snippet to the development branch of the demo plugin. Toby, not sure about the way the disqus plugin is implemented via a helper vs the spacial plugin using a snippet. Would be good to decide on the "one" way to do this.
#2704 1343914890000000 aron.carroll This relates to #2705. We need to decide what happens when the user clicks on one of the sidebar links. At the moment they'll get a warning if they've edited the form telling them they'll lose thier changes. Perhaps we should submit the form using ajax, showing a spinner to the user, then send them on to the next resource. This is the same situation as if we add an "add new resource" button to the listing.
#2698 1343914688000000 aron.carroll We need an api endpoint that can render a markdown string on submission. * Client posts a string of text to the endpoint. * Server responds with a 200, text/html response containing the rendered markdown. * Server returns a 400 and empty body if the content is not valid markdown. * Server returns a 500 and empty body if something else crashes. Alternatively for better error handling we could use a JSON transport. * Client posts a blob of json containing a "content" key with the markdown string. * Server returns a 200 (application/json) and blob of json with a "content" key with the rendered markdown. * Server returns a 400 (application/json) and blob of json with a "error" key containing a useful message for the user. * Server returns a 500 (application/json) and blob of json with a "error" key containing a useful message for the user.
#2700 1343914288000000 aron.carroll Added the flags in 06257ac. Ira can you sanity check that the flags are all correct. I need to get a proper German one from Sam as he used a European flag in the mockup.
1 2 3 4 5 6 7 8 9 10 11 12
Note: See TracReports for help on using and creating reports.