{23} Trac comments (3729 matches)

Results (601 - 700 of 3729)

← 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 →
Ticket Posixtime Author Newvalue
#2528 1339687025000000 aron.carroll Now implemented as of bc440d5. Doesn't seem to be successfully submitting, has something been setup wrong?
#2527 1339683264000000 toby Do we have a specific usecase for this?
#2523 1339679814000000 aron.carroll Added in 4f6d8b9 Toby, there's no form data being passed to this page yet, could you add that in?
#2450 1339670997000000 aron.carroll Closing this, issues should be created as new tickets
#2442 1339670612000000 aron.carroll Closing, issues should be opened as new tickets
#2510 1339670520000000 aron.carroll Looks okay to me
#2441 1339670118000000 aron.carroll Closing this as the page is up. Issues should be reported as new tickets.
#2456 1339670080000000 aron.carroll Closing this as the page is up. Issues should be reported as new tickets.
#2449 1339670041000000 aron.carroll Closing this as the page is up. Issues should be reported as new tickets.
#2448 1339669678000000 aron.carroll Done. Any issues should be created as new tickets.
#2444 1339669652000000 aron.carroll Done. Any issues should be created as new tickets.
#2498 1339660986000000 toby fixed in the demo branch
#2347 1339602763000000 shevski Name-wise: what do we think of 'Related Media' - that suggests news articles, apps & visualisations to me I'n not sure about relating 'ideas' to specific datasets. Looking at the way ideas work in DGU & pd.eu - it's more general and portal-wide so should flesh out user stories for this before adding ideas to related extension
#2507 1339596399000000 seanh merged
#1796 1339586499000000 ross LXML removed, update requirements on the extensions
#2440 1339581622000000 toby I am changing this to assigned not accepted as this makes trac easier to use
#2503 1339580675000000 toby implemented in commit 14067ff
#2512 1339576809000000 toby This seems to be working now
#2511 1339517817000000 aron.carroll Fixed in b24d162
#2510 1339516414000000 toby ok I've done this and also unified the tags they are now tag/class {{{ <ul 'tag-list'> <li> <a 'tag'> }}} on home page tag was on <li> not <a> slightly changes the spacing please review
#2440 1339499074000000 aron.carroll Sure, but this is more about displaying nice complete examples on the homepage.
#2503 1339498751000000 aron.carroll Toby yeah, that's exactly it.
#2440 1339498655000000 toby dataset descriptions is a data issue but I'll keep this open for now. We can probably do an exclude if needed.
#2440 1339497700000000 aron.carroll Fixed this up, last thing I think we should do is ensure that the datasets passed to the homepage have descriptions.
#2503 1339495333000000 toby @aron, To clarify this a bit. We want this so that a extension can create a new template say dataset/read.html but rather than rewriting the `core` template in ckan it can extend it in the same way as {% extends %}. The main difference is that {% ckan_extends 'template.html' %} would `walk` the ckan template tree rather than the extensions template tree. Is that what we are thinking?
#2454 1339495000000000 toby @aron, I'm going to leave this open for the moment but not make the requested change as I need to think of the best way forward. The flash message error is quite hard coded into the logic and I need to think of a nice solution.
#2502 1339494853000000 toby url_for no longer needs () link_for added but not tested - pretty certain it will just work
#2454 1339493727000000 aron.carroll Hmm, I totally agree with you on the missing username front but it would be nice at least to provide the errors in the same way we do the other forms. Currently it just displays a flash message which is unexpected. I'd suggest we add a generic "failed to login, invalid fields" in the error_summary block. Then more specific "this field is required" when a required field is left empty.
#2502 1339493182000000 aron.carroll Works beautifully. Be great if we could remove the parens around url_for and add an extra one for h.nav_link but I think call it link_for instead. {{{ {% url_for controller='foo', action='bar', ... %} {% link_for controller='foo', action='bar', class='btn', icon='plus'... %} }}}
#2507 1339436591000000 aron.carroll Fixed as of 2a5714b, pull request here: https://github.com/okfn/ckan/pull/22
#1587 1339433286000000 johnglover Fixed on ckanext-qa branch release-v1.7.1
#2454 1339431487000000 toby @aron, I'd like to close this as a won't fix - your thoughts
#2440 1339430956000000 toby you may want to look at your css as the dataset is generated by the package_list snippet I've made all packages popular for now
#2349 1339428913000000 ross Notified Hugh that http://datahub.io/dump/rdfexport.tgz will contain all of the RDF files every 24 hours if they want to fetch and import them. Have asked to make sure that this is satisfactory.
#2440 1339423966000000 toby @aron, tags what functionality do we want for this? I can just reuse the facet_list snippet but then we have all sorts of interactivity. Do we want this more a static list of tags (linked to somewhere but no add remove stuff)? seems more sensible I think featured datasets I've no idea I'll try to discover
#2440 1339421746000000 aron.carroll Has some styling as of b0153ba but needs content to be applied. Toby, can you pull in the top 10 tags, as well as n of the most "popular" datasets and n of the most recent datasets. Actually just providing the functionality as helpers would be great. Do we actually have "featured" datasets implemented at the moment? Not sure what we're going to use for the box on the top left when on a new base CKAN instance.
#2509 1339419867000000 johnglover https://github.com/okfn/ckan/pull/20
#2496 1339418832000000 toby fixed in demo branch
#2488 1339412538000000 johnglover Works for me on 1.7.1. Perhaps floapps was using older groups (of type 'group' instead of 'organization') and/or didn't add a user to the group?
#2504 1339409776000000 aron.carroll Closing this as there are just snippets remaining now and they're a lower priority.
#2502 1339407123000000 toby {% snippet 'template_name', var=value, var2=value ... %} {% url_for(controller='foo', action='bar', ...) %} let me know if you want these changed eg remove need for () in url_for merged into demo branch they are just available in jinja templates no need to do anything special Let me know any problems or if you need some others added
#2497 1339085489000000 toby yes is ckan 1.7 issue
#2349 1339075361000000 ross Created symlink from /var/www/nginx-default/dump to the rdf output folder, accessible via http://s055.okserver.org/dump/ with daily dump available at http://s055.okserver.org/dump/rdfexport.tgz
#2293 1339062853000000 ross Intercepting the group name change and forcing a reindex of all of the datasets within that group seems like the obvious approach (rather than more lookups by ID after processing search results). Should take less than a day.
#2455 1338998214000000 aron.carroll Fixed as of 1dbe4df
#2494 1338994890000000 toby this was due to out of date version of demo branch - updated
#2454 1338994536000000 toby I am against providing much more that you did something bad things like invalid username leak info - people should not know if usernames exist. Maybe I'm a bit mean about this. I'd be happier to add some javascript check on the form post that checks for no password etc - maybe that's not so practical
#2454 1338993375000000 aron.carroll Implemented the templates for this. There are currently no decent error messages for missing fields, would be nice if we could have more specific error messages. eg. invalid username, username required, password required etc.
#2493 1338986768000000 aron.carroll Editing ticket title (sorry Toby I know you hate it)
#2474 1338982780000000 aron.carroll Closing this as we've decided to go with Jinja. There's some basic docs here: https://github.com/okfn/ckan/blob/feature-2375-demo-theme/doc/templating.rst And a template overview: https://github.com/okfn/ckan/blob/feature-2375-demo-theme/doc/template-blocks.rst Generally it's worth looking at the Groups pages to see how they're built.
#2445 1338982754000000 toby closing as todos moved to other tickets and also completed
#2491 1338979614000000 toby fixed by commit e6554e7
#2445 1338975600000000 toby @aron, this is as good a place as anywhere to answer your question about the c.form thing. a) some of this we are sort of stuck with. datasets for example can be of different types and have different forms for different datasets. so they need to be rendered separately. I have no idea why or how much this is used but it exists as an option to complicate everything, not much we can do about it. b) I think trying to do pages as a single rendering is not going to be easy because of the way ckan has been created maybe we can change this over time. One major issue for me is that ckan does lots of crazy stuff for some reasons but these reasons are not apparent from the code. Maybe there is some documentation somewhere but I'm not convinced. anyhow we should maybe close this ticket now. You've added some stuff in the comment for me to do maybe that should be added as a new ticket?
#2445 1338911190000000 aron.carroll Oh forgot to mention I've merged the code into feature-2375-demo-theme. We should delete the feature-2445-add-related-new branch.
#2445 1338911121000000 aron.carroll Thanks Ross this is exactly what I wanted. Just wondering about the use of the c.form variable to insert the form into the page. I know we do this with the dataset and groups to support legacy templates, do we need to do this going forward? I'd rather each action just rendered one template and leaves it up to that to render the rest. Toby, there's a couple of TODO statements in the code where the breadcrumbs need fixing. I think the templates just need access to the package dict. https://github.com/okfn/ckan/blob/feature-2375-demo-theme/ckan/templates/related/pages/form_page.html#L6 https://github.com/okfn/ckan/blob/feature-2375-demo-theme/ckan/templates/related/edit.html#L5 Also if you generate an error message on one of the forms (leave the title blank) the error string comes out wrapped in quotes. eg. u'title is missing' Also might be of interest, I've converted the templates to use Jinja, and this is a good example of the conversion. https://github.com/okfn/ckan/commit/d779addf6e48be67695b35c031393e2d90d8c22f
#2464 1338910189000000 johnglover Fixed for now, but had to keep group type as 'organization' as the string is hardcoded into the publisher auth profile in 1.7.1.
#2487 1338892521000000 johnglover https://github.com/okfn/ckanext-ecportal/commit/958208cfec1dfddb792b9b0ce0ac835fb1e2872a
#1737 1338719220000000 rgrp Let's close. What would be nice though is ETA on the GET support getting deployed on the DataHub -- just tried using it today and realized it didn't work :-)
#1345 1338551926000000 nils.toedtmann See #2485 for workarounds containing the leak(s).
#2445 1338542340000000 ross I *think* this is done in feature-2445-add-related-new although I may have missed something, if you could take a look and let me know if it is what you wanted.
#2437 1338487089000000 seanh I've also added the commit message guidelines as they reference a trac plugin I'm going to get installed. I'll leave the rest to you. I remembered that http://wiki.ckan.org/Main_Page has a bunch of pages under Developer Resources that should probably be updated and merged into these coding standards and deleted from the wiki
#2437 1338484676000000 seanh Please add to the file started to doc/coding-standards.rst Also, for the Python coding standards see http://wiki.okfn.org/Coding_Standards as a starting point
#2371 1338481174000000 toby implementation trial in ckan demo branch #2375
#2442 1338477973000000 toby @aron, related items on dataset page has been added it's really basic and just displays the fields that seem useful. we may need to add the add related item feature first as they are hard to add. please make it beautiful
#2445 1338474490000000 toby @aron I'm fine with the redirect thinking it's just the specific 303 rather than just whatever pylons does. @ross, templates_legacy are there for ckan users who have their own templates as we are completely rewriting all the existing templates there is a lovely .ini setting to switch between the new and legacy modes
#2445 1338473309000000 ross redirects are fine, of course, but redirect on validation failure seems painful ? Also templates in templates_legacy?
#2445 1338473161000000 aron.carroll I generally take the approach that a form submitted via POST should always redirect to a page. This prevents accidental user resubmissions when hitting refresh as well as the annoying popup saying "are you sure you want to re-submit". http://en.wikipedia.org/wiki/Post/Redirect/Get Looking at the rest of CKAN it doesn't do this so I'll leave it up to you.
#2445 1338472966000000 ross He didn't say but I assumed yes given current impl uses dodgy JS->API.
#2445 1338472624000000 toby @ross the validation error seems correct to use 200 for the created the 303 seems ok but i'd just use pylons redirect myself Also did aron say we want this as a javascript free add item form
#2445 1338472161000000 ross Am working in feature-2445-add-related-new
#2445 1338472050000000 ross Okay, the 303 on validation failure seems a little excessive though given that we're posting to that URL. Is a 200 okay?
#2414 1338471374000000 ross Merged by kindly
#2479 1338468431000000 markw An alternative (and better, but harder) way of dealing with the 'maintainer' issue would be to allow messages to be sent between CKAN accounts, and to have a field whose value is the maintainer's login.
#2466 1338467285000000 seanh Looks like we need to upgrade to Trac 0.12 and then install this plugin: http://trac.edgewall.org/wiki/SpamFilter
#2416 1338464207000000 toby commit 37622d5 does this but probably in the wrong place but works for now. Need to revisit at some point.
#2331 1338455981000000 kindly Scoring is primary in my opinion. Who cares if you have 1000 results if the top few are yours. If things are hard to find we need to change our relevancy first. So if you have examples of where you think the scoring is wrong then please make a ticket for that. Google, I imagine, just has a cutoff of anything under a certain score not being shown. We could do that as well but it would take some working out what we wanted that score to be. Full "And" queries also limit any accidental discovery, especially of rare terms. If you do not get your search exactly correct then you get nothing, which is bad. Obviously you can still AND things or +things. The correct solution to this is adding a minimum match parameter which is a middle ground. eg you can say that you want to match over half of the terms. "thing1 thing2 thing3 thing3" means you have to match at least 2. There are many options described here. http://wiki.apache.org/solr/DisMaxQParserPlugin. You can change this in an extension if you want it just requries adding an mm field to the before_search in the Ipackage controller. I do not personally think we should change it as default. I am closing it as wont fix as its trivial to change and is a philosophical difference not a technical one.
#2391 1338397982000000 seanh I've told them how to do it themselves and offered to help if they get stuck
#2431 1338397906000000 seanh https://github.com/davglass/github-trac
#2430 1338397815000000 seanh http://trac-hacks.org/wiki/MasterTicketsPlugin
#2433 1338397268000000 toby after discussion it has been agreed to keep the existing behaviour and improve documentation as it is likely to break existing applications etc
#2331 1338390995000000 rgrp @kindly I really don't get this but I may understand poorly. Google does not work by or-ing does it (as i add things to the search query I get *less* results not more ...). It also makes it really hard to find stuff: as I add query terms to my query I get more stuff not less which makes for terrible finding of stuff - I appreciate that there is a scoring aspect but that seems secondary.
#2441 1338384362000000 toby popular badges on package list - may make them optional/configurable at some point but good enough for now. see http://trac.ckan.org/ticket/2442 for details With the `order button` this is for none javascript users i'm not sure the magnifying glass looks like the thing to press to reorder the results. I'd hide it when javascript enabled. Do what you will @aron I'm assigning this to you close or reassign to me if you need extras adding
#2442 1338383819000000 toby new helper function for popular h.popular(type_, number, min=1, title=None) just related items left now
#2442 1338381909000000 toby now has actual tracking data to get data install ckanext-googleanalytics from source in analytics package dir run `paster loadanalytics internal 2012-01-01 -c ../ckan/development.ini` you may need to change .ini file name then in ckan dir `paster search-index rebuild -r -c dev.ini` It needs a refactor to make it easier to use
#2442 1338379591000000 toby popular localised need to get live tracking data and fixup (in progress) groups now shown including multiple with link to group page related items I'd like some data for this I'll see if I can add some
#2445 1338378161000000 toby @Ross you will need to do this based off the feature-2375-demo-theme branch - you can use that branch or one split from it. new templates want to be in templates/... the old templates live in templates_legacy if you need to copy them across that's fine talk to aron or I if you need to know anything
#2445 1338375577000000 ross Yup. Will look at this Thurs when I'm back in.
#2432 1338325120000000 shevski Where do new tickets go to await triaging? Is priority set by whoever creates the ticket? Does this get revised? Will we have a field for dev time estimate or where will this go?
#2441 1338306866000000 aron.carroll Not question mark sorry, I meant magnifying glass (inside the search box)
#2441 1338306828000000 aron.carroll There's already a submit button in the form (it's the question mark) it's up for discussion on Basecamp if this is clear, apparently it's not. I'm going to throw this back to you to implement the popular badges, I'll tidy that form up later. Perhaps we can get a helper such as h.isPackagePopular(pkg) that can be customised on a per instance basis.
#2442 1338305764000000 toby make readable * Group module needs to display group/publisher title, logo and description if dataset has an associated group. * Popular icon only needs to be displayed if dataset is popular. (say if it has 10+ views for the moment) * Popular icon needs localised text passed in to snippet (See TODO comment above helper https://github.com/okfn/ckan/blob/feature-2375-demo-theme/ckan/templates/package/read.html#L46) * Related module needs to show most recent item or fallback content.
#2442 1338302281000000 aron.carroll Functionality to be added: * Group module needs to display group/publisher title, logo and description if dataset has an associated group. * Popular icon only needs to be displayed if dataset is popular. (say if it has 10+ views for the moment) * Popular icon needs localised text passed in to snippet (See TODO comment above helper https://github.com/okfn/ckan/blob/feature-2375-demo-theme/ckan/templates/package/read.html#L46) * Related module needs to show most recent item or fallback content.
#2375 1338292898000000 toby stealing this ticket
#2441 1338291362000000 toby @aron, this is now in a snippet (jinja2 allows the selected="selected" more easily) needs some work still eg translation stuff and also maybe completely rewrite the snippet at some point. Anyhow the functionality is there. I added the button for no javascript working. I'm assigning to you for beautification etc on live demo http://s031.okserver.org:2375/dataset?q=&sort=title_string+asc
#2441 1338287243000000 aron.carroll Order by needs hooking up to form. Currently it's just a @<select>@ element containing a single entry, it needs the other possible options added. Let me know if you want more details.
#2470 1338284041000000 johnglover Search results validated against schema. Added a class implementing IPackageController, in after_search results are replaced with package dicts got from package_show. A bit heavy-handed, but works for now. Maybe we should just call package_show in the package_search logic function in core?
#2366 1338215334000000 ross Need to make sure there is a clear migration between authgroups and organizations if desired.
#2439 1338214158000000 icmurray The `fields` argument doesn't provide any extra functionality that the `query` argument can't provide. 1. Figure out what the reason for this argument is, just to make sure. 2. Deprecate it, and change any internal uses of it to use `query` field instead.
#2405 1338213564000000 icmurray Questions for client team: 1. Did you have anything in mind for improving the "Powered by CKAN" text and icon? I'll sort out the vertical alignment of the text and icon; and see if Sam has a better icon. 2. The branded section itself is already customizable by a snippet (https://github.com/okfn/ckan/blob/master/ckan/templates/snippets/data-viewer-embed-branded-link.html). Is that enough? Or are you asking for something else? 3. Personally I think the URI should use the resource uuid, and not name. And from recent discussions on ckan-dev, I think the consensus is the same. How important is this for you? Perhaps it's something that could be overriden in the datahub extension.
#2355 1338212946000000 toby Need to do documentation which is #2362 so has own ticket closing
← 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 →
Note: See TracReports for help on using and creating reports.