Ticket #2454 (closed enhancement: fixed)
Create demo login page
| Reported by: | aron.carroll | Owned by: | toby |
|---|---|---|---|
| Priority: | minor | Milestone: | demo phase 5 |
| Component: | ckan | Keywords: | demo-theme |
| Cc: | toby | Repository: | ckan |
| Theme: | none |
Description
Change History
comment:1 Changed 2 years ago by aron.carroll
- Milestone changed from ckan-sprint-2012-05-29 to current-ckan-sprint-2012-06-25
comment:2 Changed 2 years ago by aron.carroll
- Owner changed from aron.carroll to toby
- Status changed from new to assigned
Implemented the templates for this. There are currently no decent error messages for missing fields, would be nice if we could have more specific error messages. eg. invalid username, username required, password required etc.
comment:3 Changed 2 years ago by toby
I am against providing much more that you did something bad
things like invalid username leak info - people should not know if usernames exist.
Maybe I'm a bit mean about this.
I'd be happier to add some javascript check on the form post that checks for no password etc - maybe that's not so practical
comment:4 Changed 23 months ago by toby
- Owner changed from toby to aron.carroll
@aron,
I'd like to close this as a won't fix - your thoughts
comment:5 Changed 23 months ago by aron.carroll
- Owner changed from aron.carroll to toby
Hmm, I totally agree with you on the missing username front but it would be nice at least to provide the errors in the same way we do the other forms. Currently it just displays a flash message which is unexpected.
I'd suggest we add a generic "failed to login, invalid fields" in the error_summary block. Then more specific "this field is required" when a required field is left empty.
comment:6 Changed 23 months ago by toby
@aron,
I'm going to leave this open for the moment but not make the requested change as I need to think of the best way forward. The flash message error is quite hard coded into the logic and I need to think of a nice solution.
comment:8 Changed 23 months ago by toby
- Milestone changed from current-ckan-sprint-2012-06-25 to demo phase 1
comment:9 Changed 22 months ago by toby
- Milestone changed from demo phase 1 to demo phase 2
needs discussion and low importance
comment:11 Changed 21 months ago by aron.carroll
- Status changed from assigned to closed
- Resolution set to fixed
