{23} Trac comments (3729 matches)

Results (2801 - 2900 of 3729)

Ticket Posixtime Author Newvalue
#1632 1326736455000000 seanh This is finished, see the activity streams branch: https://github.com/okfn/ckan/tree/feature-1515-activity-streams but I think that before closing this ticket a little more thought needs to go into what the activity streams and the group page should look like, where on the page they should go, what else should go on the page, etc. Also maybe add a simple test that the activity stream is being rendered into the page.
#1632 1335877871000000 seanh Closing this as there doesn't seem to be interest in showing activity streams on group pages anytime soon
#1633 1326736502000000 seanh This is finished, see the activity streams branch: https://github.com/okfn/ckan/tree/feature-1515-activity-streams but I think that before closing this ticket a little more thought needs to go into what the activity streams and the dataset page should look like, where on the page they should go, what else should go on the page, etc. Also maybe add a simple test that the activity stream is being rendered into the page.
#1633 1335877927000000 seanh Closing this as there doesn't seem to be much interest in showing activity streams on group pages anytime soon.
#1635 1355141157000000 seanh https://github.com/okfn/ckan/pull/199
#1636 1338204258000000 seanh Resolving as won't fix as this doesn't seem important.
#1637 1326737169000000 seanh Done on feature-1515-activity-streams branch.
#1639 1328212781000000 seanh The templates have been rewritten to use CSS classes instead of embedded styles, but those CSS classes don't exist yet, they need to be added to a css file somewhere to style the activity streams.
#1639 1328213300000000 seanh See activity_stream_event() in ckan/templates/_util.html for the CSS classes used.
#1639 1328465219000000 seanh Basic CSS added.
#1663 1327919257000000 seanh Done in branch feature-1515-activity-streams
#1666 1326977528000000 seanh Done in feature-1515-activity-streams branch. Did not add activity streams for tags (as in the ticket description), instead added 'tag added' and 'tag removed' activities into the existing user and dataset activity streams.
#1698 1338204433000000 seanh Closing this super ticket, see remaining tickets with keyword "taxonomies": http://trac.ckan.org/query?status=accepted&status=assigned&status=closed&status=new&status=reopened&group=owner&max=1000&order=milestone&col=id&col=summary&col=status&col=owner&col=milestone&col=keywords&keywords=~taxonomies
#1705 1327945105000000 seanh Done in branch feature-1698-tag-taxonomies
#1705 1328094584000000 seanh Reopening because I still need to trace all the places in the model (tag.py, package.py, etc.) where there are methods that depend on tag names being unique, and then in the controllers and logic functions as well, and add new tests for the updated methods.
#1722 1328805890000000 seanh Done on branch feature-1698-tag-taxonomies
#1723 1328533040000000 seanh We're not going to update the existing tag and package classes (as long as they don't break), going to add our own functional tests in a new file instead.
#1724 1329302302000000 seanh I've updated tag_search() and tag_autocomplete() and added tests for them. So this ticket is finished now on branch feature-1698-tag-taxonomies
#1746 1355141062000000 seanh Closing this as won't fix, we decided to do http://trac.ckan.org/ticket/3018 instead
#1764 1335878051000000 seanh Closing because I'm not sure what the reason for doing this would be.
#1765 1328805833000000 seanh Done on branch feature-1698-tag-taxonomies
#1767 1328806740000000 seanh The API tests are done, in https://github.com/okfn/ckan/compare/master...feature-1698-tag-taxonomies#diff-24 on branch feature-1698-tag-taxonomies. The WUI tests still need to be done.
#1776 1328805695000000 seanh Implemented create_tag() and delete_tag() logic action functions. If you specify a vocabulary_id in the params you can use these to add tags to vocabs, one at a time. There are not yet functions for adding or removing multiple tags in a single API call.
#1785 1340724312000000 seanh No point in doing this for 1.8 because the new theme is coming along anyway, moving into 1.9
#1807 1330809641000000 seanh Implemented the recently-changed-datasets activity stream on branch feature-1807-recently-changed-datasets in CKAN and merged it into master (but the default templates don't make use of it). Added the recently-changed-datasets activity stream to the front page template on branch master in ckanext-ecportal.
#2208 1332251880000000 seanh I've attached a ckan.pot file. To make it, I edited setup.py in CKAN core like this: https://gist.github.com/2135849 and then ran python setup.py extract_messages. (And I had ckanext-ecportal installed at ~/pyenv/src/ckanext-ecportal.) I guess I may need to run this again when the ckanext-ecportal source is finalised, so leaving this ticket open for now.
#2226 1332159640000000 seanh These deployment docs seem worth moving into sphinx as well: http://wiki.ckan.org/Deployment
#2238 1343392681000000 seanh Ticket #2771 encompasses this and related changes. Vocabs probably won't be deployed to test.ckan.net but a working example extension using vocabs will be added to core instead. Closing this ticket as a dup
#2242 1333375436000000 seanh Conclusion: jenkins should work, may need some jenkins plugin magic to get it to show what branch each build was run on.
#2264 1333635637000000 seanh Many strings have been fixed (and committed on master). Still to go: When uploading a file: - The "Browse..." button. This comes from the user's browser? - Hangs when I try to upload a file, so the rest of this UI is unchecked. The licenses on the dataset add, edit and view pages, "License Not Specified" etc. Dataset state on dataset view page, e.g. "active". When adding or editing resources: - The resource types (Data File, etc.) The strings seem to come from resource.resource_type. - "You can use Markdown formatting here", "Should a DataStore table and Data API be enabled for this resource?", "Dates are in ISO Format — eg. 2012-12-25 or 2010-05-31T14:30". I can't get strings with hyperlinks in them to translate here. Dataset view page: - License not specified. Dataset search page: - "Tags", "Res_format" and "Groups" in the sidebar. Leaving because this code has been refactored on feature-1821-multilingual-extension. Fix after that branch has been merged. Dataset view page: - The resource types, e.g. "plain text". - The field names under additional information: cache_last_updated etc. Dataset history view: timestamps not localised. Login page: - "Login failed. Bad username or password. (Or if using OpenID, it hasn't been associated with a user account.)" This string is marked for translation but I can't seem to get translations to work for flash messages. Also "Sean Hammond is now logged in" flash message. Register page: - "Missing value" in error message when you try to register and don't give an email. The string seems to come from formencode. stdtrans() not working? User view page: - Activity streams strings. Activity streams genshi function needs a little refactoring to be i18n-friendly. Users page: - "less than 1 month". This string comes from Pylons' time_ago_in_words() function which doesn't appear to support i18n. New auth group (and edit auth group) page: - "Unique identifier for group. 2+ chars, lowercase, using only 'a-z0-9' and '-_'". This string is marked for translation but for some reason it isn't working. - "Name: Please enter a value" (in an error msg) - "User name". The string comes from class FormBuilder? Also, need to check that all tooltips are translated!
#2264 1334348070000000 seanh A few strings are still left to be marked for translation: - http://trac.ckan.org/ticket/2289 - http://trac.ckan.org/ticket/2288 - http://trac.ckan.org/ticket/2287 - http://trac.ckan.org/ticket/2290
#2297 1334569632000000 seanh http://ckan.okfnpad.org/27
#2304 1335878372000000 seanh I'm setting the priority of this high just because it's a low-hanging fruit for this sprint, as it was almost done last sprint.
#2304 1335885463000000 seanh Setting minor again after cleaning tickets out of this sprint
#2304 1337073870000000 seanh Currently implemented in this branch https://github.com/okfn/ckan/compare/master...feature-2304-follow waiting for code review and merge into master
#2304 1337158641000000 seanh Finished and merged into master
#2305 1335879165000000 seanh Setting the priority to major as I think it's worth getting this done since the follow support (which is almost finished) is a bit pointless without this.
#2305 1335885478000000 seanh Setting minor again after cleaning tickets out of this sprint
#2305 1340879812000000 seanh Implemented by Sven
#2313 1334756921000000 seanh Note that c.new_facets has now been renamed c.search_facets. Before this ticket is closed the old c.facets should also be removed from the template context. It's put there by ckan/logic/action/get.py:package_search(), which also puts the new c.search_facets there.
#2345 1335878420000000 seanh Setting priority high as we want this done by Friday for the 1.7 release.
#2345 1336492725000000 seanh Work on this has started in branch feature-2345-action-api-autodocs
#2345 1337962454000000 seanh Done but now I need to fix readthedocs again
#2386 1337967006000000 seanh Done. ckanext-spatial and ckanext-qa are not activated because they don't work with the current version of CKAN. datastorer is not installed yet.
#2391 1338397982000000 seanh I've told them how to do it themselves and offered to help if they get stuck
#2398 1337963342000000 seanh I'm closing this because we've got a whole bunch of tickets from the dev meetup about fixing the dependencies and requirements file that should deal with this problem
#2422 1337945204000000 seanh Closing because I'm not able to reproduce and it turned out floapps had publisher auth on which was overriding his rights auth
#2428 1341234933000000 seanh This awaiting merge, pull request: https://github.com/okfn/ckan/pull/46
#2428 1341314475000000 seanh Merged. The only thing I didn't do was add a test case that runs pip freeze and tests that all the right versions of deps are installed.
#2430 1338397815000000 seanh http://trac-hacks.org/wiki/MasterTicketsPlugin
#2431 1338397906000000 seanh https://github.com/davglass/github-trac
#2434 1341234522000000 seanh We've moved to AWS hosting with docs generated by Jenkins instead, see: http://trac.okfn.org/ticket/1254 There are still two issues to resolve: 1. Automatically updating the symlink so that docs.ckan.org always redirects to the latest stable version 2. Finding somewhere to put links to all the other versions
#2437 1338484676000000 seanh Please add to the file started to doc/coding-standards.rst Also, for the Python coding standards see http://wiki.okfn.org/Coding_Standards as a starting point
#2437 1338487089000000 seanh I've also added the commit message guidelines as they reference a trac plugin I'm going to get installed. I'll leave the rest to you. I remembered that http://wiki.ckan.org/Main_Page has a bunch of pages under Developer Resources that should probably be updated and merged into these coding standards and deleted from the wiki
#2466 1338467285000000 seanh Looks like we need to upgrade to Trac 0.12 and then install this plugin: http://trac.edgewall.org/wiki/SpamFilter
#2469 1340639702000000 seanh Closing this, has been broken down into individual tickets, see ckanbuild milestone
#2477 1343124123000000 seanh See thread on ckan-dev for list of officially supported non-core extensions: http://lists.okfn.org/pipermail/ckan-dev/2012-June/002439.html
#2507 1339596399000000 seanh merged
#2520 1340624831000000 seanh Also see #2370
#2549 1350561840000000 seanh Closing as we've gone forward with a different solution instead
#2601 1340723256000000 seanh I think this happens whenever you try to edit a dataset that has no organization
#2608 1343125400000000 seanh This seemed to be a problem in Firefox only and only when a certain Firefox extension was enabled, nothing quite got to the bottom of it, not worth fixing given the obscureness and difficulty
#2619 1340884739000000 seanh A thought about efficiency, you probably don't want to pass all the activities through the filter function since only the most recent 15 will be shown anyway. Suggest a filter function with an optional limit=15 argument, you pass it the whole activity list and it iterates over it until it has found 15 public ones then immediately returns those.
#2619 1351531137000000 seanh I think we need a function that filters out all activities and activity details where the user doesn't have permission to read either the subject or object of the activity or any of its activity details. Each of the *_activity_list() functions can then use it.
#2623 1341232433000000 seanh Works if you remember to enable publisher_auth (the Authorization button never appears, Join is always there, can Edit the org and add users that way)
#2624 1341583610000000 seanh Moving into 1.8 and making high priority, needed for cmap
#2624 1341609814000000 seanh Thanks Ross!
#2628 1343392717000000 seanh Already done on another ticket, closing this as dup
#2629 1343392596000000 seanh New ticket #2771 encompasses this and related changes, closing this one as a dup
#2630 1343392411000000 seanh I made another ticket (#2771) to encompass this and related work, closing this one as dup
#2682 1342447364000000 seanh Note that this commit fixes the double-counting for page views: https://github.com/okfn/ckan/commit/5739818a528bb16748f67b6d57a16f575ae78144 but not for resource downloads (which look like they could have the exact same fix) but I'm not particularly happy about the fix because I don't fully understand the SQL. It still needs unit tests and to be fixed properly, for both pages and resources
#2682 1342545573000000 seanh Talked with kindly, seems the above fix is correct and should be applied to resources as well
#2756 1343231863000000 seanh See commits: f5043a2, 2280428, a8eedda (the ticket number wasn't in the commit messages, sorry)
#2770 1343389747000000 seanh Done (but not log messages on history page, won't do those)
#2771 1343392265000000 seanh I've started working on this on a branch, will get it finished as soon as I can
#2771 1350303564000000 seanh Branch is here, but not finished yet: https://github.com/okfn/ckan/tree/2750-add-docs-and-examples-for-idatasetform-and-igroupform
#2772 1345027445000000 seanh Transifex was updated and translators notified, translations were made and pulled into 1.8
#2872 1350304179000000 seanh Just tested and this seems fixed so closing
#2878 1350561906000000 seanh Closing as we've gone forward with a slightly different approach instead
#2879 1350562096000000 seanh Closing as we've moved forward with a slightly different approach to organizations
#2880 1350561968000000 seanh Closing as we've moved forward with a slightly different approach to organizations in core instead.
#2883 1345629890000000 seanh Also see the thread here: http://lists.okfn.org/pipermail/ckan-discuss/2012-August/002382.html the questions asked in the thread should give ideas what to add to the overview
#2885 1345625524000000 seanh authz_form_table() in ckan/templates/package/authz.html creates a table with non-translatable labels (anon_editor, admin, editor, reader...)
#2900 1346335788000000 seanh Why does this only happen on user profile pages and not dataset search page or group read page? Looks like maybe only user profile page uses the package_list.html snippet
#2913 1350303779000000 seanh Moving into 2.0 milestone. Also affects 1.8.
#2931 1347891378000000 seanh Also set_global() seems to have the wrong docstring
#2937 1348157780000000 seanh This is fixed on master (commit e97b5c70e9325a1095778fef8e0d27c84e881b30) needs to be cherry-picked into 1.8
#2937 1348238875000000 seanh Cherry-picked into 1.8
#2968 1350297070000000 seanh This also applies to other pages such as /member_new and /member_delete
#2980 1350560137000000 seanh Won't do unless required by a specific client
#3007 1351517019000000 seanh Only happens if you create a dataset through the web UI, creating a dataset through the API still produces just one activity.
#3018 1355140950000000 seanh https://github.com/okfn/ckan/pull/171
#868 1292921428000000 sebbacon See also #867 Thanks for the patch.
#868 1292921456000000 sebbacon I mean #876, of course.
#876 1292924064000000 sebbacon Thanks for the info! Re. nested transactions. I am getting repeated non-deterministic test failures against sqlite (and indeed postgres, but these failures appear more frequent against sqlite). One of them I seemed to be able to get rid of by eliminating the savepoint as per your first point. However, it appears that sqlite [http://www.sqlite.org/lang_savepoint.html does] support savepoints; to demonstrate it, the following test code appears to work in the latest sqlalchemy: {{{ #!python from sqlalchemy import * from sqlalchemy.orm import * db = create_engine('sqlite:///') metadata = MetaData(db) users = Table('users', metadata, Column('user_id', Integer, primary_key=True), Column('name', String(40)),) users.create() class User(object): pass usermapper = mapper(User, users) Session = sessionmaker() session = Session() fred = User() fred.name = "Fred" sue = User() sue.name = "Sue" amy = User() amy.name = "Amy" session.add(fred) session.add(amy) session.begin_nested() session.add(sue) session.rollback() session.commit() assert session.query(User).count() == 2 print "OK" }}} So, while I agree they're not needed, I'm not sure they're a problem. What do you think? Also, have you seen non-deterministic test errors like this?
#937 1296385042000000 sebbacon Could consider using third-party analytics tracking here, which will also give referrer etc data for free? Would probably be bes provided in the form of optional piwik or google analytics integration. Being able to say in the UI how many downloads there have been would need piwik.
#937 1297689781000000 sebbacon I did a very quick hacky thing at the end of last week on top of the "insert google analytics code" extension we discussed, to work out "most popular packages" based off data harvested from the Google Analytics API. Needs making generic, tests etc but could be a starting point: https://bitbucket.org/sebbacon/ckanext-googleanalytics/src
#937 1297689859000000 sebbacon (and it would also need some proper caching as the GA API is very slow)
#937 1298892547000000 sebbacon The current implementation I referenced above will be a good starting point. Work that remains: * Add download click tracking to individual download links (currently we just record page views for packages, not downloads) * Somehow cache the download stats against each package (the Google API is very slow); package reddis or sqlite or similar as a local storage for the extension * Expose download information in the relevant places in the UI (all users? package owners? where?) This is about 2 days' work. Unlikely to get it done in this sprint.
#937 1302513831000000 sebbacon Completed; software at https://bitbucket.org/okfn/ckanext-googleanalytics/src
Note: See TracReports for help on using and creating reports.