{23} Trac comments (3729 matches)

Results (301 - 400 of 3729)

← 1 2 3 4 5 6 7 8 9 10 11 12 13 14 →
Ticket Posixtime Author Newvalue
#2664 1342181774000000 toby branch 2664-tag-errors has some ideas - how do we deal with whole errors issue
#2662 1342018898000000 toby this was actually an issue with form error anyhow fixed in both 2375 branches but needs pushing to the server
#2661 1342014327000000 toby @aron, we only can delete - see button if we have permission if you make logic/auth/delete.py package_delete() return {'success': True} then it will give everyone the permission - useful for testing
#2661 1342092578000000 aron.carroll Styled in c165639 Toby, it would be good to display a flash message once the dataset has been deleted.
#2661 1342515034000000 toby @aron, flash messages added I've changed these to being done via form javascript action: on click delete button display dialog confirm -> set hidden input name=confirm_delete value -> "yes" submit form no -> stop form submit hope that makes sense if not shout need this for dataset/group will also need for resource/related at some point soon
#2661 1342524525000000 aron.carroll Implemented in d980ec7. But we really need to go over the delete implementation as it could be much cleaner.
#2661 1342685899000000 toby @aron can you change this so that we now post to the href if confirmed should then work for group, dataset, related resource will pretend to work but not actually delete yet
#2660 1342011096000000 toby not reproducable
#2660 1342090270000000 toby this is sorted in master
#2660 1342090301000000 toby well not master but 2375-demo-theme-development which is good as
#2659 1342022519000000 toby looks like one for you aron
#2659 1342089310000000 aron.carroll Fixed in 9ff7a9b
#2658 1343378208000000 toby @aron, If we are doing this then we should just get it done asap. I have to say I think it sucks as an idea as I know what a group and a publisher is in english and we have groups. I'd like this a wontfix
#2658 1343378309000000 toby the mor i think about this the crapper it seems wtf - can we just close it and hope it goes away?
#2658 1352205894000000 johnmartin This is now invalid due to the work with orgs.
#2657 1342008765000000 toby fixed by aron
#2654 1343126740000000 ross Has a dependency on the new themes.
#2653 1342005167000000 toby config issue resolved
#2652 1343378442000000 toby this should sort some resource format issues
#2651 1341930964000000 ross The pull request at https://github.com/okfn/ckan/pull/60 resolves the problem with the dataproxy (which has also been updated to handle .tsv files). Still need to fix datastore.
#2651 1341935288000000 ross Need to update messytables and ckanext-datastore to make sure we can process tsv and store the data as tabular data in the datastore.
#2651 1342084112000000 ross Messytables has been updated. A new branch for ckanext-datastorer has been created, hoping to get someone with a fully working setup to help test.
#2651 1342440899000000 ross Have assigned to icmurray to test
#2648 1342517191000000 aron.carroll Assigning to Ira to QA
#2648 1342714659000000 shevski done
#2647 1342169056000000 toby @aron this button is now working on core http://localhost:5000/dataset/newcastle-city-council-payments-over-500/resource/0c2bd47a-6ac5-412e-a337-1b45a952e07e please note it is hidden in ckanext-demo also your `modal` think stops the link working - can you get it so that we open the href in a lightbox or somesuch. Also for now whilst waiting for the modal stuff to be implemented it'd be nice if it didn't block the link
#2647 1343229185000000 aron.carroll Modal stuff is in.
#2646 1342014170000000 toby fixed in 2375-demo-theme-development
#2644 1343925546000000 aron.carroll Updated the theme in 2b81958, seems very similar in functionality to the profile page...
#2644 1344255836000000 shevski I think this requires some thought & probably a discussion. For example need to be clear on the purpose of a user dashboard vs say a publisher dashboard. I image a publisher dashboard would have the stats to datasets belonging to that group (e.g. views, downloads, comments, shares, ratings), issues reported (when we get that extension working), call to action to add a new dataset (that adds it to the group). User dashboards I'm less clear about. May be we can talk about this on Tues/Wed? Or skype today
#2642 1342092375000000 toby moving to phase 2
#2642 1344243797000000 shevski Would like to have this for next week for a demo if possible
#2642 1344601299000000 toby @ira, can you review this http://s031.okserver.org:2375/harvest The add/edit form isn't perfect I have no idea how to use this extension so my testing has been limited make a new ticket for any problems - Also for now we only care about major issues @adriá would be nice if you could also see if it's working correctly
#2642 1345113645000000 shevski done
#2641 1343737625000000 shevski Design here: https://okfn.basecamphq.com/projects/9558659-demo-ckan-front-end/posts/65443876/comments
#2641 1343738074000000 amercader It looks awesome, really nice! Note that the "Enter location" box logic (geocoding) is not yet implemented, so first stage of the widget should not show it.
#2641 1352206794000000 johnmartin I can't get access to the project... can someone link me?
#2640 1342092306000000 toby moving to phase 2
#2639 1343297711000000 amercader Merged into master before 1.8. There are a couple of issues with that need to be fixed on recline code base: * Filter does not fire the state change event (Embed URL does not get updated) https://github.com/okfn/recline/issues/195 * File format not saved in Dataproxy state (Embed fails with dataproxy files with no extension) https://github.com/okfn/recline/issues/196 When we fix these on recline we can update the build on ckan core.
#2639 1345125290000000 rgrp #196 is fixed. Not sure about #195. Otherwise think we are good to go.
#2639 1345125344000000 rgrp There is also an additional issue which is that recline no longer uses elasticsearch_url so we will need to patch this either in js or in the controller code for the embed ...
#2639 1345146087000000 rgrp Also found that previous recline setup used elasticsearch_url in recline 'state' (dataset part) when generating embed_url for dataset. But recline no longer supports this so move to url attribute of dataset attribute of state.
#2639 1345146289000000 rgrp Port of fix for recline issue 196 in https://github.com/okfn/ckan/commit/fd1abd9d5701b4addf7e709c1766d6ffed1bb8bf Fix of embed issue in https://github.com/okfn/ckan/commit/fd1abd9d5701b4addf7e709c1766d6ffed1bb8bf
#2639 1345221501000000 amercader Added some new comments to #195: https://github.com/okfn/recline/issues/195
#2638 1342112772000000 toby merged
#2637 1342617226000000 toby fixed
#2636 1342090614000000 toby duplicate of http://trac.ckan.org/ticket/2631
#2634 1342085656000000 toby merged into master
#2632 1342087027000000 toby merged
#2631 1352205778000000 johnmartin This has been fixed with the LOD2 work on activity streams.
#2630 1343392411000000 seanh I made another ticket (#2771) to encompass this and related work, closing this one as dup
#2629 1343392596000000 seanh New ticket #2771 encompasses this and related changes, closing this one as a dup
#2628 1343392717000000 seanh Already done on another ticket, closing this as dup
#2624 1341583610000000 seanh Moving into 1.8 and making high priority, needed for cmap
#2624 1341599776000000 ross Is likely just tags missing from the new schema in organizations. Will add/test etc on Monday AM.
#2624 1341609814000000 seanh Thanks Ross!
#2623 1341232433000000 seanh Works if you remember to enable publisher_auth (the Authorization button never appears, Join is always there, can Edit the org and add users that way)
#2620 1342074737000000 toby This got fixed at some point
#2619 1340884739000000 seanh A thought about efficiency, you probably don't want to pass all the activities through the filter function since only the most recent 15 will be shown anyway. Suggest a filter function with an optional limit=15 argument, you pass it the whole activity list and it iterates over it until it has found 15 public ones then immediately returns those.
#2619 1346670257000000 ross Have a push request with a privacy flag which might be useful in determining the status of the dataset (public/private) but no idea if it will be accepted yet. Have assigned back to you for safe-keeping so it doesn't get lost in backlog.
#2619 1351531137000000 seanh I think we need a function that filters out all activities and activity details where the user doesn't have permission to read either the subject or object of the activity or any of its activity details. Each of the *_activity_list() functions can then use it.
#2616 1352206282000000 johnmartin Old and not sure of context. Closing.
#2614 1343685572000000 aron.carroll Done in 71aca07. Moving paster to a seperate ticket.
#2612 1342005674000000 toby is this still valid?
#2612 1342005971000000 shevski This seems to be fixed, but needs proper testing
#2612 1342007335000000 toby cool close when you are happy or reassign if you find it broken somewhere I'm moving this to phase 2
#2612 1342714613000000 shevski All looks good for now. Need to review authorisation stuff as part of demo 3
#2611 1342008509000000 aron.carroll Done aside from Change 'Groups' to 'Publishers' everywhere which is now #2658
#2610 1341501424000000 aron.carroll Replaced by #2611
#2609 1340900271000000 toby fixed in demo branch
#2608 1343125400000000 seanh This seemed to be a problem in Firefox only and only when a certain Firefox extension was enabled, nothing quite got to the bottom of it, not worth fixing given the obscureness and difficulty
#2605 1340874110000000 ross Seeing *very* strange behaviour here with the tests working fine when run individually, but when run as part of the entire suite it is returning an old group (called david) that is NOT in the database (set breakpoint, queried db, not there). Hoping Mr Raznicks sqlalchemy skills will be able to see what is going on with this.
#2605 1343126767000000 ross Make a decision on how we can test this cleanly and get it into 1.8
#2605 1343127369000000 ross Code for the CTE fix is in master ready for 1.8 branch.
#2602 1340805904000000 ross After merging the 2601 fix the user can no longer set None as the group/organisation for a dataset
#2601 1340723256000000 seanh I think this happens whenever you try to edit a dataset that has no organization
#2601 1340960128000000 ross We've taken steps to make sure that users can't add datasets without a group, and can't remove a dataset from a group (without deleting it). Will submit patch to restrict adding without group.
#2600 1340721815000000 ross Should do this as part of #2548
#2599 1340798251000000 aron.carroll This is still broken in IE7 as of 543954b but pretty good in other browsers.
#2599 1346236806000000 johnmartin FYI: My methodology for getting the demo working in IE7 will be: get it functioning and not get it perfect
#2599 1346756230000000 johnmartin This is now closed and waiting pull request merge back in.
#2598 1340875020000000 aron.carroll Fixed in 8dc7c56
#2596 1345209485000000 toby closing as too vague and probably done
#2595 1342086346000000 toby yadda, yadda, yadda - this should all be done any bugs are new tickets
#2587 1340375763000000 shevski If we have a name then yes, should be even without link.
#2587 1340376975000000 toby fixed by 99d14bd
#2584 1340620576000000 aron.carroll Implemented in 9bebf3d
#2583 1342086274000000 toby moving to phase 3 as really a review of our code type stuff
#2582 1340313961000000 rgrp As this has been a serious UX issue for a while and it may take a while to be fixed I've taken the temporary step of fixing this directly on the datahub.
#2581 1340287539000000 toby do before data.pop(key)
#2581 1340369369000000 toby fixed in commit 0f84d99 in the demo branch david can you just look at this for a sanity check - I'm just concerned that only state benefits from this if good reassign to me and i'll remove the fixme
#2581 1340711431000000 kindly This looks fine, just make doubly sure that if this flag is set then whatever sets it explicitly sets the state i.e overrides what the user sent.
#2581 1340714955000000 toby @kindly we actually need an extra state for full functionality can we create a new 'draft-complete' state as well? does that need any additional magic? please answer and reassign
#2581 1340728155000000 kindly No any state without active, pending or deleted in their name is fine.
#2581 1340800263000000 toby part of add dataset stages
#2580 1342092353000000 toby I'm closing this as now you need to add at least one resource
#2579 1340899337000000 toby This can move to 1.9 as will need agreement to be merged
#2577 1346669735000000 ross Better info was provided by jmckinney
#2576 1340300413000000 aron.carroll Fixed in fbeda87
#2576 1340369674000000 toby @aron the resources sidebox is still broken breadcrumb is fixed though
← 1 2 3 4 5 6 7 8 9 10 11 12 13 14 →
Note: See TracReports for help on using and creating reports.