Ticket #2639 (closed enhancement: fixed)

Opened 22 months ago

Last modified 19 months ago

Update recline version for 1.8 release

Reported by: amercader Owned by: amercader
Priority: awaiting merge Milestone: ckan-v1.8
Component: ckan Keywords: recline
Cc: rgrp, icmurray Repository: ckan
Theme: none

Description

New recline version has significant improvements like the SlickGrid? based grid view, it'd be good to have it on 1.8.

Change History

comment:1 Changed 22 months ago by amercader

  • Status changed from new to accepted

comment:2 Changed 22 months ago by amercader

  • Priority changed from major to awaiting merge

comment:3 Changed 21 months ago by amercader

  • Cc rgrp, icmurray added

Merged into master before 1.8. There are a couple of issues with that need to be fixed on recline code base:

  • Filter does not fire the state change event (Embed URL does not get updated)

https://github.com/okfn/recline/issues/195

  • File format not saved in Dataproxy state (Embed fails with dataproxy files with no extension)

https://github.com/okfn/recline/issues/196

When we fix these on recline we can update the build on ckan core.

comment:4 Changed 21 months ago by rgrp

#196 is fixed. Not sure about #195. Otherwise think we are good to go.

comment:5 Changed 21 months ago by rgrp

There is also an additional issue which is that recline no longer uses elasticsearch_url so we will need to patch this either in js or in the controller code for the embed ...

comment:6 Changed 21 months ago by rgrp

Also found that previous recline setup used elasticsearch_url in recline 'state' (dataset part) when generating embed_url for dataset. But recline no longer supports this so move to url attribute of dataset attribute of state.

comment:8 Changed 21 months ago by amercader

comment:9 Changed 19 months ago by amercader

  • Status changed from accepted to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.