Ticket #2639 (closed enhancement: fixed)
Update recline version for 1.8 release
| Reported by: | amercader | Owned by: | amercader |
|---|---|---|---|
| Priority: | awaiting merge | Milestone: | ckan-v1.8 |
| Component: | ckan | Keywords: | recline |
| Cc: | rgrp, icmurray | Repository: | ckan |
| Theme: | none |
Description
New recline version has significant improvements like the SlickGrid? based grid view, it'd be good to have it on 1.8.
Change History
comment:3 Changed 21 months ago by amercader
- Cc rgrp, icmurray added
Merged into master before 1.8. There are a couple of issues with that need to be fixed on recline code base:
- Filter does not fire the state change event (Embed URL does not get updated)
https://github.com/okfn/recline/issues/195
- File format not saved in Dataproxy state (Embed fails with dataproxy files with no extension)
https://github.com/okfn/recline/issues/196
When we fix these on recline we can update the build on ckan core.
comment:5 Changed 21 months ago by rgrp
There is also an additional issue which is that recline no longer uses elasticsearch_url so we will need to patch this either in js or in the controller code for the embed ...
comment:6 Changed 21 months ago by rgrp
Also found that previous recline setup used elasticsearch_url in recline 'state' (dataset part) when generating embed_url for dataset. But recline no longer supports this so move to url attribute of dataset attribute of state.
comment:7 Changed 21 months ago by rgrp
Port of fix for recline issue 196 in https://github.com/okfn/ckan/commit/fd1abd9d5701b4addf7e709c1766d6ffed1bb8bf
Fix of embed issue in https://github.com/okfn/ckan/commit/fd1abd9d5701b4addf7e709c1766d6ffed1bb8bf
