Ticket #2661 (closed enhancement: fixed)

Opened 22 months ago

Last modified 22 months ago

delete dataset/group javascript confirm

Reported by: toby Owned by: aron.carroll
Priority: major Milestone: demo phase 2
Component: ckan Keywords: demo-theme
Cc: Repository: ckan
Theme: none


in 2375-demo-theme-development

templates/package/confirm_delete.html needs to be made to look nice note some writing in black

delete button needs nice home on dataset/edit

you can add js support add ?confirm=yes to url on dataset button to force delete

Please note delete is not yet implemented - but will be in the next few hours

Change History

comment:1 Changed 22 months ago by toby


we only can delete - see button if we have permission

if you make logic/auth/delete.py package_delete() return {'success': True} then it will give everyone the permission - useful for testing

comment:2 Changed 22 months ago by aron.carroll

Styled in c165639

Toby, it would be good to display a flash message once the dataset has been deleted.

comment:3 Changed 22 months ago by toby

  • Summary changed from prettify delete dataset to delete dataset/group javascript confirm


flash messages added

I've changed these to being done via form

javascript action:

on click delete button display dialog

confirm -> set hidden input name=confirm_delete value -> "yes" submit form

no -> stop form submit

hope that makes sense if not shout

need this for dataset/group will also need for resource/related at some point soon

comment:4 Changed 22 months ago by aron.carroll

Implemented in d980ec7. But we really need to go over the delete implementation as it could be much cleaner.

comment:5 Changed 22 months ago by toby


can you change this so that we now post to the href if confirmed

should then work for group, dataset, related

resource will pretend to work but not actually delete yet

comment:6 Changed 22 months ago by toby

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.