Move stats extension back into core - 0.5d

[rgrp]

• Move into core (keeping as an extension) and default enable
• Do we need tests for controller? (No: already there)
• Documentation (?) - e.g. of basic config options
• Remove lib/stats.py which is still in core
  • dread moved it to extension in ​https://github.com/okfn/ckanext-stats/commit/293b2544737d8ab7610884bd5e999ee37f1ab813 but did not remove from core
• Deprecation notice on ckanext-stats repo and update extension registry

Est: 0.5d.

Questions:

• Why do this?
  • tiny extension with few dependencies - and really nice to have out of the box
  • trial for doing this on larger scale
• Do we keep as extension (even if in core)?
  • Ans: Yes, keep as extension because:
    • Already set up that way
    • Cleaner
    • Easier to disable / enable
• How do we integrate with main them (e.g. have stats link)
  • Ans: not sure (this is part of more general issue of how we update theme for varying changes elsewhere). Best answer is to have some widgetization in theme.
• Hide ratings section (at least until we reinstate ratings #1598)
  • Ans: no, let's not bother (and having ratings there encourages us to do #1598 and/or find out whether people are interested in ratings)

[rgrp]

Updated wiki page (stats was not on there yet!): ​http://wiki.ckan.org/Extensions#Stats_-_Statistics_for_CKAN and added deprecation notice on ​https://github.com/okfn/ckanext-stats

[rgrp]

Fixed. Merge cset: ​https://github.com/okfn/ckan/commit/cb29d62133bb4d060622f2fa752dd281b71a252b

[rgrp]

Some questions arising from this. Now on ​http://ckan.okfnpad.org/extensions

• How do I add Stats to a menu ...
  • ANS (?): Main menu: should make this configurable sooner rather than later (what about footers ...)
• How do I have plugins support other plugins ...
  • E.g. stats incorporate QA info

Extensions in Core

• Do we centralize templates and public directory or not ...
  • (+) quicker, simpler
  • (-) have to change things, does it mess up non-core extensions

• Tests: need to be run! (Put them into core area ...)

Qu: Going forward how do we handle extensions and plugins

Specifically:

• Inclusion of html into *core* html - e.g. showing download counts ...
  • Concrete examples:
    • Including widgets into the dashboard
    • Including widgets in stats section
  • (not simply inclusion of html into routing system separate from core -- which is relatively trivial)
  • More entry points?

Other stuff I think we should look at

• config in dashboard