{23} Trac comments (3729 matches)

Results (1301 - 1400 of 3729)

← 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 →
Ticket Posixtime Author Newvalue
#1529 1324318628000000 dread Was done in cset:237ad148ba9 on master 7/12/11, aimed for 1.5.2
#1519 1324317373000000 rgrp wontfix for present. * stats should go into core see #1576 * but analytics is more complex and requires more thought. Not really sure what integration buys us right now (though understand from a deployment / client perspective these together in some way so may be worth revisiting in future)
#1543 1324316682000000 johnglover Fixed: https://github.com/okfn/ckan/commit/f3b2bb9827b082ee09c74ede85ded21838fc9e80 Needed to refactor fix for 1501 slightly so that the search controller can still use its own url generator. Added new test for search pagination.
#1563 1324314806000000 rgrp This is done and invalid to add this again.
#1570 1324314741000000 rgrp Deleting this ticket as integrated file storage has been available and finished for months.
#892 1324314636000000 rgrp Moved to v1.6.
#906 1324299793000000 rgrp Do we need to change in core code or just configure solr?
#1466 1324298713000000 rgrp Moving to v1.6 as no specific milestone for this.
#1519 1324297045000000 johnglover Didn't have time to look at this in previous sprint, moving to current sprint.
#1543 1324296991000000 johnglover New ticket, moving to current sprint
#1394 1324292900000000 dread Defo for this sprint.
#1432 1324290164000000 ross PhantomJS ( http://www.phantomjs.org/ ) looks like the perfect way to run a JS scraper offline but still within the context of a browser. Would need to consider how the script would be executed over multi-page datasets, but I'm fairly sure it would be possible to come up with a workable solution.
#1451 1324288407000000 johnglover Need to add analytics javascript to new resource view page, will do under ticket #1519.
#1099 1324057106000000 dread Authorization groups deprecated with the Group refactor #1477
#1133 1324057072000000 dread Works for me - change occurs successfully. {{{ (pyenv-ckan)dread@dread-laptop:~/gitroot/ckan$ paster rights add russianfan admin warandpeace /home/dread/gitroot/pyenv-ckan/lib/python2.6/site-packages/pylons/templating.py:610: UserWarning: Unbuilt egg for setuptools [unknown version] (/usr/lib/python2.6/dist-packages) Engine = entry_point.load() User russianfan -> is admin on -> Package warandpeace (pyenv-ckan)dread@dread-laptop:~/gitroot/ckan$ paster rights /home/dread/gitroot/pyenv-ckan/lib/python2.6/site-packages/pylons/templating.py:610: UserWarning: Unbuilt egg for setuptools [unknown version] (/usr/lib/python2.6/dist-packages) Engine = entry_point.load() 22 results User visitor -> is editor on -> Package annakarenina User logged_in -> is editor on -> Package annakarenina User testsysadmin -> is admin on -> System system User logged_in -> is editor on -> System system User visitor -> is reader on -> Group david User annafan -> is admin on -> Package annakarenina AuthorizationGroup anauthzgroup -> is reader on -> Package warandpeace User visitor -> is editor on -> Package warandpeace AuthorizationGroup anauthzgroup -> is editor on -> Group david User logged_in -> is editor on -> Package warandpeace User logged_in -> is reader on -> Group david User visitor -> is reader on -> Group roger User logged_in -> is reader on -> Group roger User russianfan -> is admin on -> Package warandpeace User visitor -> is admin on -> Package warandpeace AuthorizationGroup anotherauthzgroup -> is editor on -> AuthorizationGroup anauthzgroup User russianfan -> is admin on -> Group roger User russianfan -> is admin on -> Group david AuthorizationGroup anauthzgroup -> is admin on -> AuthorizationGroup anotherauthzgroup User visitor -> is anon_editor on -> System system User visitor -> is admin on -> Group roger AuthorizationGroup anauthzgroup -> is editor on -> System system }}} Tests would be nice, but it currently works, is only for admins and is therefore not as high priority as other other tests, such as front-end js.
#1553 1324056939000000 dread This is now ameliorated in thedatahub.org by requiring login to do any edits. But the bug may be an issue for other sites that want more open settings.
#1552 1324056240000000 dread Done: [release-v1.5.1c 9850afc]
#1115 1324054704000000 dread Authorization groups deprecated with the Group refactor #1477
#1380 1324048324000000 dread This has gone into v1.5.1.
#1378 1324047835000000 dread Went into release 1.5.1
#1409 1324047722000000 dread In 1.5.1 release.
#1371 1324037905000000 dread Goes into release 1.5.1.
#1381 1324037815000000 dread In release 1.5.1.
#1549 1324037471000000 dread I see a need for short links to any package or resource, so people can Twitter about them. As far as providing forwarding to a resource URL, even if that changes, then I'm not sure there is a need for it to be short - we could just use a long link with the resource-id. e.g. thedatahub.org/resource/c1e89abb-13cd-4e18-9078-03d15bf6f256/url-forward.
#1319 1324036947000000 dread Goes into release 1.5.1
#1386 1324036930000000 dread These changes go into release v1.5.1.
#1504 1324035928000000 dread Cherry picked for 1.5.1.
#1546 1324034396000000 dread Broken since introduction in CKAN 1.3. Fixed in CKAN 1.5.1.
#806 1324034356000000 dread This was introduced in CKAN 1.3
#1430 1324033923000000 dread Fixed in CKAN 1.5.1. Affects all previous CKANs that use SOLR in these circumstances.
#1490 1324033557000000 dread Fixed in 1.5.1 * group_package_show introduced in 1.5.1 * tag_show added extended packages in 1.5 (e6bad88a) * package_search added extended packages in 1.5 (e6bad88a)
#191 1324030875000000 johnglover Thanks for this David. This one in particular was causing me some grief: https://github.com/okfn/ckan/commit/f98a4b2a5f5013fa4aed475bd8b3237bb7847fcc Good spot. All looks good to me.
#191 1323973116000000 dread I put the sort syntax example in the apiv3.rst table and moved the full curl example to http://wiki.ckan.org/Searching_CKAN I added tests for metadata_modified and prepared this branch for closure. Changeset: [origin/defect-191-modification-date bebf7a5] John, please review and close/merge if you think it is all ok.
#1546 1323970014000000 dread The fix for the break related to 191 is checked in here: [release-v1.5.1c 2c595ae] and cherry picked to [origin/defect-191-modification-date f98a4b2]
#191 1323970011000000 dread Added a fix for the problems caused by the #1546 fix. SOLR indexing was excepting for new packages (tests such as ckan/tests/functional/api/model/test_package.py:TestPackagesUnversioned.test_entity_update_indexerror failed). The problem was (somehow) related to last_modified function using a new connection causing problems for the modified_metadata in finding the revision & package table entries created during the commit. Changeset: [release-v1.5.1c 2c595ae] and cherry picked to [origin/defect-191-modification-date f98a4b2]
#1546 1323962689000000 dread It looks like Rufus forgot the second bit of the AND clause: {{{ and_(model.revision_table.c.id==model.package_revision_table.c.revision_id, + model.package_revision_table.c.continuity_id==self.id) ) }}} Unfortunately John's fix breaks the #191 fix. I'm reopening that to fix it there.
#1532 1323956004000000 dread I couldn't see a way to communicate the situation "OpenID authenticated, but doesn't match any CKAN user" from the repoze middleware to CKAN. So in [release-v1.5.1c 9e86c8b] I have provided extra instructions in the OpenID log-in screen, and in the log-in error message suggest what could have gone wrong. This issue appeared in 1.5.1b and fixed in 1.5.1c in time for the 1.5.1 release.
#1548 1323888271000000 dread Done in cset:35bfe8e in master.
#1503 1323793662000000 dread All done now.
#1546 1323775424000000 johnglover Fixed: https://github.com/okfn/ckan/commit/fbaf4459b7da95c1db0ade165ea09720539c2f80
#1407 1323764239000000 rgrp Fixed in https://github.com/okfn/ckanext-stats/commit/a95bbf7ffc0a36a747467f568a011b6865b64478.
#1518 1323762304000000 rgrp Fixed in https://github.com/okfn/ckan/commit/3b209af3656851e560aeb4d6f5563f05897c8f01
#1518 1323761438000000 rgrp Further investigation shows that: * Spaces and any other characters work fine with local file storagfe * Google escapes other non-url allowed characters (so should work fine)
#1518 1323760656000000 rgrp Debug via js console revealed the problem: Google storage replaces spaces with +.
#1465 1323710679000000 dread Pls update status and milestone.
#1464 1323710659000000 dread Pls update status and milestone
#1298 1323710593000000 dread Sean says: This is done on the activity stream branch. Just would like David Raznick to review it.
#1466 1323710030000000 dread Is this still critical, James?
#191 1323708844000000 dread A test for this would be great, and maybe add as an example in the search docs too?
#191 1323706210000000 johnglover working in current master and 1.5.1
#1491 1323703317000000 seanh Merged into master
#1503 1323695557000000 dread The repos moved to github have now been deleted on bitbucket.
#1516 1323362689000000 nils.toedtmann Please note that * register.data.overheid.nl (s047) and datagm.org.uk (s048) should use solr on s046 - see http://trac.okfn.org/ticket/906 * thedatahub.org should use solr on s052 - see http://trac.okfn.org/ticket/931
#1516 1323360020000000 amercader Closing as the main Solr servers are ready to support different Solr schemas. I.e they have two different cores: * http://<server>/solr/ckan-schema-1.2 * http://<server>/solr/ckan-schema-1.3 to which CKAN instances can point to. The CKAN instances that have not been updated (the ones under s004) are pointing to a Solr core with an old version of the schema, so they can wait until upgraded to 1.5.1 to update the solr_url property and rebuild the index. Data.gov.uk can be dealt with during the next deployment. It's not clear which Solr server are using the rest of the instances, but they can be updated as necessary when they upgrade their CKAN instance.
#1533 1323359638000000 ross Investigating: 1. The XPATH that the middleware is currently using will definitely not match the navigation on 1.5.1, we'll need to change the xpath and also extract the anchors from the LI tags that are retrieved from the wordpress site. 2. Getting the main wordpress content just doesn't seem to work at all. Lots of class/id confusion. Will fix for 1.5.1 in branch
#1536 1323349465000000 dread Fixed on master - cset:39b745f. Aimed for 1.5.2 branch (should be on thedatahub.org in a few days).
#1086 1323346552000000 dread Authorization groups are deprecated with the incoming Groups Refactor #1477
#1530 1323283663000000 dread Cheers Lucy. Ok the gap between the name field and its help text is way too big. Zeph, any chance you can take a look?
#1435 1323283538000000 dread From IRC today: {{{ <rgrp> dread: btw have a big suggstion -- switch to continuous.io for our buildbot stuff ... <rgrp> openspending have done this and it's a nice setup ... <dread> rgrp: interesting - what's better? <dread> i assume it just starts a script and reports the result? <rgrp> that's right though also has integration with some bakcens (but we probably don't need that) <rgrp> the point is we don't need to boot machines, install and configure buildbot etc (though we may now have automated that ...) <dread> ah, i see, it's in the cloud <dread> did all that months ago, and don't need to setup the machine any more. <dread> if we do it again though, I'm all for it }}}
#1530 1323283240000000 lucychambers Screenshot attached - browser = Chrome
#1503 1323281764000000 dread This is still ongoing - see the spreadsheet!
#1520 1323280999000000 dread Rufus has persuaded me that this is not important since it is so rare, and focus on #1534 (which was #1514) instead.
#1520 1323279697000000 rgrp wontfix in favour of #1534 (a proper fix)
#1483 1323279151000000 johnglover Fixed. Updated logic layer: https://github.com/okfn/ckan/commit/520959ca6f83586d33cf7d4015d625a776ee46a1 Updated tasks (qa, archiver, webstorer): https://github.com/okfn/ckanext-qa/commit/78cbf5c6d16225e1580aee23fdf884f88d2475f5 https://github.com/okfn/ckanext-qa/commit/8553348942adad0babd4bdd91820c1d75a1784a7 https://github.com/okfn/ckanext-archiver/commit/8ed419280bd7f2e66aeb4f17f3f546d941fe11fb https://github.com/okfn/ckanext-webstorer/commit/d16fb090533a716c856e59838f79bbaa0ea42e76
#1514 1323279018000000 rgrp This is now a duplicate of #1534
#1386 1323278831000000 rgrp See #1534 for remaining work to ensure that when usernames get changed connection with activity is not lost.
#1413 1323269472000000 dread Code reviewed - looks really good. Do merge in to master if it is not already. A couple of tips: * we all use 'model.User' instead of 'model.user.User' but it's not important for tests... * probably better to use CreateTestData.create_user() to create user objects in the future, avoiding faffing around with creating revisions etc. that are also nastier to debug when they go wrong.
#1511 1323264315000000 seanh Should be as a list of dicts, not Activity objects.
#1396 1323255616000000 markbrough +1 on listing owned datasets and seeing all historical activity for a user (especially for logged in user :-) )
#1528 1323198001000000 zephod Done here. https://github.com/okfn/ckan/commit/b2748e395760083be2071b007641e787a071f955
#1004 1323195485000000 dread Great stuff zeph! Diff looks really good and cheers for the explanation. On master, cset:a89a48731ba548170045a60ac2930e0019c299c7 and I've cherry picked this for release 1.5.1. too.
#1004 1323194016000000 zephod Dread, that fix wouldn't work because the class attribute was being defined in Genshi and again in HTML, with slighly undefined behaviour (in this case Genshi overwrites HTML). I have performed a very very simple fix which modifies the navbar text when you're not logged in. https://github.com/okfn/ckan/commit/a89a48731ba548170045a60ac2930e0019c299c7 I don't think the link should be restored in the sidebar, it was explicitly removed as part of a site-wide sweep to make the sidebar a passive, helpful element rather than an active element with action links. Site looks great to me, I'm closing this ticket.
#1004 1323187352000000 dread Here is the unclipped version: {{{ <p> <span i18n:msg="" class="ckan-logged-in" style="display: none;"> <a href="${h.url_for(controller='group',action='new', id=None)}">Create a new group</a> </span> <span i18n:msg="" class="ckan-logged-out"> To create a new group, please first <a href="${h.url_for(controller='user',action='login', id=None)}">log-in</a>. </span> </p> }}} {{{ <li py:attrs="{'class':'current-tab'} if c.action=='new' else {}" class="ckan-logged-in" style="display: none;"> ${h.subnav_link(c, h.icon('group_add') + _('Add a Group'), controller='group', action='new')} </li> <li py:attrs="{'class':'current-tab'} if c.action=='new' else {}" class="ckan-logged-out"> ${h.subnav_link(c, h.icon('group_add') + _('Log-in to add a Group'), controller='group', action='new')} </li> }}}
#1485 1323186842000000 ross Implementing an initial IPackageController in ckanext-example
#1508 1323184952000000 ross Custom form is referenced in #1485
#1285 1323178678000000 dread Isn't the point is we don't to raise an exception at all - we want to call a method to send the email and then return from the controller a normal html page. Don't we just need a method to get the error email address from the config and send an email.
#1445 1323178176000000 zephod JohnGlover has done most of this and I've been adding aesthetic tweaks. The resource page is now tidy and has a similar look and feel to its parent Dataset view page. I'm closing this ticket and its sibling #1450; I am merging the feature-1450-dataset-view branch which contains all of this work.
#1004 1323177994000000 dread My suggested fix: {{{ diff --git a/ckan/templates/group/index.html b/ckan/templates/group/index.html index 8502df9..064e066 100644 --- a/ckan/templates/group/index.html +++ b/ckan/templates/group/index.html @@ -9,7 +9,15 @@ <py:match path="primarysidebar"> <li class="widget-container boxed widget_text"> <h3>What Are Groups?</h3> - <span i18n:msg="">Whilst tags are great at collecting datasets together, + <p><span i18n:msg="">Whilst tags are great at collecting datasets togethe + <p> + <span i18n:msg="" class="ckan-logged-in" style="display: none;"> + <a href="${h.url_for(controller='group',action='new', id=None)}">Creat + </span> + <span i18n:msg="" class="ckan-logged-out"> + To create a new group, please first <a href="${h.url_for(controller='u + </span> + </p> </li> </py:match> diff --git a/ckan/templates/group/layout.html b/ckan/templates/group/layout.html index 64153aa..a3f732b 100644 --- a/ckan/templates/group/layout.html +++ b/ckan/templates/group/layout.html @@ -25,9 +25,12 @@ <li py:attrs="{'class':'current-tab'} if c.action=='index' else {}"> ${h.subnav_link(c, h.icon('group') + _('List Groups'), controller='grou </li> - <li py:attrs="{'class':'current-tab'} if c.action=='new' else {}"> + <li py:attrs="{'class':'current-tab'} if c.action=='new' else {}" class=" ${h.subnav_link(c, h.icon('group_add') + _('Add a Group'), controller=' </li> + <li py:attrs="{'class':'current-tab'} if c.action=='new' else {}" class=" + ${h.subnav_link(c, h.icon('group_add') + _('Log-in to add a Group'), co + </li> </ul> </py:match> }}} BUT this fix doesn't completely work. When you log-in and create a group, at this point the nav bar changes from the (correct) "Add a group" to (incorrect) "Log-in to add a group".
#1517 1323175957000000 zephod After some research, I've decided to disable the iframe datapreview of unknown filetypes. We need a safer mechanism for verifying that it's a text file or web page; a blacklist of filetypes which won't be iframed (GZIP, ZIP, etc) will never be adequate, and accidently starting a binary file download is a dangerous thing. The fix is simple - commit: 17f33031f5e348e623146601f830b8c67462fe00 But more work will be required to relax this restriction.
#1521 1323174618000000 thejimmyg It would be nice if the new UX also made it clearer that a user has to login, before they click the "Add a group" link which currently takes them to the login page with the message "Unauthorized to create a group".
#1004 1323174597000000 thejimmyg I don't understand. We just had a team meeting about this, all discussed it and agreed to close it. Yes, you get taken to the login page, but that is the correct behaviour. The problem in the past was that the link was in the yellow box and there was no explanation as to why you had to login. This time you click from the header bar and there is a clear message saying "Unauthorized to create a group" - exactly as a user would expect. Even if the exact text of the ticket description isn't fully implemented in the current release, the UX isn't broken anymore. Yes, it might be even nicer to have a message warning them in advanced but these improvements will be taken forward in the UX work - maybe there is an even better solution than a message? Since you are unhappy about closing it I'm marking it as "Duplicate" of #1521. As agreed earlier with the entire team, we'll take this forward as part of the groups refactor. See #1521 for more information.
#1242 1323173292000000 thejimmyg This text is no longer present on the login page.
#1189 1323173227000000 thejimmyg Closing this ticket in line with ticketing policy since it is over 6 months old. If someone would like to develop an extension that uses spideroak as a back end we can look at it again.
#1285 1323173125000000 thejimmyg I could write some middleware to handle this. Can we come up with a list of exceptions not to catch or should I create a base exception called "NoEmailReportTriggeredException()" which exceptions for this purpose have to be derived from or which code has to raise?
#1035 1323172908000000 thejimmyg Re-assigning to me temporarily to investigate now that Seb has left. It may be that this should be deleted given that it is over 6 month's old.
#1523 1323172904000000 icmurray Erroneously created when a file upload failed.
#948 1323172859000000 thejimmyg Re-assigning to me temporarily to investigate now that Seb has left.
#1004 1323172489000000 dread There is a description of groups, but that is not the subject of this ticket. In fact if you're not logged in you do get taken to the login page (which is quite correct). I agree with your earlier comment that the text of the link needs changing. Sorry to be reopening this, but I think the previous comment misses the point. Doing this ticket would be a valuable quick fix. Putting on backlog.
#1485 1323172388000000 icmurray Made a small start on this: https://github.com/okfn/ckan/tree/feature-1485-package-form-extension
#1462 1323172211000000 thejimmyg Let's work together to fix the packaging aspect too.
#1486 1323172027000000 seanh I've now merged my feature-1298-activities-table branch into my super branch for activity streams, so my fix for this defect is now merged into the activity streams super branch and will be merged when that branch is merged. See the activity streams super ticket: #1515 Resolving this ticket now
#191 1323171514000000 thejimmyg John will just check that the API version 3 does support modified after the new solr schema handled by Adria is in place.
#819 1323171435000000 thejimmyg This issue is fixed. Further improvements to the UX of the autocomplete will be dealt with in other tickets.
#1004 1323171375000000 thejimmyg The yellow box on the right is now back and you don't get taken to the login page. We'll write more detailed instructions once the group refactor is done.
#939 1323171158000000 thejimmyg This is now implemented, the notification links to the about page. We might want to update that page with better information, but that would be a different ticket.
#934 1323171047000000 thejimmyg We have other ways of solving this problem now rather than a key value store for plugins. Marking as invalid.
#1064 1323169787000000 thejimmyg Marking as duplicate because #1464 will take it on.
#1464 1323169763000000 thejimmyg As part of the queue upgrade we'll also fix #1064 which explains that the current queue implementation is over-engineered.
#1049 1323169424000000 thejimmyg This is over 6 months old. In accordance with wiki policy, closing.
#1435 1323168783000000 thejimmyg I personally can't see the benefit of switching to a generic paid service when we already have a highly customised and working infrastructure based on buildbot and buildkit - we do testing in VMs as well as continuous integration. What is the advantage? Suggest wont fix?
← 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 →
Note: See TracReports for help on using and creating reports.