{23} Trac comments (3729 matches)

Results (2001 - 2100 of 3729)

Ticket Posixtime Author Newvalue
#957 1314218701000000 rgrp I'm closing this as wontfix as we now have arbitrary metadata for resources so probably won't need a specific field. That said we probably will want a schema but that is not yet finalized and would be a separate and wider ticket. For current proposal of the attributes generally wanted for resources see http://wiki.ckan.net/Domain_Model/Resource (recently updated).
#1285 1314269414000000 dread Another instance is when the database tables are not created and you want to both display a sensible error and have an email alert. #1290
#1290 1314270894000000 dread Improved on option 2. For requests to Home controller, the first thing it does is check the user. I catch SQL errors that are to do with missing tables and that now produces a template-less error saying the site is off-line and then mentions database initialisation. Done in cset:484e50c4f989 on default for ckan 1.4.4.
#1176 1314273012000000 dread This occurs when you browse {{{/error/document}}} directly, rather than being directed there on error. In this case there is no 'original_response'. Fixed in cset:c67d5934fb0b for ckan 1.4.3 and merged to default.
#1074 1314278296000000 rgrp johnlawrenceaspden did quite a bit on this in feature-1074-refactor-authz-wui branch (including implementing for package and group). However, did not implement for authzgroup and also repeated code a lot. Reassigning to me for completion.
#1074 1314283492000000 rgrp Also work on branch feature-1074-authz-wui (that is primary one in fact)
#1154 1314287519000000 johnglover All attempts to index packages should now throw a SearchIndexError if Solr is unavailable and the create/update will be rolled back. These errors are caught in the main package controller (redirecting to an error page) and the API controller. I have added tests for both controllers. Also updated the paster 'search-index check' command to work with solr.
#1074 1314303581000000 rgrp Closed in cset:18a5b48bbee6. Note the templating isn't completely reused but rather uses common methods from _util.html. Likely that a bit more refactoring could be done to share common code but not worth it at present.
#1279 1314303732000000 rgrp Wow, that's a pretty big omission. authz groups are important and are used. I think we should discuss this in next planning meeting.
#1279 1314304326000000 rgrp In addition it appears that authz group was left out of the form refactoring so new and edit page use old formalchemy stuff. Should fix this.
#1282 1314404540000000 rgrp Done in cset:4b6838a820bb. Have not done either of the optional items. JS testing for what we have is relatively hard and of dubious value. Re CDN stuff requires work and of doubtful of immediate value since can just configure cache or main site to serve static stuff directly. (Likely more value from compressing js and css ...).
#878 1314404621000000 rgrp A working version of this in ckanjs as of 2 weeks ago. Need to integrate into main CKAN.
#978 1314404858000000 rgrp Suggest we either a) get rid of columnar layout or b) (preferable) get a dedicated page for resource. That way summary on package page just shows main attributes.
#979 1314404905000000 rgrp Change from Edit Resource extras in the API to Edit Resource extras in the WUI as believe we already have API editing and reference to #978 implies this is about the WUI.
#1252 1314406271000000 rgrp Move to v1.5 since this will coincide with release.
#1264 1314406294000000 rgrp Nothing urgent about this so moving to backlog.
#1251 1314406332000000 rgrp Really non-urgent and can be done once #1252 is done (which is dependent on v1.5)
#1293 1314701675000000 johnglover == Changes == * All templates * Routing: /package/ -> /dataset/ (including API) * Tests: h.url_for(controller='dataset') rather than package ... * One test to check redirect works? * Docs == Leave == * Stay with Package in code e.g. stay with 'PackageController' * also leave stuff like pkg = .... (gradual migration) * Leave extensions == Notes == * Package -> Dataset * Data Package -> Dataset * respect capitalization
#1277 1314868204000000 johnglover Done in branch feature-1275-solr-search for all package searches (which use Solr). Resource and Tag searches still use the old ckan query parser.
#78 1314877151000000 zephod Fixed in cset:8638a0ac2255 (fifty year expiry time on the four cookies)
#1108 1314878772000000 zephod First, here is a repo with the new DataHub theme: https://bitbucket.org/okfn/ckanext-datahub-theme We plan to integrate this into ckan-core, thereby replacing the current theme.
#1276 1314886010000000 johnglover Added to branch feature-1275-solr-search Don't seem to be able to apply weighting to fields at index time using solrpy (see open issue: http://code.google.com/p/solrpy/issues/detail?id=6). So, switched to using the newer Solr edismax query parser and have applied weights to fields at search time. Current weights are as follows: name: 4 title: 4 group: 2 tag: 2 text (everything else): 1
#1293 1314905799000000 johnglover Branch: feature-1293-rename-package-to-dataset Routing and test editing should be finished (all tests passings). Have not added test for redirect yet.
#1305 1314971164000000 nils.toedtmann Always use "localhost" as mail relay. On all servers, the local MTA should be configured correctly (e.g. in this case to relay via mail.fry-it.com), also to be able to send rootmail. I fixed it on IATI (s049.okserver.org = ex eu23) and thedatahub.org (s055.okserver.org). Please verify that it's working now.
#1303 1314978842000000 dread Adria fixed this in cset:7637d8694388 on default. I transplanted it to release-1.4.3 and have updated thedatahub.org.
#1108 1315140879000000 rgrp Completed in https://bitbucket.org/okfn/ckan/changeset/9be1ae232ec3 cset:9be1ae232ec3
#1284 1315212258000000 dread Fixed by rgrp in cset:1952445d2802 on release-v1.4.3 and default. Comment: do not create revision for changes to users as they are not revisioned. * This had already been removed in cset:8d6fde0e2196 (then in user controller) but Adria seems to have reinstated this when refactoring things into the logic layer. This 'bug' explains the huge number of empty revisions we have been seeing on ckan.net.
#1284 1315212603000000 dread I've added tests for this (to prevent yet another regression!) in cset:1b77ce8ce560. Closing.
#1284 1315214358000000 rgrp I'm not sure this is the sort of thing we need tests for (we can have too many tests!). Something worse discussing ...
#1293 1315214527000000 rgrp Reassign for completion (templates and docs) as john is away.
#1284 1315215626000000 dread Really? How many times do you want to fix this bug again? For the sake of three lines of test...
#979 1315221162000000 dread Changed the title back - it was accurate. The comment was because with formalchemy, WUI and API ran off the same 'form' code. This functionality may already be there with the new stuff, but certainly needs tests.
#979 1315222244000000 rgrp Is this already done? Is it under test?
#1293 1315246628000000 zephod cset:https://bitbucket.org/okfn/ckan/changeset/4a98589af6c1 Fixed
#1307 1315246706000000 zephod cset:2c31fe24e1c9
#1307 1315247298000000 zephod Replying to [comment:2 zephod]: Oops: cset:cbd6677ec41e
#1277 1315297186000000 rgrp This just requires merging into main but has been deferred as once solr branch is merged solr is *required* to run CKAN at all (we are thinking of having basic support for sqlite/dbs out of the box ...)
#1305 1315317033000000 nils.toedtmann [15:22:02] Adrià Mercader: Yes it looks like it works on both thedatahub.org and iatiregistry.org
#1082 1315317825000000 dread The flash message 'Language set to: English' was always in the previous language, not the new one. Pudo fixed this in cset:eaf342823caf and I have transplanted this into release-1.4.3. I've also added/corrected translations for all languages for 'Language set to: English' so that it makes sense! "Set language back to English causes server error:" I can't reproduce this. The exception looks like a problem with the forwarding, which improvements were made in #1126.
#1312 1315327743000000 dread The default Content-Type is "application/x-www-form-urlencoded" (that is what curl sends, and what CKAN defaults to). Therefore these characters need url encoding ("=&;" -> "%3D%26%3B"). Here is an example of it working: {{{ (pyenv-ckan)[email protected]:~/hgroot/ckan$ curl -i http://localhost:5000/api/rest/package -d '{"name": "test7", "title": "Test2 %3D%26%3B"}' -H "Authorization:tester" HTTP/1.0 201 Created Server: PasteWSGIServer/0.5 Python/2.6.5 Date: Tue, 06 Sep 2011 16:36:32 GMT Pragma: no-cache Cache-Control: no-cache Location: http://localhost:5000/api/rest/package/5866a0f5-905a-44ff-91c3-c1489374a73e Content-Type: application/json;charset=utf-8 Content-Length: 571 {"maintainer": null, "maintainer_email": null, "id": "5866a0f5-905a-44ff-91c3-c1489374a73e", "metadata_created": "2011-09-06T14:06:40.735488", "relationships": [], "metadata_modified": "2011-09-06T16:36:32.543461", "author": null, "author_email": null, "state": "active", "version": null, "license_id": null, "resources": [], "tags": [], "groups": [], "name": "test7", "license": null, "notes_rendered": "", "url": null, "notes": null, "title": "Test2 =&;", "ratings_average": null, "extras": {}, "ratings_count": 0, "revision_id": "92ee0b2e-c5e4-47b9-b00c-b8e29662b950"} }}} Alternatively you can set the content type to "application/json" and you don't need to URL encode. e.g.: {{{ curl -i http://localhost:5000/api/rest/package -d '{"name": "test5", "title": "Test &"}' -H "Authorization:tester" -H "Content-Type: application/json;charset=utf-8" }}} To help work out these problems with encoding in the future, I've improved the error message to show the decoded JSON string. cset:55273629a552 which is headed for CKAN 1.5 release.
#1050 1315394117000000 dread There's been no objections to my comment 6 months ago saying this is invalid, so marking it invalid. Feel free to reopen if there is indeed a case here.
#1296 1315403275000000 zephod No longer doing inline resource editing on dataset/view; instead use the edit form.
#1297 1315403878000000 zephod No longer doing inline editing on the view page.
#1297 1315403974000000 zephod Largely done in cset:8901e722b158
#1297 1315404322000000 zephod all done: cset:71096cd7b27d
#1315 1315414218000000 dread Pretty good start added in cset:7a0e7a486df3 on default, aiming for release 1.5. Just needs some loose ends tidying up.
#1317 1315416649000000 dread Ok, I think this example may be when searching for "ira". "irina" works me, but "ira" gives: {{{"ira" matched several users}}}
#1319 1315476057000000 shevski Ideally we should also verify people's email addresses. Do we think that's overkill?
#1318 1315569362000000 dread Problem tracked down to Adria's cset:4f1ca1eb2630 on branch feature-1229-db-out-of-controllers that missed out repoze.who in the redirects after login, when refactoring the user registration. This code went into default on 2011-07-28 for release 1.4.3. Fixed in cset:93731cd3b22e for release 1.4.3 and doesn't affect previous releases. Tests for user registration added too.
#1309 1315586335000000 dread Duplicate of #1318
#1325 1315587113000000 dread Fixed in cset:0dd4d4457c97 for release 1.4.3. Previous Python 2.5 incompatible versions include 1.4.2 - and maybe further.
#1323 1315594333000000 dread thedatahub has a couple of auth groups with no name. The form allows it! Fixed in cset:bebd0a46ebc6 * form requires the name field * existing auth groups without name can be viewed/edited if necessary (referring by ID) This has probably been a problem since auth groups were added to CKAN.
#1310 1315820419000000 dread This was fixed cset:e49781cb74fd for 1.4.3.
#1295 1315820564000000 rgrp This is mostly done but some final tweaks and name disabling to be done. See work in feature-1294-ux-improvements-dataset
#878 1315820838000000 rgrp This is now done in feature-1294-ux-improvements-dataset. see e.g. cset:c6f7f5018b4f
#787 1315821118000000 thejimmyg The joint authentication was implemented a long time ago and is deployed on catalogue.data.gov.uk. We'll build the authorisation layer in ticket #1326 so marking this as fixed.
#1296 1315821293000000 rgrp Have now done resource add pretty effectively and most of edit done (should complete today).
#852 1315821628000000 rgrp Moved dataset archiving into new ticket #1327 and this is therefore now done.
#1202 1315821804000000 rgrp This now irrelevant and relevant content has gone from thedatahub theme.
#1317 1315822670000000 rgrp This is very minor IMO. I would defer this as part of a more general user system ux refactor.
#1319 1315904592000000 dread No responses received about this on ckan-discuss, so I'm taking that as no objections to requiring email address on registration. I think that verifying email address is not worth it in this case, because the value of supplying an email address is only for resetting a password. The chance of needing a password reset AND having inputted an incorrect email address is very low, so I don't think it justifies everyone having to do this extra step. If we used email address more then that may change.
#1300 1315906283000000 rgrp page_heading and optional_footer done in #1108
#1300 1315908961000000 rgrp Move of js to optional_footer done in cset:dcb21f0d976f. As part of #1294 have done a lot of css adding. Not sure how much more to do here.
#1335 1315910117000000 dread Done to a basic extent in branch feature-1211-drupal for release 1.4.3. Further tickets: * #1322: Action API improvements * #1315: Document /api/action
#1211 1315910650000000 dread I've listed what was checked into this branch 6 weeks ago and is going into release 1.4.3. Is this ticket ready to close now or are there future plans?
#918 1315911507000000 dread Preview feature is now deprecated
#1082 1315917217000000 dread Language switch problem has been around since it was introduced in the 1.3.1 release.
#1295 1315948009000000 rgrp Completed with merge into default in cset:8bb0720a2150
#1296 1315948027000000 rgrp Completed with merge into default in cset:8bb0720a2150
#1294 1315948112000000 rgrp Removing #1311 as that is not directly related to dataset edit / create.
#1294 1315948257000000 rgrp Done with merge into default in cset:8bb0720a2150 and deployment to http://thedatahub.org/
#1324 1315948336000000 rgrp Done and merged into main at cset:8bb0720a2150 (and deployed!)
#1276 1315948394000000 rgrp Closing since done (though not yet in main!)
#1277 1315948417000000 rgrp Closing since done (though still need to merge into default)
#1291 1315948475000000 rgrp @kindly: is this not done? (I know there is more work to be done here but though table creation was done ...). If not need to move to next milestone so we can close this one.
#1232 1315948536000000 rgrp Removing from ckan-v1.5 as do not think any of this is top priority (correct me if I'm wrong!)
#1233 1315948668000000 rgrp Removing from v1.5 as not a priority atm.
#1211 1315948703000000 rgrp Let's close and re-open (or open a new ticket) for future work.
#954 1315948855000000 rgrp @kindly: can you update here. My impression is that lots was done but the current ticket description bears little relation to what was done. Suggest we move current content to a new ticket and update this with a short description of what *was* done and then close -- does this sound sensible?
#1231 1315948921000000 rgrp @kindly: Does this fit in with current plans? If not suggest we close as invalid/wontfix or put into the backlog (though given lack of content not sure that is very useful ...)
#1340 1315991534000000 dread Fixed in default in cset:33856d3ce84e aimed at release 1.5
#1341 1315996368000000 kindly This was run to delete the users and their mistaken revisions that where created. {{{ BEGIN; delete from revision r where r.id in ( select r.id from "user" join revision r on r.author = "user".name left join resource_revision rr on rr.revision_id = r.id left join package_revision pr on pr.revision_id = r.id left join group_revision gr on gr.revision_id = r.id where "user".created between '2011-08-15' and '2011-09-06' and gr.id is null and rr.id is null and pr.id is null and ("user".name similar to '%[0-9]' or "user".fullname similar to '[A-Z][a-z]*[A-Z]%') and "user".name not like 'http%' ); delete from "user" u where u.id in ( select "user".id from "user" left join revision r on r.author = "user".name where r.id is null and "user".created between '2011-08-15' and '2011-09-06' and ("user".name similar to '%[0-9]' or "user".fullname similar to '[A-Z][a-z]*[A-Z]%') and "user".name not like 'http%' ); COMMIT; }}}
#1332 1315999104000000 dread Fixed in cset:860b357a2aec for release 1.4.3 and updated no.ckan.net. This problem was due to {{{[1:authorization group]}}} being translated as {{{[autoriseringsgruppe]}}} and I corrected it to {{{[1:autoriseringsgruppe]}}}. This word has a bold tag, hence the brackets and the number is used to identify which bracketed word is which (when you have more than one). It is a shame that Transifex doesn't draw attention to this problem and Babel doesn't spot the error on compilation.
#1292 1315999202000000 dread <rgrp> i'm def +1 for removing API stuff entirely from i18n for the present
#1339 1316010607000000 kindly I have fixed the isodata and made a slightly modified int_converter for this case. In the correct place and raises invalids on not being an int. cset:a4af115116bb The thinking was that the input of these fields would be through the api so the empty string case did not arise. These should clearly be converted to None (Null). What issues in general? Having done this lots of times before you always end up needing to write your own little validators as the standard ones never do what you want. Thats the point of them. Look in ckan/lib/validators if you need examples. So what you did was correct...
#1240 1316022145000000 rgrp add autocomplete
#1343 1316078440000000 dread I don't think email confirmation is necessary - see discussion at #1319
#1344 1316078757000000 kindly fixed cset:f08215845dab
#1346 1316086314000000 dread Fixed in cset:df299e69d456 on default for release 1.5. Problem exists on releases 1.4.3 - 1.3.1 and probably earlier too.
#1334 1316086680000000 dread cset:b01de680bf86 copes with the problem. Now to find out why revision.packages has some None values - very odd!
#1347 1316094608000000 dread Fixed on cset:7c3cc0fd6ae4 on branch release-v1.4.3.1.
#1346 1316094632000000 dread Also Transposed to
#1349 1316277490000000 zephod Done. cset:e074aee19923
#1351 1316540182000000 zephod Fixed in cset:4eebcb118b09
#1329 1316624026000000 zephod I've tried to do this wherever I could as I looked through ckan.pot for broken pieces of string. Generally it triggers errors unless things are very neatly structured (no nested links or ${a.variable} accesses, it seems) but things are quite a lot tidier. cset:d5bf4c7ba293 Does that count as 'fixed', or is this a permenant issue?
#1350 1316624288000000 zephod Was going to reimplement an old workaround described by Friedrich, where a language.js file is served through the home controller (with appropriate settings in routing.py) and so ${_('string literals')} will be translated. See: * https://bitbucket.org/okfn/ckan/src/2832e49d6baa/ckan/controllers/home.py#cl-48 * https://bitbucket.org/okfn/ckan/src/2832e49d6baa/ckan/templates/home/language.js However the string-extraction mechanism seems geared towards Genshi templates and hacks are required to make it read a javascript file neatly (ie. without putting the *entire file* into a string for translation). A more elegant solution seems to be using an xi:include to pull in a genshi template which contains an html <script> tag. * cset:d5bf4c7ba293 Issue is resolved; strings are now translated.
#1252 1316876747000000 rgrp Announced. thedatahub.org now running for 2+ months. Today did wiki.ckan.net redirect and hope to do thedatahub.org redirect.
#1338 1316951545000000 amercader Reopening, because another change is needed to support custom schemas
#1138 1316965357000000 rgrp Cannot see this issue any more on default (as deployed on e.g. test).
#1354 1316970374000000 amercader There is no way to maintain backwards compatibility, so let's forget about it for now
Note: See TracReports for help on using and creating reports.