{23} Trac comments (3729 matches)

Results (3501 - 3600 of 3729)

Ticket Posixtime Author Newvalue
#2765 1343735917000000 toby @aron, I've added a data summary The data errors for empty fields are not happening due to our use of repoze.who for logins which is crap and doesn't provide feedback re loggin details so not possible without hacking repoze which i'm not doing. Could you look at cleaning up the error summary we don't supply a field name (key) as not relevant it would be nice if we could hide the : also removing the invalid fields message would be good to hide maybe add this as an option to the macro
#2779 1343737270000000 shevski Related ticket for undeleting datasets - http://trac.ckan.org/ticket/2780
#2641 1343737625000000 shevski Design here: https://okfn.basecamphq.com/projects/9558659-demo-ckan-front-end/posts/65443876/comments
#2458 1343737692000000 shevski Do we need a design for this? Or can we just use the same format as datahub.io/stats but within the new template?
#2641 1343738074000000 amercader It looks awesome, really nice! Note that the "Enter location" box logic (geocoding) is not yet implemented, so first stage of the widget should not show it.
#2782 1343805253000000 toby @ira, I'm just closing this a) Because the ticket doesn't really mean anything what is `properly` also a link to some random website does not help. The ticket should tell me exactly what is wanted not be some sort of treasure hunt. b) This is major feature creep - we have agreed the tickets for phase 3 small things/bug fixes are fine but this possibly a massive thing. For weird stuff like this maybe you should save them up for when we have a meet up. You need to get buy-in from developers I need to have some sort of pride in what I do. c) I don't think this is a good idea from a technical perspective - maybe if you create a meaningful ticket it may make more sense. d) Also I'm not doing anything involving maps till we have proper attribution of the map we are using on the demo site because I have morals, I thought okfn did too but I'm not sure any more. Sorry to have to do this but it is for my sanity. As I have repeatedly said the tickets are really important as they are the basis of all the work that I do. They need to be of a reasonable standard.
#2782 1343810353000000 shevski @toby I added this post discussion about attribution. Sam says that if we actually use the app itself (currently we're using the maps from it - but primarily by taking screenshots instead of actually integrating) then the attribution would automatically show. In terms of ticket creating, I added this so people could see it and have a think about whether it's phase 3 or phase 4 (& move where necc) & whether you wanted more detail from me etc or whether it needed to be a more generic kind of ticket (i.e. 'need some low cost / low maintenance way to create backgrounds for demos'). In future, shall I email instead? Call on skype? IRC? before any tickets are created?
#2782 1343811113000000 toby @ira, I'm happy to discuss things on irc/email if you are unsure about things. If There are tickets that you are not sure about when they are wanted, then add them to phase 4 as they can then be ignored for now - anything added to phase 3 is a "this needs doing now" thing and as we have agreed exactly what we are doing in this phase (last week) then adding new features will likely get a negative reaction. So if not sure add it to phase 4 - aron and I may do some phase 4 tickets if we feel they will be quick and easy. As I've said small things like the breadcrumb is wrong on page xxx or bugfix tickets are fine as broken stuff needs fixing. Sometimes it may not be clear how much work something will be or who the person who needs to fix it is - so just ask first. The main problem with this ticket is that it is unclear what the ticket is about. cheers
#2783 1343814401000000 rgrp My 2c: this is very low priority atm (it will also be hard to do). What I'd vote for is some decent default patterned background or similar (what we have originally wasn't *that* bad ...)
#2331 1343814758000000 rgrp I'm re-opening this. This is a reasonably significant UX problem -- not just a philosophical difference. It is just *weird* to get *more* results as I add search terms rather than less. Please can we have this fixed ...
#2783 1343817744000000 toby closing after discussion with kindly
#2765 1343817858000000 aron.carroll Cool, closed as of 99b8c4f. I fixed the error summary display and highlighted the fields in red to show they were incorrect.
#2739 1343817919000000 aron.carroll Added in 038f4f2
#2779 1343818300000000 aron.carroll Toby is there a flag on the dataset object that tells me if it has been deleted?
#2458 1343818531000000 aron.carroll This will be up on s031 by the end of the day for feedback
#2783 1343818702000000 toby Milestone ckanhosted deleted
#2779 1343818990000000 toby @aron, pkg_dict.state I think the options are active - all good draft/draft-complete - partially created dataset deleted - deleted
#2302 1343820855000000 ross Just a quick note, if Rufus asks about editing about page, he's talking about this ticket.
#2776 1343824375000000 aron.carroll Done in f24fcd9. This will require the demo site to be updated. This line needs to be added to the config.ini to get the CKAN logo back. {{{ ckan.site_logo = /base/images/ckan-logo.png }}} For other local sites remove the logo and the site title and description will be used. Currently the design doesn't handle a long description so beware.
#2778 1343841130000000 aron.carroll Tidied up in a55523175a95f2fc5c0ddddf9fa9579aa7111e39
#2331 1343862230000000 kindly As I said I do not not agree with it being a UX problem or *wierd*. *wierd* is not acceptable in response to a thought out comment. So I am closing it again.
#2793 1343897811000000 toby fixed but commit tagged as 2650 in error
#2781 1343901395000000 toby @aron, This is possible via /ckan-admin/config but renders badly with the demo theme disabled due to hiding behind that black rectangle - maybe we can do something?
#2792 1343901501000000 aron.carroll Fixed in 1a83a77
#2794 1343903064000000 aron.carroll Done in 11f3b6297c
#2779 1343903455000000 aron.carroll Done in d17358f
#2791 1343906884000000 aron.carroll I've added no-wrap as of 1db2037. Not sure what we should do about short titles/long tag lines though.
#2781 1343907075000000 aron.carroll What do you mean by "hiding behind that black rectangle"? Just tried it locally with the text "Welcome to the CKAN demo Try out standard CKAN functionality in a sandbox environment. Search for datasets directly from the homepage or by navigating to the Datasets search page where you can facet by tags, groups and format." and it renders okay…
#2669 1343907572000000 aron.carroll It's a nice blue tag now.
#2700 1343914288000000 aron.carroll Added the flags in 06257ac. Ira can you sanity check that the flags are all correct. I need to get a proper German one from Sam as he used a European flag in the mockup.
#2698 1343914688000000 aron.carroll We need an api endpoint that can render a markdown string on submission. * Client posts a string of text to the endpoint. * Server responds with a 200, text/html response containing the rendered markdown. * Server returns a 400 and empty body if the content is not valid markdown. * Server returns a 500 and empty body if something else crashes. Alternatively for better error handling we could use a JSON transport. * Client posts a blob of json containing a "content" key with the markdown string. * Server returns a 200 (application/json) and blob of json with a "content" key with the rendered markdown. * Server returns a 400 (application/json) and blob of json with a "error" key containing a useful message for the user. * Server returns a 500 (application/json) and blob of json with a "error" key containing a useful message for the user.
#2704 1343914890000000 aron.carroll This relates to #2705. We need to decide what happens when the user clicks on one of the sidebar links. At the moment they'll get a warning if they've edited the form telling them they'll lose thier changes. Perhaps we should submit the form using ajax, showing a spinner to the user, then send them on to the next resource. This is the same situation as if we add an "add new resource" button to the listing.
#2701 1343920287000000 aron.carroll I've updated the disqus extension (in development branch) and added the snippet to the development branch of the demo plugin. Toby, not sure about the way the disqus plugin is implemented via a helper vs the spacial plugin using a snippet. Would be good to decide on the "one" way to do this.
#2701 1343920314000000 aron.carroll BTW moved this to phase three as I consider it done.
#2644 1343925546000000 aron.carroll Updated the theme in 2b81958, seems very similar in functionality to the profile page...
#2781 1343947526000000 toby @aron please try with ckan.plugins = stats in your .ini ie without the demo theme being used
#2704 1343948227000000 toby @aron, I don't like auto submit as people may think (reasonably) that their changes are discarded. We could catch all clicks and then ask the user if they've changed something but this feels a little crazy - better than the browser dialog. hmmm maybe we should discuss this ticket with the other backlog of undecided/unsure personally I think we need to review the whole edit/view/delete logic as it feels real poor from my perspective - I need to edit something to delete it - that is a wtf imho let's work out what we are doing before wasting energy on this
#2701 1343949850000000 toby > Would be good to decide on the "one" way to do this. As the new extension guru/deity I say helper functions are the future - my word is the law a) a missing helper just returns '' so they can be added to templates even when not implemented, a missing template gives a 500 b) helper functions hide the implementation which I think is a good thing c) helpers are just soooooooo cool - plus they are new and shiny (what am I saying?) As far as moving the phase I'm not too fussed we can be ahead on phase 4
#2701 1343949913000000 toby track is shit - missing helpers return `''`
#2774 1343993956000000 toby @aron I've created some js translations note that they are untranslated except for zh_TW which is mangled. At the moment they are just a json blob in public/base/i18n/<locale>.js What more do you need? It seems to me that you just need either `some_var = {json}` or `some_function({json})` let me know your preference or do we want this purely as an ajax call? If it's ajax I think we want a common approach like in http://trac.ckan.org/ticket/2698 which I prefer to a unhelpful response
#2774 1344008312000000 aron.carroll I'm happy to just make ajax requests to public/base/i18n/<locale>.js, however this will use the language set in the <html lang> attribute. So if this file doesn't exist then we'll get a 404 and show the english. If we want something more sophisticated, determine an appropriate fallback etc, then I think the API is the way to go. Or we could get CKAN to determine the appropriate language file and include it in the page source...
#2774 1344009350000000 toby for now shall we just include it in the page? let me know how you want it included eg var = {}, fn({}), $(fn({})) etc
#2751 1344015002000000 toby This is now possible via the `paster trans mangler` the initial verdict is that our translation coverage is extremely poor and we need a full template review - maybe there is a jinja2 i18n solution but I think not without `{% trans %}` Moving to phase 4 - also I'm just holding this ticket and will be allocating to aron's successor Publishers vs Groups is more complex than I think is appreciated, is it really worth the time and effort just to make everyone using ckan confused? Anyhow that discussion is not part of this ticket as it is not in-scope
#2322 1344086640000000 rgrp Can I confirm this is in v1.8 ...
#2751 1344240974000000 aron.carroll I tried {{{paster trans mangler -c datahub.ini}} I also had to {{{ pip install polib }}} and run {{{ python setup.py egg_inf }}} I find it hard to believe out coverage is that poor, I've just been through a random selection of templates and they all have appropriate calls to {{{_()}} or {{{ {% trans %} }}}. Will look once I get this running.
#2751 1344243046000000 toby @aron, The pip install polib is needed this is a deployment requirement so not in the pip-requirements.txt Not sure where it should live we use it elsewhere so may already be in there somewhere not sure why you needed the egg_inf
#2785 1344243731000000 shevski I think it's a nice to have, esp if we give it an intuitive UI Rufus is keen for this also
#2642 1344243797000000 shevski Would like to have this for next week for a demo if possible
#2700 1344244373000000 shevski Language names should all start with a cap letter, seems random currently. Slovenia flag (last one) missing a shield Is the Suomi just Finnish? May be a darker blue. I would find some pointers useful: e.g. "Shqipe (Albanian)"
#2700 1344245069000000 toby @ira, languages are in their own language Capitalisation is English Imperialism so I think we shouldn't do this
#2797 1344250973000000 aron.carroll Just a classname issue. Fixed in f927598 and documented
#2805 1344254760000000 toby Arg I think this is my fault
#2458 1344254847000000 shevski This looks great. 4 small things: 1. clicking on a tag in 'top tags' takes you to old unstyled page, e.g. http://s031.okserver.org:2375/en/tag/economics. Should take you to search faceted by that tag. 2. I'd love to be able to link directly to e.g. the 'top tags' view - any way to do this? 3. Is there any way to rate datasets at the moment? If not, can we hide that option for now? 4. On 'Revisions to Datasets per week' can we rename this 'Dataset revisions per week' and can we change the orange icon/index in the table to 'all dataset revisions' instead of referencing 'packages'
#2700 1344254979000000 shevski As long as languages are actually in their own standard of capitalisation, i don't mind. currently looks random
#2644 1344255836000000 shevski I think this requires some thought & probably a discussion. For example need to be clear on the purpose of a user dashboard vs say a publisher dashboard. I image a publisher dashboard would have the stats to datasets belonging to that group (e.g. views, downloads, comments, shares, ratings), issues reported (when we get that extension working), call to action to add a new dataset (that adds it to the group). User dashboards I'm less clear about. May be we can talk about this on Tues/Wed? Or skype today
#2702 1344255984000000 shevski this is just a placeholder reminding me that need to create these tickets. Will pick out the main things and close this eventually
#2785 1344256089000000 shevski I would say leave as phase 4 for now
#2803 1344256274000000 aron.carroll Done in 3b2427e
#2700 1344256383000000 aron.carroll Okay could you give me any pointers you want to add. Plus ask Sam to create a flags for the missing countries. Cheers.
#2802 1344258233000000 toby @aron I've done most of this to test get strings {{{ python setup.py extract_messages }}} mangle the zh_TW creates .po/.mo files - I may need to fix plurals {{{ paster trans mangle -c .ini }}} create .js files only zh_TW will be correct due to other .po/.mo files being 1.7 ones {{{ paster trans js -c .ini }}} /api/i18n/zh_TW should be correct please note we do not have en.js I'm returning {} I think this is the correct response (maybe something else as we should just use the default _('...') strings - maybe we need to do something else for what it's worth pojson does not provide the format you wanted so I adapted it reassign if you need fixes
#2700 1344258748000000 toby @aron, re flags it'd be nice to have more as the languages are not so fixed maybe that's too much work for this phase and is more wishlist @shevski, The language capitalisations should be correct they are from babel not us anyhow
#2458 1344262256000000 aron.carroll Made changes as of 9729f1c 1. Clicking a tag now takes you to the search page 2. When clicking the tabs the location now updates so you can bookmark pages. 3. Not sure how datasets are rated. 4. Text changes made.
#2802 1344269446000000 aron.carroll Cool, this is in as of 8b72d1f8e9ba
#2804 1344269865000000 aron.carroll Done in 38f824b
#2807 1344270190000000 aron.carroll Fixed in 9a6d0be
#2545 1344337973000000 ross Up at http://datagm.ckanhosted.com
#2554 1344338036000000 ross Reducing the priority of this at present, may become more relevant after the LOD3 plenary
#2809 1344347814000000 aron.carroll Fixed in 84a4123
#2722 1344358667000000 toby @aron, can you re-add the dropdown and sort the overlap issue not sure which template it's in
#2700 1344358941000000 toby @aron you should have the flags close if complete
#2812 1344445200000000 toby @ira, do you want this change?
#2813 1344445419000000 toby http://demo.ckan.org/dataset/afterfibre group box wants a title link is not clickable maybe reorder stuff
#2748 1344503744000000 aron.carroll Moving this to phase 4 until we decide what to do about the edit/save workflow
#2707 1344504846000000 toby Formmating done other requests moved to new tickets as low priority for effort needed Title fixes translations etc http://trac.ckan.org/ticket/2822 Ordering of fields http://trac.ckan.org/ticket/2823
#2755 1344505304000000 toby this is dependent on #2790 (pending) and #2356 (waiting merge) other fixes have been done therefore closing this even if the effects won't be seen till those fixes are merged
#2700 1344505614000000 aron.carroll Cool, done in bf23242
#2699 1344507133000000 toby @ira, This is probably void now due to yesterdays dev meeting but will keep alive - moving out of phase 3 as not happening anytime soon and dependent on ross's organisation work will probably move to ckan 2.0 milestone
#2812 1344507240000000 shevski Current text does need updating, but I think we need an explanation along the lines of: "Groups allow you to group together datasets under a organisation (for example, the Department of Health) or topic (e.g. Transport, Health) so make it easier for users to browse datasets by theme. Groups also enable you to assign roles and authorisation to members of the group - i.e. individuals can be given the right to publish datasets from a particular organisation." But even that could be clearer. Mark's text could be misleading since we haven't currently implemented private datasets or the right auth settings.
#2828 1344507533000000 toby @ira this is the correct behaviour as this is a partially added dataset - rewritten ticket as it has a nice number :)
#2812 1344509156000000 toby changed
#2680 1344509493000000 toby closing this ticket as remaining work too vague undelete group added as #2830
#2722 1344510010000000 aron.carroll Done in 8769233. I think the overlap issue was fixed for the dataset search a while ago. Let me know if it remains.
#2781 1344510922000000 aron.carroll Fixed as of 7c86e31
#2812 1344521102000000 markw That's still fairly terrible. Also surely the auth stuff is part of Ross's Organizations stuff? It doesn't matter much if it's implemented yet, that's why this is a demo. But anyway, here is a more generic but readable version based on Ira's text above: Groups allow you to group users and data together so that they are easier to manage. Group owners can assign roles and authorisations, giving each project or department control of its own data publishing. Users can browse or search by group, making it easier to find the data they are looking for.
#2812 1344523785000000 toby @markw I think you are talking about a different ticket closing
#2812 1344524290000000 toby @markw, Actually I see you also want some text changes please don't add unrelated discussions to tickets as it causes noise is disruptive and I just end up closing tickets as won't fix etc. I have updated the text as it was assigned to me and so i am still keeping this closed as I did as requested. Can you an ira sort this out between yourselves and create a new ticket when you have agreement Thanks
#2801 1344526607000000 shevski @Aron / Ross is it worth having a separate page for related items? E.g. like on pd.eu http://publicdata.eu/app/irail
#2801 1344526719000000 aron.carroll Not sure it is. I'm just implementing a toggle on description so it works the same way as on the datahub.
#2824 1344527130000000 shevski @aron any ideas?
#2826 1344527309000000 shevski @Toby do you know what's happened? Don't think this was the case before. Should pre-fill with standard image when there's no group image URL
#2826 1344528004000000 toby fixed, issue was url_for_static @ira, good to test the site in english ie url like /en/dataset change language to something then english it will help catch these issues
#2801 1344531016000000 aron.carroll Now able to display the full text of related items as of e83df46
#2824 1344532640000000 aron.carroll All fixed
#2832 1344542984000000 toby duplicate of #2718 closing
#2787 1344543473000000 toby Closing as too general and part of any plugin update
#2461 1344543838000000 toby stop the error
#2817 1344544901000000 toby works in dev branch - may not be on s031 yet also please include urls in bug reports if possible - thanks
#2818 1344545331000000 toby check schema
#2819 1344545479000000 toby works in dev branch for /apps http://localhost:5000/dataset/1-kmwaterfractionfromnationaltopographicdatabasemapscanada/related
#2827 1344549139000000 toby Fixed and pushed to s031
Note: See TracReports for help on using and creating reports.