{23} Trac comments (3729 matches)

Results (3401 - 3500 of 3729)

← 25 26 27 28 29 30 31 32 33 34 35 36 37 38 →
Ticket Posixtime Author Newvalue
#2442 1338383819000000 toby new helper function for popular h.popular(type_, number, min=1, title=None) just related items left now
#2442 1338477973000000 toby @aron, related items on dataset page has been added it's really basic and just displays the fields that seem useful. we may need to add the add related item feature first as they are hard to add. please make it beautiful
#2445 1338378161000000 toby @Ross you will need to do this based off the feature-2375-demo-theme branch - you can use that branch or one split from it. new templates want to be in templates/... the old templates live in templates_legacy if you need to copy them across that's fine talk to aron or I if you need to know anything
#2445 1338472624000000 toby @ross the validation error seems correct to use 200 for the created the 303 seems ok but i'd just use pylons redirect myself Also did aron say we want this as a javascript free add item form
#2445 1338474490000000 toby @aron I'm fine with the redirect thinking it's just the specific 303 rather than just whatever pylons does. @ross, templates_legacy are there for ckan users who have their own templates as we are completely rewriting all the existing templates there is a lovely .ini setting to switch between the new and legacy modes
#2445 1338975600000000 toby @aron, this is as good a place as anywhere to answer your question about the c.form thing. a) some of this we are sort of stuck with. datasets for example can be of different types and have different forms for different datasets. so they need to be rendered separately. I have no idea why or how much this is used but it exists as an option to complicate everything, not much we can do about it. b) I think trying to do pages as a single rendering is not going to be easy because of the way ckan has been created maybe we can change this over time. One major issue for me is that ckan does lots of crazy stuff for some reasons but these reasons are not apparent from the code. Maybe there is some documentation somewhere but I'm not convinced. anyhow we should maybe close this ticket now. You've added some stuff in the comment for me to do maybe that should be added as a new ticket?
#2445 1338982754000000 toby closing as todos moved to other tickets and also completed
#2447 1343377924000000 toby @aron, can we close this as being too general - and have specific tickets?
#2451 1343378027000000 toby @aron, can we close this as being too general - and have specific tickets?
#2452 1343377943000000 toby @aron, can we close this as being too general - and have specific tickets?
#2453 1343377952000000 toby @aron, can we close this as being too general - and have specific tickets?
#2454 1338994536000000 toby I am against providing much more that you did something bad things like invalid username leak info - people should not know if usernames exist. Maybe I'm a bit mean about this. I'd be happier to add some javascript check on the form post that checks for no password etc - maybe that's not so practical
#2454 1339431487000000 toby @aron, I'd like to close this as a won't fix - your thoughts
#2454 1339495000000000 toby @aron, I'm going to leave this open for the moment but not make the requested change as I need to think of the best way forward. The flash message error is quite hard coded into the logic and I need to think of a nice solution.
#2454 1340710442000000 toby needs discussion and low importance
#2461 1344543838000000 toby stop the error
#2484 1340013145000000 toby merge requested https://github.com/okfn/ckan/pull/17
#2484 1340285964000000 toby merged into master
#2491 1338979614000000 toby fixed by commit e6554e7
#2493 1342774354000000 toby @aron, I've removed the breadcrumb and got it to eat flash messages as these tend to be repeated at least for some actions - maybe the flash messages is overkill. Anyhow I think it's good enough for phase 3 and we should either say it is done or move to phase 3 I think this would benefit from some design from Sam at some point and I quite like a graphic on an error page to make it a little pretty but not any rush
#2494 1338994890000000 toby this was due to out of date version of demo branch - updated
#2496 1339418832000000 toby fixed in demo branch
#2497 1339085489000000 toby yes is ckan 1.7 issue
#2498 1339660986000000 toby fixed in the demo branch
#2502 1339407123000000 toby {% snippet 'template_name', var=value, var2=value ... %} {% url_for(controller='foo', action='bar', ...) %} let me know if you want these changed eg remove need for () in url_for merged into demo branch they are just available in jinja templates no need to do anything special Let me know any problems or if you need some others added
#2502 1339494853000000 toby url_for no longer needs () link_for added but not tested - pretty certain it will just work
#2503 1339495333000000 toby @aron, To clarify this a bit. We want this so that a extension can create a new template say dataset/read.html but rather than rewriting the `core` template in ckan it can extend it in the same way as {% extends %}. The main difference is that {% ckan_extends 'template.html' %} would `walk` the ckan template tree rather than the extensions template tree. Is that what we are thinking?
#2503 1339580675000000 toby implemented in commit 14067ff
#2510 1339516414000000 toby ok I've done this and also unified the tags they are now tag/class {{{ <ul 'tag-list'> <li> <a 'tag'> }}} on home page tag was on <li> not <a> slightly changes the spacing please review
#2512 1339576809000000 toby This seems to be working now
#2523 1340368036000000 toby there and working
#2527 1339683264000000 toby Do we have a specific usecase for this?
#2528 1340380415000000 toby fixed in 109ec86 what else are we wanting with this?
#2532 1340874456000000 toby see void now
#2536 1339770953000000 toby minor changes All links now go to the item - before deleted ones didn't. while this makes sense it is inconsistent and adds complexity. Some wrapping spans eg <span class="object">.. have been removed again these add complication and feel wrong given the issues of i18n PS: why messing with my tickets???
#2536 1340038712000000 toby https://github.com/okfn/ckan/pull/25
#2536 1340899218000000 toby This need some changes to make it possible to add new activity stream bits - will look at doing for 1.9
#2553 1342090078000000 toby different implementation but same effect
#2555 1340373267000000 toby non urgent moving milestone
#2558 1340271359000000 toby @aron, not quite sure what your problem was. I had an integrity error on part 1 save which is fixed. my issues 1) part 1 tags not saved 2) part 2 resources not saved 3) part 3 no form shown - i thought you had one showing where did it go? will look at 1 & 2 for starters
#2558 1340280814000000 toby 1) tags save but don't show in dataset edit - will push fix soon
#2558 1340284495000000 toby 2) resources save but not sure if being validated etc needs testing but working to an extent @aron, I'm pushing this back to you now reassign as needed
#2558 1340359174000000 toby groups available now is a helper function (templates updated) commit d0506f3
#2558 1340367843000000 toby @aron, metadata now saves pushing back to you - in branch
#2559 1342084940000000 toby I'm closing this now we can open tickets for bugs when we qa the add dataset
#2560 1342084988000000 toby again closing any problems can be bugfix tickets
#2562 1342090168000000 toby @aron, assigning to you so doesn't get lost let me know if you need anything from me for this
#2569 1340362284000000 toby @aron, which page is this on? can you add a url - cheers
#2569 1340375156000000 toby i'm assuming this is the add data part 2 add dataset form
#2569 1340376578000000 toby @ira, that's fixed in the dev branch just not pushed to demo we need the one i've suggested too
#2569 1340877069000000 toby There is now the list in the sidebar but it points to view resource not edit - that will be part of phase 2
#2569 1342085235000000 toby edit resources in add dataset is done anything else is a new ticket
#2571 1340369783000000 toby this works so closing
#2574 1342008841000000 toby david I think this is a closed as we are using state= draft stuff
#2574 1342092416000000 toby this is all sorted so closing
#2575 1340184557000000 toby @adria, Do you have a url or some more info as I can't reproduce this
#2575 1340188954000000 toby wtf I never added that I did write in an hour ago f****g trac
#2575 1340899487000000 toby This should now have a fix do a proper fix for 1.9 - needs a more thought out approach and quite a bit of re-factoring of that bit of code
#2575 1343216544000000 toby merged for 1.8
#2576 1340369674000000 toby @aron the resources sidebox is still broken breadcrumb is fixed though
#2579 1340899337000000 toby This can move to 1.9 as will need agreement to be merged
#2580 1342092353000000 toby I'm closing this as now you need to add at least one resource
#2581 1340287539000000 toby do before data.pop(key)
#2581 1340369369000000 toby fixed in commit 0f84d99 in the demo branch david can you just look at this for a sanity check - I'm just concerned that only state benefits from this if good reassign to me and i'll remove the fixme
#2581 1340714955000000 toby @kindly we actually need an extra state for full functionality can we create a new 'draft-complete' state as well? does that need any additional magic? please answer and reassign
#2581 1340800263000000 toby part of add dataset stages
#2583 1342086274000000 toby moving to phase 3 as really a review of our code type stuff
#2587 1340376975000000 toby fixed by 99d14bd
#2595 1342086346000000 toby yadda, yadda, yadda - this should all be done any bugs are new tickets
#2596 1345209485000000 toby closing as too vague and probably done
#2609 1340900271000000 toby fixed in demo branch
#2612 1342005674000000 toby is this still valid?
#2612 1342007335000000 toby cool close when you are happy or reassign if you find it broken somewhere I'm moving this to phase 2
#2620 1342074737000000 toby This got fixed at some point
#2632 1342087027000000 toby merged
#2634 1342085656000000 toby merged into master
#2636 1342090614000000 toby duplicate of http://trac.ckan.org/ticket/2631
#2637 1342617226000000 toby fixed
#2638 1342112772000000 toby merged
#2640 1342092306000000 toby moving to phase 2
#2642 1342092375000000 toby moving to phase 2
#2642 1344601299000000 toby @ira, can you review this http://s031.okserver.org:2375/harvest The add/edit form isn't perfect I have no idea how to use this extension so my testing has been limited make a new ticket for any problems - Also for now we only care about major issues @adriá would be nice if you could also see if it's working correctly
#2646 1342014170000000 toby fixed in 2375-demo-theme-development
#2647 1342169056000000 toby @aron this button is now working on core http://localhost:5000/dataset/newcastle-city-council-payments-over-500/resource/0c2bd47a-6ac5-412e-a337-1b45a952e07e please note it is hidden in ckanext-demo also your `modal` think stops the link working - can you get it so that we open the href in a lightbox or somesuch. Also for now whilst waiting for the modal stuff to be implemented it'd be nice if it didn't block the link
#2652 1343378442000000 toby this should sort some resource format issues
#2653 1342005167000000 toby config issue resolved
#2657 1342008765000000 toby fixed by aron
#2658 1343378208000000 toby @aron, If we are doing this then we should just get it done asap. I have to say I think it sucks as an idea as I know what a group and a publisher is in english and we have groups. I'd like this a wontfix
#2658 1343378309000000 toby the mor i think about this the crapper it seems wtf - can we just close it and hope it goes away?
#2659 1342022519000000 toby looks like one for you aron
#2660 1342011096000000 toby not reproducable
#2660 1342090270000000 toby this is sorted in master
#2660 1342090301000000 toby well not master but 2375-demo-theme-development which is good as
#2661 1342014327000000 toby @aron, we only can delete - see button if we have permission if you make logic/auth/delete.py package_delete() return {'success': True} then it will give everyone the permission - useful for testing
#2661 1342515034000000 toby @aron, flash messages added I've changed these to being done via form javascript action: on click delete button display dialog confirm -> set hidden input name=confirm_delete value -> "yes" submit form no -> stop form submit hope that makes sense if not shout need this for dataset/group will also need for resource/related at some point soon
#2661 1342685899000000 toby @aron can you change this so that we now post to the href if confirmed should then work for group, dataset, related resource will pretend to work but not actually delete yet
#2662 1342018898000000 toby this was actually an issue with form error anyhow fixed in both 2375 branches but needs pushing to the server
#2664 1342181774000000 toby branch 2664-tag-errors has some ideas - how do we deal with whole errors issue
#2665 1342077077000000 toby @aron I've done some of this I'll reassign to you when I'm done
#2665 1342079165000000 toby @aron, ok if you now pull 2375-demo... you will see I've moved the stages into the form and added some buttons - this should now be stable and ready for you to style
← 25 26 27 28 29 30 31 32 33 34 35 36 37 38 →
Note: See TracReports for help on using and creating reports.