{23} Trac comments (3729 matches)

Results (2101 - 2200 of 3729)

Ticket Posixtime Author Newvalue
#1194 1317043212000000 dread Suggest changing this to "Welcome, Rob" rather than "Welcome back, Rob", avoiding the problem.
#1194 1317053674000000 dread Done in cset:49e2c05e69ea
#1194 1317053688000000 dread Will go into ckan 1.5.
#1353 1317075904000000 rgrp This is not deliberate and has been fixed in #1348
#1313 1317076432000000 rgrp Error was due to maintenance. Need both config options for recaptcha to work so either one can be used to check config. Re docs see #1358 (auto generation of docs on config from the config source). Given that only docs remain and that is part of #1358 am closing as duplicate.
#1361 1317082893000000 rgrp Fixed in https://bitbucket.org/okfn/ckan/changeset/cb641a5151df
#1338 1317117738000000 amercader Fixed in eca1edce3a0f
#1329 1317118323000000 dread I'll take a look to see if I can do any more and then will close it.
#1268 1317212499000000 kindly fixed cset:eebbe6071741
#1356 1317220284000000 kindly fixed cset:1defa48097f5
#1360 1317315031000000 dread I believe zephod has removed these from the UI already. I removed them from the search code, tests, docs and provided suitable guidance in cset:5b20ae1673ea which is headed for CKAN 1.5.
#1252 1317315135000000 dread This is done now?
#1251 1317315159000000 dread rgrp did this last weekend.
#1289 1317315211000000 dread Discussions have not resolved this either way. Decided to leave it like it is for now.
#1166 1317381932000000 amercader Fixed on d5bee3de9957
#1320 1317391018000000 zephod Extend misc.py to regex find http and https, surrounding it with <>. ALSO note that CKAN flavoured markdown will not currently recognise dataset:my_data links (still uses package).
#1367 1317394273000000 dread Fixed in cset:d15d81aa63cf for
#1329 1317404566000000 dread POT looks far better. I couldn't see any outstanding problems. This has gone into ckan 1.5.
#1245 1317422640000000 rgrp Closing as now mostly done and not really a ticket item.
#1363 1317656645000000 johnglover table: task_status id entity_id entity_type task_type key value date_updated state unique(entity_id, task_type, key) example keys: last_task_id
#1320 1317730999000000 zephod Slightly painful when links appear inside naughty HTML tags or in markdown tags. Restriction: Links are auto-linked if they appear at the start of a line or after whitespace. cset:f9dfb0506594
#1369 1317732684000000 zephod cset 6904048ce970 Okfn needs to accept a github pull request to make this work. Currently CKAN live-links to the raw github script for ckanjs, which must be updated.
#1358 1317748211000000 dread You're gonna have massive config files if you do this! Might well be worth it though.
#1373 1317829572000000 shevski Apparently works locally for David Raznick on default
#1371 1317833379000000 johnglover Done, in branch feature-1371-task-status-logic-layer
#1374 1317895709000000 dread Would be nice also to print the default language first in the list.
#1376 1318091245000000 kindly fixed cset:39acf62f30b0
#1252 1318160334000000 rgrp This was done ~2 weeks ago.
#1357 1318162150000000 rgrp Code to create a test dataset for data preview: https://gist.github.com/1273560 (have not added to CKAN CLI since it seems too specialist and liable to change ...)
#1357 1318164458000000 rgrp Completed and merged into default in https://bitbucket.org/okfn/ckan/changeset/9ea072d67245
#1320 1318164603000000 rgrp Completed in https://bitbucket.org/okfn/ckan/changeset/f9dfb0506594
#1369 1318165086000000 rgrp Completed and merged in https://bitbucket.org/okfn/ckan/changeset/e75158acdcfa
#306 1318181194000000 rgrp Duplicate of https://github.com/okfn/datapkg/issues/4
#100 1318181227000000 rgrp Resolving as wontfix since not really sure any point to this.
#97 1318181317000000 rgrp Duplicate of: https://github.com/okfn/datapkg/issues/5
#1364 1318199135000000 kindly fixed cset:294a0b6577b0
#1264 1318244619000000 zephod Created #1377 to handle bugs revealed while doing this work.
#1264 1318245716000000 zephod Complete; cset:b216952644aa
#1377 1318245795000000 zephod Complete: cset:b216952644aa
#1375 1318260008000000 amercader Fixed in 888ed50c098d, using Session.flush() rather than the proposed one.
#1385 1318419159000000 dread Another change needed for this (via Florian): {{{ diff -r 6f27828a4621 ckan/lib/cli.py --- a/ckan/lib/cli.py Wed Oct 12 11:10:32 2011 +0100 +++ b/ckan/lib/cli.py Wed Oct 12 12:23:18 2011 +0100 @@ -132,7 +132,7 @@ pg_cmd += ' -U %(db_user)s' % self.db_details if self.db_details.get('db_pass') not in (None, ''): pg_cmd = 'export PGPASSWORD=%(db_pass)s && ' % self.db_details + pg_cmd - if self.db_details.get('db_host') not in (None, '', 'localhost'): + if self.db_details.get('db_host') not in (None, ''): pg_cmd += ' -h %(db_host)s' % self.db_details if self.db_details.get('db_port') not in (None, ''): pg_cmd += ' -p %(db_port)s' % self.db_details }}}
#1319 1318426807000000 rgrp @dread: hope it is OK to re-assign to me but this is very similar to #1386 (and is a su bticket of #1343)
#1387 1318429228000000 dread I'm generally against validation. When doing any bulk import, it either have to ignore validation errors or lose data. If you ignore the errors, you find you can't edit the dataset without correcting the validation error, and you often end up guessing, just to get your other changes in. All in all, I think it is better to nudge users, with javascript pop-ups in the form, or quality scores, rather than hard-and-fast validation.
#1393 1318505854000000 dread I changed this: {{{ diff -r 47657581fc30 ckan/tests/__init__.py --- a/ckan/tests/__init__.py Wed Oct 12 17:58:19 2011 +0100 +++ b/ckan/tests/__init__.py Thu Oct 13 12:29:54 2011 +0100 @@ -373,7 +373,7 @@ plugins.load('synchronous_search') def is_search_supported(): - supported_db = "sqlite" not in config.get('sqlalchemy.url') + supported_db = True return supported_db def is_regex_supported(): }}} But there seems to be a problem finding the package when trying to index it: {{{ ====================================================================== ERROR: test suite for <class 'ckan.tests.functional.test_search.TestSearch'> ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/nose/suite.py", line 208, in run self.setUp() File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/nose/suite.py", line 291, in setUp self.setupContext(ancestor) File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/nose/suite.py", line 314, in setupContext try_run(context, names) File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/nose/util.py", line 478, in try_run return func() File "/home/dread/hgroot/ckan/ckan/tests/functional/test_search.py", line 21, in setup_class CreateTestData.create_search_test_data() File "/home/dread/hgroot/ckan/ckan/lib/create_test_data.py", line 66, in create_search_test_data cls.create_arbitrary(search_items) File "/home/dread/hgroot/ckan/ckan/lib/create_test_data.py", line 197, in create_arbitrary model.repo.commit_and_remove() File "/home/dread/hgroot/pyenv-ckan/src/vdm/vdm/sqlalchemy/tools.py", line 110, in commit_and_remove self.commit() File "/home/dread/hgroot/pyenv-ckan/src/vdm/vdm/sqlalchemy/tools.py", line 100, in commit self.session.commit() File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/sqlalchemy/orm/scoping.py", line 139, in do return getattr(self.registry(), name)(*args, **kwargs) File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/sqlalchemy/orm/session.py", line 614, in commit self.transaction.commit() File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/sqlalchemy/orm/session.py", line 385, in commit self._prepare_impl() File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/sqlalchemy/orm/session.py", line 361, in _prepare_impl ext.before_commit(self.session) File "/home/dread/hgroot/ckan/ckan/model/extension.py", line 103, in before_commit methodcaller('before_commit', session) File "/home/dread/hgroot/ckan/ckan/model/extension.py", line 38, in notify_observers func(observer) File "/home/dread/hgroot/ckan/ckan/model/modification.py", line 45, in before_commit self.notify(obj, DomainObjectOperation.new) File "/home/dread/hgroot/ckan/ckan/model/modification.py", line 70, in notify observer.notify(entity, operation) File "/home/dread/hgroot/ckan/ckan/lib/search/__init__.py", line 93, in notify package_to_api1(entity, {'model': model}), File "/home/dread/hgroot/ckan/ckan/lib/dictization/model_dictize.py", line 231, in package_to_api1 dictized = package_dictize(pkg, context) File "/home/dread/hgroot/ckan/ckan/lib/dictization/model_dictize.py", line 118, in package_dictize raise NotFound NotFound ---------------------------------------------------------------------- Ran 1 test in 2.734s FAILED (errors=1) }}} Any ideas John?
#1393 1318508765000000 johnglover Yes, there are a few of these problems with SQLite which is why the tests are being skipped currently. I'm not exactly sure of the reason, it seems that it sometimes drops tables from memory, but we haven't found a solution. Myself and David Raznick were going to spend some time looking at it but haven't had a chance yet.
#1395 1318520543000000 seanh The exact command that introduced the too-new webob into my virtualenv was: {{{ pip install --ignore-installed -r pyenv/src/ckan/requires/lucid_missing.txt -r pyenv/src/ckan/requires/lucid_conflict.txt }}}
#1395 1318525201000000 dread This problem is mentioned here: http://docs.ckan.org/en/latest/test.html but you're right, it really should be solved in the install instructions.
#1386 1318527591000000 rgrp Fixed in https://bitbucket.org/okfn/ckan/changeset/130cad62163c
#1319 1318527613000000 rgrp Fixed in https://bitbucket.org/okfn/ckan/changeset/130cad62163c
#1343 1318528138000000 rgrp Remove from ckan-v1.5 since remaining non-complete items (user page improvements and modal login won't get done in v1.5.
#1383 1318528301000000 rgrp Just to check: I thought conclusion was we do not need IResourceUrlChanged since we would only do archiving for newly created resources?
#1065 1318528721000000 rgrp Reassigning to zephod as he is looking at this. I think most of this is wontfix or will become obsolete with other stuff but worth looking at. Also moving to v1.6 at the same time.
#890 1318529648000000 rgrp May want to close as invalid as obsoleted by more recent queue work.
#890 1318599247000000 kindly Invalid due to #1397, We will be using celery instead.
#891 1318602128000000 rgrp May only do link-checker and not do full storage in this sprint.
#1141 1318862183000000 dread What's the status of this now? The ckanext-moderatededits README still says you need a branch of ckan. Can you say which version of CKAN is required instead? I say we close this if ajax call is now in a better place in the API. (I expect it is now, with the logic layer).
#1141 1318862773000000 johnglover Well, it runs on datacatalogs.org with the current default so CKAN 1.5, but it needs quite a bit of updating to work with all of the new 1.5 UI changes, and as it has been a low priority for quite a while I haven't scheduled time to work on it. Really I would need to spend a few days on it to tidy it up for standard 1.5.
#1381 1319021092000000 amercader Now implemented on 6227142b0460
#1410 1319213205000000 zephod Oops: #1409 double posted.
#1379 1319306665000000 rgrp This is minor but a real bug (seen now in several datasets). As easy to fix suggest bumping and trying to get into v1.5 (?).
#1409 1319306802000000 rgrp What do we do for people without email addresses (no gravatar or a standard anonymous one?)
#1383 1319405579000000 kindly We only added the Iresourceurlchange interface as we made the IDomainObjectModification include the Package.
#1415 1319457583000000 nils.toedtmann Arww ... sorry i only now rediscovered James' mail "CKAN Packaging" from Sept 29th where he announced the availability of the repository http://apt.okfn.org/ckan- . This package release already addresses many of the above points. I will test those packages and refine my comments then. Sorry for the noise.
#1418 1319539691000000 dread Same as #1374
#1373 1319542883000000 dread I think this is due to the etags cache not taking into account whether you are logged in. So the page is cached by squid (which is why it's not seen anywhere apart from thedatahub.org).
#1419 1319548778000000 rgrp I've successfully logged into thedatahub using my openid. Issues may arise especially with google openid due to changes in site (from ckan.net to thedatahub.org). See: http://lists.okfn.org/pipermail/ckan-dev/2011-October/001384.html
#1321 1319558004000000 dread We should not cache if there are flash messages to show (otherwise they get queued up for the next non-cached page view). Fixed in cset:945e2a6ce74f for release 1.5
#1409 1319567582000000 zephod https://bitbucket.org/okfn/ckan/changeset/c8c62bc8766d
#1378 1319567698000000 zephod https://bitbucket.org/okfn/ckan/changeset/494bbd08364f
#1392 1319625243000000 johnglover Now on s054.okserver.org
#1380 1319627454000000 zephod https://bitbucket.org/okfn/ckan/changeset/f600e0d37f6c
#1421 1319639311000000 dread Fixed in cset:109db2176fac for 1.5 release.
#1229 1319639472000000 dread I found another direct use of the d.b. in the home controller.
#1422 1319645722000000 dread Done in cset:54fc460602d2 on default for 1.5.1 release.
#1229 1319645778000000 dread Replace code in home in cset:f19f9c5bec94 on default for release 1.5.1.
#1374 1319648726000000 dread This is fixed in branch defect-1418-i18n for release 1.5
#1341 1319649573000000 dread The majority of our 6000 users are still spammers. Can we simply elimenate those who've not made any revisions? Even if we take a few genuine users with it, these are pretty dead accounts anyway.
#1417 1319651617000000 dread Fixed in branch defect-1418-i18n for release 1.5.
#1426 1319709236000000 dread Reading http://www.checkupdown.com/status/E409.html I've changed my mind - 409 is ok for an application level validation error.
#253 1319709714000000 dread Closed by mistake
#1427 1319709925000000 dread Done in cset:ec9a9efc2d40 for release 1.5
#1341 1319709997000000 dread Reopening - this is still a serious problem. We can't link to the user page because it is so embarrassing: http://thedatahub.org/user
#843 1319710380000000 dread * "we should show the openid as well to distinguish between users with the same name." - when "Full name" is not distinguishable, maybe best to display the unique 'name' field as a hover-over. * "on account creation, the user should be redirected to their personal details page to encourage them to fill in a human readable name." - yes you always got take to the personal details page. We should use a flash message at this point if they have not filled in the "Full name" field to suggest they click edit and do this. * "List is to long" - this has been addressed - see http://thedatahub.org/user
#843 1319721601000000 dread Ok I misunderstood this ticket. This is referring to adding a user in e.g. http://thedatahub.org/group/authz/energy-data This UI seems to be updated. You start typing the name, full name or open id of the person and it has a dropdown that autocompletes. This seems to be sufficient for Will's points 1 and 3. Would be still good to have a flash message on account creation to encourage people to add personal their Full name. This is similar to #1413 so I'll close this ticket and add it there.
#737 1319730303000000 dread Something like this one on github: {{{ # This is an <h1> tag ## This is an <h2> tag ###### This is an <h6> tag Text styles *This text will be italic* _This will also be italic_ **This text will be bold** __This will also be bold__ *You **can** combine them* Lists Unordered * Item 1 * Item 2 * Item 2a * Item 2b Ordered 1. Item 1 2. Item 2 3. Item 3 * Item 3a * Item 3b Miscellaneous Images ![GitHub Logo](/images/logo.png) Format: ![Alt Text](url) Links http://github.com - automatic! [GitHub](http://github.com) Blockquotes As Kanye West said: > We're living the future so > the present is our past. }}}
#1425 1319735012000000 dread Cheers for taking this on Tom
#1408 1319794384000000 rgrp Suggest that going forward we always boot a site user with the same id as site id (which we may want to leave ckan.site_id blank and force user to choose this going forward?) and give it a password. May need migration or instructions in UPGRADE.txt for existing users.
#1300 1319794520000000 rgrp Side bar menu is switchable (though not sure how -- zephod has done this!) CSS tidying and labelling of divs done in #1380. So closing!
#1416 1319794595000000 rgrp In normal user submission this would result in errors reported and no 500. Happy to have this switch to 400 if you think this is a good idea.
#1419 1319795920000000 dread This seems to work better today...! myopenid works for me fine with my existing account and by reregistering. My google id works only if I reregister, and I think that is because I hadn't registered before. Closing.
#1306 1319797204000000 dread These are expressed as functional API tests - see tests/functional/api/test_action.py. There's not a lot of difference (apart from Paste coming in there) so no real need to duplicate API and logic layer tests, or to switch them to talk directly to the logic layer.
#1077 1319797284000000 dread I guess this is not a priority now.
#1248 1319797763000000 dread Fixed in cset:188d27a56c89c35f97f3a79fdd0a6460223f86cf on branch release-v1.4.3. This was only seen in CKAN 1.4.3beta.
#1334 1319798961000000 dread I think this has been a problem since 1.3.3. Fixed in v1.5.
#816 1319804698000000 dread John did this in cset:1697dfa2552c for release 1.5
#1428 1319804773000000 dread Fixed in a3b0080467d4 for release 1.5
#816 1319812324000000 dread And branch feature-816-format-autocomplete
#1258 1319812452000000 dread I believe this was broken with the introduction of moderated edits in CKAN 1.4.3 and this fix went into 1.5.
#1256 1319812556000000 dread It sounds like this became an issue with CKAN 1.4.3 and the fix goes into CKAN 1.5.
#1275 1319812967000000 dread Going into release 1.5.
Note: See TracReports for help on using and creating reports.