{23} Trac comments (3729 matches)

Results (3601 - 3700 of 3729)

← 27 28 29 30 31 32 33 34 35 36 37 38 →
Ticket Posixtime Author Newvalue
#2642 1344601299000000 toby @ira, can you review this http://s031.okserver.org:2375/harvest The add/edit form isn't perfect I have no idea how to use this extension so my testing has been limited make a new ticket for any problems - Also for now we only care about major issues @adriá would be nice if you could also see if it's working correctly
#2837 1344847463000000 aron.carroll Checkboxes created with {{{ form.checkbox() }}} should be styled correctly. Got a link to an example?
#2837 1344847819000000 toby http://localhost:5000/testing/primer essentially it's a black not grey outline also errored one isn't red
#2837 1344851271000000 aron.carroll Fixed alignment issues in Firefox as of a6fa5a0. Can't do anything about visual display of checkboxes as they're controlled by the vendor. We could replace them with images, if this is going to be required then please create a new ticket for the next phase.
#2836 1344852009000000 aron.carroll Yeah you can pass an html block into a macro like so: https://github.com/okfn/ckan/blob/2375-demo-theme-development/ckan/templates/package/snippets/resource_form.html#L44-48 What do you think? If it's useful I'll document it.
#2840 1344852538000000 aron.carroll Fixed in f7bc1c9. This can be flipped back by adding a class of {{{.tagline-right}}} to the hgoup element.
#2836 1344853957000000 toby @aron, I'd love it if we could pass it as an arg ie form.input(...., extra_info=<something escaped if not literal()>) also while we're at it I'd also really like form.input(...., help_info=<something>) that would give a (?) icon with a :hover {display:block} div - that make sense?
#2839 1344854522000000 toby this is fixed in https://github.com/okfn/ckan/pull/88
#2834 1344856692000000 aron.carroll Done in 092d257
#2841 1344857415000000 aron.carroll Fixed in a317fb9
#2836 1344859911000000 toby I'd quite like some general css like this <span class="hover-for-help">[thing to hover over] <div class="help-text">Help text</div> </span> This is for the qa extension but seems like a general need .hover-for-help .help-text{ display:none; } .hover-for-help:hover .help-text{ display:block; position:absolute; padding:3px; }
#2808 1344944258000000 aron.carroll Close in 97d92ba
#2780 1345023811000000 toby This is a new feature moving to phase 4
#2728 1345023944000000 toby Issue with not re-indexing datasets when group is updated - needs proper fix as part of phase 4
#2772 1345027445000000 seanh Transifex was updated and translators notified, translations were made and pulled into 1.8
#2843 1345035045000000 ross Add existing dataset doesn't make a lot of sense because they can only belong to a single organization. Best would be to fix the organisation template to remove Add Existing.
#2853 1345049201000000 amercader The message it is pretty self-explanatory, but I'm happy to lower it to warning. We can't know the scheduled time because it depends on how is set up on the server (generally a cron job every x minutes).
#2856 1345049793000000 shevski server error URL: http://s031.okserver.org:2375/apps/49a509f7-4eb6-456f-b1fc-87cfde90c60d
#2855 1345103314000000 toby @ira, this works for me at the given link try refreshing the page in case it's a cache issue
#2852 1345103409000000 toby @ira, Please review the fix I think adriá did
#2852 1345103634000000 toby I think it should stay red but you can argue
#2853 1345103841000000 toby @ira, I'll change to notice will do for the other one too
#2852 1345104027000000 shevski Red is fine here Can we amend the message to: Cannot create new harvest jobs on inactive sources. First, please change the source status to 'active'.
#2855 1345104178000000 shevski I cleared my cache and it's working now
#2853 1345104231000000 toby @both notices now blue
#2852 1345106515000000 toby text updated and red again
#2857 1345107097000000 toby dashboard hidden in phase 3 we can fix up in phase 4
#2856 1345107503000000 toby fixed now gives 404 The issue of not wanting a 404 is outside the scope of this ticket as it's a whole activity stream issue and needs dev buy in etc
#2642 1345113645000000 shevski done
#2863 1345122384000000 toby @ira, This is actually working correctly but the permissions on the server s031 are not what you want I do not know how or where these are defined - he has package_update permissions from somewhere maybe ross or someone knows
#2863 1345122876000000 ross This is changeable in config. The default permissions are specified in there I believe.
#2863 1345123824000000 shevski If by default it doesn't happen, then that's fine & we can close this. Any way for me to see how permissions are set?
#2863 1345123978000000 ross No idea :| The perms are commented out by default in the template ini file. You should take a look at the ini file and see how it is setup, search for ckan.default_roles.Package but I can't see how Daniel would have been granted read access without the auth pages being implemented.
#2639 1345125290000000 rgrp #196 is fixed. Not sure about #195. Otherwise think we are good to go.
#2639 1345125344000000 rgrp There is also an additional issue which is that recline no longer uses elasticsearch_url so we will need to patch this either in js or in the controller code for the embed ...
#2873 1345129315000000 danieljohnlewis For example see: http://s031.okserver.org:2375/qa/dataset/five_stars Which has: Example dataset as a score of: 4 After examination of the dataset ( http://s031.okserver.org:2375/dataset/example-dataset ) it is made up of a CSV and an HTML file.
#2796 1345129471000000 shevski Some notes already here: http://ckan.okfnpad.org/datahub-faq
#2796 1345129495000000 shevski and here: http://wiki.ckan.org/Using_the_Web_Interface
#2865 1345131215000000 ross Can't replicate locally in either master or release-v1.8 /el/ isn't a valid locale, and so the problem is unicode in urls where ckan is trying to generate a 404.
#2873 1345136489000000 toby This is a problem with the summary data not the resource qa score it is almost certainly due to stale data. keeping here till resolved
#2639 1345146087000000 rgrp Also found that previous recline setup used elasticsearch_url in recline 'state' (dataset part) when generating embed_url for dataset. But recline no longer supports this so move to url attribute of dataset attribute of state.
#2639 1345146289000000 rgrp Port of fix for recline issue 196 in https://github.com/okfn/ckan/commit/fd1abd9d5701b4addf7e709c1766d6ffed1bb8bf Fix of embed issue in https://github.com/okfn/ckan/commit/fd1abd9d5701b4addf7e709c1766d6ffed1bb8bf
#2331 1345191494000000 rgrp Re-opening yet again. This is something brought up by entire client team on several occasions :-) We really do need to fix this as it is really poor UX. To give, yet another, example: http://datahub.io/dataset?q=thatcher+wages This returns 15 datasets yet only one of them has any mention of thatchers (the first one!). (The others are there because they match wages). This isn't what I expect. I expect *only* to see datasets that match *both* terms ...
#2331 1345192722000000 ross This is the dullest game of ticket tennis ever :D Google don't OR the results, they have an explicit operator for ORing query terms and default to ensuring that all terms are present (in one form or another) in the documents. I understand the argument about cut-offs and relevancy scores, but for a large search engine they have the benefit of scale both in resource and documents. I spent 6 months of my life tweaking weightings for n-dimensional vector space search, I don't think it is likely to be a number we can, or will find by accident. Given that Marcus also got confused by the current behaviour I think we should either: a) Make it configurable b) Just change it to what has been asked for Don't care which.
#2863 1345201502000000 toby @ira, I am moving this to phase 4 as it's not going to be looked at till the new permissions stuff is agreed
#2873 1345208283000000 toby qa extension is crap and needs fixing to work properly due to where it stores data (in the task status - wtf)
#2596 1345209485000000 toby closing as too vague and probably done
#2671 1345209579000000 toby I believe this is fixed in master/2375
#2371 1345209675000000 toby closing as part of 2375 branches
#2639 1345221501000000 amercader Added some new comments to #195: https://github.com/okfn/recline/issues/195
#2844 1345454527000000 toby paster db clean fixed in https://github.com/okfn/ckan/pull/107
#2818 1345482572000000 toby @ross, This is an issue with the related items schema - I'm not quite sure what all the rules should be eg does visulisation need image url? or is normal url ok? Could you review the schema and ensure that we require/don't require the correct items. If you provide the rules I can help do the schema if you want but I don't know them cheers Toby
#2818 1345485131000000 ross URL should be required, image url isn't required.
#2519 1345565215000000 ross Fixed by pull request from jpmckinney
#2877 1345600430000000 kindly 1. This is fixed need to reload data to test though. 2. Fixed as far as I am concerned, limit 0 now returns correct total. If there are no results in filter return total of 0. 3. Want to keep postgres types. This will stop the need for mappings in both directions and makes everything simpler. We are currently not storing any metadata on tables and would like it to stay that way.
#2885 1345625524000000 seanh authz_form_table() in ckan/templates/package/authz.html creates a table with non-translatable labels (anon_editor, admin, editor, reader...)
#2881 1345626056000000 rgrp @seanh - this was the material from the wiki moved to the docs. I agree it is somewhat incomplete but we certainly shouldn't remove it without something better in place. Also, IMO this is currently very low priority ...
#2883 1345629890000000 seanh Also see the thread here: http://lists.okfn.org/pipermail/ckan-discuss/2012-August/002382.html the questions asked in the thread should give ideas what to add to the overview
#2890 1346175867000000 rgrp I know this is tricky. The issue is that Datastore does not exist *just* to provided data views - it also provides a bunch of other stuff like a Data API and, well, a Datastore. I also think there are different audiences. Data view info is about publishers and (viewing) users, while the Data API is for (non-CKAN) devs and CKAN devs and the Datastore sysadmin section is for deployers. My feeling is therefore keeping things as is but with more stuff in the Data View seciton about it all works: * Data viewer: explanation for publisher, links to next 2 sections * Datastore page (as we have it) * Includes datastorer * Using Data API page (as we have it) So main change is a better data viewer page ...
#2818 1346231718000000 ross Has been suggested that we are clearer on why the URL is required, as this related items are really just 'Links'. We should consider the name change, and also possibly make the types configurable in config somewhere as they are currently almost content free. Assigned to Sean to keep an eye on this ticket until we get a reasonable chance to action it.
#2599 1346236806000000 johnmartin FYI: My methodology for getting the demo working in IE7 will be: get it functioning and not get it perfect
#2900 1346335788000000 seanh Why does this only happen on user profile pages and not dataset search page or group read page? Looks like maybe only user profile page uses the package_list.html snippet
#1551 1346662048000000 ross Webstore appears to hav been deprecated in favour of datastore.
#2329 1346664271000000 ross Moved to 2.0 branch for new UI.
#2550 1346669497000000 ross Reassigned to icmurray rather than back to backlog.
#909 1346669602000000 ross Backlog until funded.
#2577 1346669735000000 ross Better info was provided by jmckinney
#1650 1346670010000000 ross Closed as unnecessary now.
#2736 1346670097000000 ross Going to be reworked without celery.
#2619 1346670257000000 ross Have a push request with a privacy flag which might be useful in determining the status of the dataset (public/private) but no idea if it will be accepted yet. Have assigned back to you for safe-keeping so it doesn't get lost in backlog.
#2814 1346670381000000 ross Have assigned to client team to decide what they want to do about this.
#2554 1346670433000000 ross Shelved until LOD plenary/funding found. Longer term plans for an LOD hosted triplestore may make this unnecessary.
#1685 1346670530000000 ross 8 months and no movement, looks like a wontfix.
#2599 1346756230000000 johnmartin This is now closed and waiting pull request merge back in.
#2741 1346841059000000 johnmartin Awaiting merge into demo branch
#2906 1346862889000000 shevski fixed by removing custom css from the stylesheet, but should look into why it happened
#1171 1347358705000000 ross I have implemented this on the datahub, but this change likely needs to be made to CKAN core. Probably as part of 2.0. The format on tdh is currently: ${TITLE}. ${AUTHOR}. Retrieved ${UTC time}. ${DATASET LINK} Best discuss and agree on what format should be supported. Mark, I've assigned this to you as it is tagged academia ;)
#2931 1347891378000000 seanh Also set_global() seems to have the wrong docstring
#2934 1347969321000000 dominik This looks promising but seems to be discontinued: http://twill.idyll.org/python-api.html
#2934 1348060201000000 dread The functional tests actually do cover a logged in person editing a dataset and then checking it displays correctly in the view page again. The webtest framework we use in CKAN has form filling and link click() function which allows navigation between pages like you describe these other ones having too. Having said that, there is no reason why a newer library shouldn't be introduced if webtest is not sufficient. And if there are stories without tests then it would be good to add them.
#2937 1348157780000000 seanh This is fixed on master (commit e97b5c70e9325a1095778fef8e0d27c84e881b30) needs to be cherry-picked into 1.8
#2937 1348238875000000 seanh Cherry-picked into 1.8
#2203 1348568961000000 dominik There is work on this in the dataviewer-iframe branch.
#2942 1348610791000000 dread Unfortunately with a few hours hacking I couldn't find a way to get this version of WebOb to cope with this header. The line I think it goes wrong is {{{ctype = env.get('CONTENT_TYPE', 'application/x-www-form-urlencoded')}}} in request.py, and the commented line above looks right, but wipes the request data for some reason. I tried intercepting the bad header and deleting it, but I couldn't do that before WebOb processed it, and couldn't persuade WebOb to reprocess it once the header was edited. I did write a failing test though if that is useful to someone in the future: {{{ diff --git a/ckan/tests/functional/api/test_api.py b/ckan/tests/functional/api/t index 539d184..b4cc4ce 100644 --- a/ckan/tests/functional/api/test_api.py +++ b/ckan/tests/functional/api/test_api.py @@ -49,6 +49,18 @@ class TestApi3(Api3TestCase, ApiTestCase): assert_in('Bad request - JSON Error: No request body data', res.body) + def test_content_type_headers_can_be_sent(self): + '''#2942 Webob can only cope with very specific Content-Type header + values, so this tests that a work-around is in place. + + This particular header value is the default for 'requests' 0.14. + ''' + offset = self.offset('/action/package_search') + params = '%s=1' % json.dumps({'q': 'russian'}) + headers = {'Content-Type': '; charset=utf-8'} + res = self.app.post(offset, params=params, headers=headers, + status=[200]) + }}} There is a clear error to the user: {{{ >>> requests.post('http://datahub.io/api/action/package_list', data='{}').content '"Bad request - JSON Error: Could not extract request body data: Bad content type: \'; charset=utf-8\'"' }}} The advice to users of requests would be to ensure they specify the content-type as follows: {{{ >>> requests.post('http://datahub.io/api/action/package_list', data='{}', headers={'content-type': 'application/x-www-form-urlencoded'}).content }}}
#2942 1348611144000000 dread > {{{ > >>> requests.post('http://datahub.io/api/action/package_list', data='{}', headers={'content-type': 'application/x-www-form-urlencoded'}).content > }}} Or even better: {{{ >>> requests.post('http://datahub.io/api/action/package_list', data='{}', headers={'content-type': 'application/json'}).content }}}
#2950 1349168838000000 toby just a note to say fanstatic will serve minified files if it finds them in production even if they are old so we need to make sure they are up to date.
#2951 1349168981000000 toby the files like red.css should also be done as part of this. and before minification of files - should really be part of same process
#2953 1349257893000000 toby awaiting merge https://github.com/okfn/ckan/pull/145
#2956 1349278531000000 johnmartin OK, this was simple... I just added an already made snippet to the page. Ira: Can you confirm that the attached screenshots satisfy fixing the problem?
#2956 1349346442000000 shevski This needs to be a navigation menu item that includes both the name & link to the dataset edit page and then underneath (nested) the links to it's resources - so that the user can easily move between the dataset edit pages and resource edit pages and know where they currently are (using the selected pointer style)
#318 1349778662000000 dread Here's a real example - one of many from MOD {{{http://www.dasa.mod.uk/applications/newWeb/www/index.php?page=48&thiscontent=180&date=2011-05-26&pubType=1&PublishTime=09:30:00&from=home&tabOption=1}}} Browsers accept colons and slashes happily, which is the main usage of our links. The URL looks better with the colons and slashes, rather than the encoded version. The average departmental user doesn't understand that the reason to encode them is for some academic RFC and RDF which is not "liberal in what it accepts". Since the RDF tool has a satisfactory way to encode links, this problem is essentially solved. Therefore I'm changing ckanext-archiver to accept these unencoded links, I'm afraid.
#2811 1349869110000000 amercader Fixed on master, 1.8 and 1.7.2
#2434 1350296272000000 amercader Seems to be working again, closing.
#2968 1350297070000000 seanh This also applies to other pages such as /member_new and /member_delete
#2771 1350303564000000 seanh Branch is here, but not finished yet: https://github.com/okfn/ckan/tree/2750-add-docs-and-examples-for-idatasetform-and-igroupform
#2913 1350303779000000 seanh Moving into 2.0 milestone. Also affects 1.8.
#2872 1350304179000000 seanh Just tested and this seems fixed so closing
#2980 1350560137000000 seanh Won't do unless required by a specific client
#2549 1350561840000000 seanh Closing as we've gone forward with a different solution instead
#2878 1350561906000000 seanh Closing as we've gone forward with a slightly different approach instead
← 27 28 29 30 31 32 33 34 35 36 37 38 →
Note: See TracReports for help on using and creating reports.