{22} Trac tickets (2647 matches)

Results (1701 - 1800 of 2647)

Id Type Owner Reporter Milestone Status Resolution Summary Description Posixtime Modifiedtime
#2484 enhancement toby toby ckan-v1.8 closed fixed move follower functionality into helper functions 1338547770000000 1340285964000000
#2487 enhancement johnglover johnglover ckan-sprint-2012-06-25 closed fixed Don't preview text/html

Quite a few of the current test dataset resources have their format incorrectly specified as text/html. Attempting to preview these results in the browser trying to automatically download the resource, so for now we will not preview this format.

1338806098000000 1338892521000000
#2489 defect johnglover johnglover ckan-sprint-2012-06-25 closed fixed Select publisher when dataset created via 'publisher > add dataset'

When clicking 'add dataset' on a publisher/group page, the new dataset form should select the appropriate group.

1338809595000000 1338886578000000
#2490 defect seanh seanh ckan-sprint-2012-06-25 closed fixed Dataset term translation isn't working on user pages, ckanext/multilingual test failing 1338822577000000 1338824047000000
#2491 enhancement toby aron.carroll ckan-sprint-2012-06-25 closed fixed Demo related page is missing breadcrumb

The following pages are missing complete breadcrumbs.

Add related page:

http://s031.okserver.org:2375/dataset/adur_district_spending/related/new

Needs to look like.

Dataset > {dataset_title} > Related > Create Related

Template here: https://github.com/okfn/ckan/blob/feature-2375-demo-theme/ckan/templates/related/pages/form_page.html#L6

Same deal with Edit related.

http://s031.okserver.org:2375/dataset/adur_district_spending/related/edit/5f9e665b-3e3c-428f-88b1-8554189cf14a

Needs to look like.

Dataset > {dataset_title} > Related > Edit Related

https://github.com/okfn/ckan/blob/feature-2375-demo-theme/ckan/templates/related/edit.html#L5

1338977634000000 1338979614000000
#2492 enhancement toby aron.carroll ckan-sprint-2012-06-25 closed fixed Demo create related form has broken error output

See: http://s031.okserver.org:2375/dataset/adur_district_spending/related/new

Submit the form to see broken formatting.

eg. [u'Missing value']

Example of broken image

1338977874000000 1338982678000000
#2496 enhancement toby toby closed fixed get debug fixed in demo branch

stacktrace

1339067709000000 1339418832000000
#2497 enhancement toby toby closed fixed abort loses language settings

if not logged in then go to add dataset url the language is lost

check if this is a ckan 1.7 issue

1339067855000000 1339421305000000
#2498 enhancement toby toby closed fixed on loggin redirect to requested page 1339067929000000 1339660986000000
#2500 defect ross icmurray ckan-v1.8 closed fixed get_action should raise an exception if the action requested doesn't exist

Original bug report:

Hi CKAN devs,

Can I request that ckan.logic.get_action raises an exception if the action requested doesn't exist?

Two of us had a frustrating time tracking down an exception this morning. It's difficult when the exception is raised in python in a template because you don't get a line number. The problem was caused by a new logic function being added to another extension, and we hadn't updated the code there. So if get_action raised an proper exception rather than silently returning None then I think we'd have found the problem quicker.

I'd write the code for this, but as I understand that the new system would require a ticket, branch, pull request, code review, merge. It seems a lot to do for such a small thing.

Dave

1339072580000000 1340293636000000
#2501 enhancement toby aron.carroll demo phase 1 closed fixed Implement three step dataset creation in demo site

New form should allow three steps.

  1. Add basic fields to create a dataset
  2. Add a data resource to the dataset (this can be repeated multiple times using "Save and add another"
  3. Add final metadata to the dataset.

It should be possible to jump backward through the steps by clicking the arrows at the top. Errors in fields should be validated for each step when the next button is clicked.

Implementation:

http://s031.okserver.org:2375/dataset/new

1339084829000000 1340373057000000
#2502 enhancement toby aron.carroll ckan-sprint-2012-06-25 closed fixed Create Jinja block for common helpers

Most important is {% snippet %} but {% url_for %} would be great too.

1339084936000000 1339494853000000
#2503 enhancement toby aron.carroll ckan-sprint-2012-06-25 closed fixed Look into allowing theme extensions to extend base templates

For example:

Creating a template in ckanext-demo/templates/base.html containing something like

{% ckan_extends "base.html" %}

Will extend ckan/templates/base.html

1339085096000000 1339580675000000
#2504 enhancement aron.carroll aron.carroll ckan-sprint-2012-06-25 closed fixed Remove all Genshi templates from demo theme 1339156577000000 1339409776000000
#2505 enhancement amercader amercader ckan-sprint-2012-06-25 closed fixed Docs improvements for 1.7.1

There are some areas where the documentation could use some improvement and it would be good to have it available for 1.7.1.

  • Add an introduction to harvesting support
  • Add an introduction to CSW support
  • Better upgrade docs: Some users suggested improvements to the upgrade docs on the list [1]. Also we should mention how the upgrade would work for point point releases
  • Source install: see #2406

[1] http://lists.okfn.org/pipermail/ckan-dev/2012-May/002178.html

1339166533000000 1340018770000000
#2506 enhancement seanh seanh ckan-sprint-2012-06-25 closed fixed Pull latest translations from Transifex into CKAN 1.7.1 1339175957000000 1339596352000000
#2507 enhancement seanh seanh ckan-sprint-2012-06-25 closed fixed Search button on dataset search page wraps onto next line

If you change the language to one where the word for 'Search' is longer than the English word (e.g. fr) then the search button wraps onto the next line, below the text field, which looks bad.

1339409432000000 1339596399000000
#2509 defect johnglover johnglover ckan-sprint-2012-06-25 closed fixed UI style broken on organization read page

Looks like some of the style has been updated/changed on the group read page but the changes haven't been applied to the organizations read page.

1339413084000000 1339419867000000
#2510 enhancement aron.carroll aron.carroll ckan-sprint-2012-06-25 closed fixed Demo tag lists should link to the search page

Instead of pointing to /tags/{tagname} all tag links should just point to a dataset search filtered by that tag.

Examples are on the homepage and the dataset pages.

1339513217000000 1339670520000000
#2511 enhancement aron.carroll toby closed fixed header logo should be link to / 1339513880000000 1339517817000000
#2512 enhancement toby ross ckan-sprint-2012-06-25 closed fixed Bad link on demo site.

On the group read page http://s031.okserver.org:2375/group/nhs the add dataset button goes to the edit group page instead of the add dataset url.

1339518597000000 1339576809000000
#2515 enhancement ross seanh closed fixed Related tab doesn't look selected when selected

The related tab on the dataset page doesn't change its appearance when selected like the other tabs do

1339578247000000 1340967971000000
#2517 enhancement johnglover johnglover ckan-sprint-2012-06-25 closed fixed Test installation instructions for EC ODP on CentOS 6.2 1339581689000000 1340613194000000
#2518 enhancement johnglover johnglover ckan-sprint-2012-06-25 closed fixed Create EC ODP CKAN release branch
  • branch from 1.7.1
  • apply CKAN patches that are current part of installation instructions
  • create i18n patch so custom i18n directories can be specified via a config option
1339581818000000 1339595863000000
#2519 enhancement ross ross ckan-v1.9 closed fixed Dataproxy (converters) enhancement

Whilst the error messages returned from the dataproxy are informative, they aren't particularly human readable. It isn't clear to the user whether they should retry, or whether the format of their data is causing the problem etc...

Would be lovely if the error messages returned contained a human readable version of the error.

1339584955000000 1345565215000000
#2521 defect seanh seanh ckan-sprint-2012-06-25 closed fixed synchronous_search plugin missing from deployment.ini_tmpl

It still contains the old build_search_index_synchronously which no longer works

1339595361000000 1339595469000000
#2522 enhancement aron.carroll toby closed fixed view user gatavar not sqaure

the user pic should be square on the user read page

1339604954000000 1341499095000000
#2523 enhancement toby toby demo phase 1 closed fixed New package metadata form needs creating

http://localhost:5000/dataset/new_metadata/dataset

Controller : package Action : new_metadata

template package/snippets/package_metadata_form.html

1339605176000000 1340368036000000
#2525 enhancement aron.carroll aron.carroll demo phase 1 closed fixed Demo theme should auto-generate slugs on forms 1339679954000000 1341497344000000
#2526 enhancement aron.carroll aron.carroll demo phase 5 closed fixed Demo theme new custom form fields should be created when needed

Implementation:

http://s031.okserver.org:2375/dataset/new_metadata

1339680105000000 1343924205000000
#2528 enhancement aron.carroll aron.carroll demo phase 1 closed fixed Create demo edit dataset page

Implementation:

http://s031.okserver.org:2375/dataset/edit/5b451cab-8671-4513-91c4-257784c1f484

1339686982000000 1340617176000000
#2532 enhancement toby toby demo phase 1 closed fixed show activity steam for user no js

We should allow the user activity stream to be accessible with no js by passing a param or something. Need to agree how we hide/show basically agree what classes we use.

This should be a generalised solution that we can use in other places as needed.

I think this just needs discussion

1339754158000000 1340874456000000
#2533 defect seanh seanh ckan-v1.8 closed fixed ckanext-harvest is broken with ckan 1.8b

Looks like recent CKAN cleanups broke some imports:

https://gist.github.com/2935639

1339754707000000 1339755433000000
#2536 enhancement toby toby ckan-v1.9 closed fixed cleanup activity streams 1339765323000000 1347901915000000
#2545 requirement ross ross opendatasuite 1 closed fixed Need to build DataGM site based on ODS

Requirements

We need to clone the demo ODS site for DataGM as soon as we have a mostly working demo so that the DataGM team can try it out and comment/feedback on functionality.

Interface

None

User Stories

None

Tasks

[ ] Deploy demo DataGM site.

Estimates

1340016640000000 1344337973000000
#2551 enhancement johnglover ross datahub-oct closed fixed Feature metrics

Requirements

Would be useful if we could extend the Google Analytics extension to push track events to GA so that we can determine how the system is being used, and where we can optimise the workflow.

Assuming it isn't configured to be off, track events should be added to some key action buttons so that the information on what users are doing is logged for analysis.

Interface

This could possibly just be a list of JS calls to $('x').click(_gaq.push('track'...))

User Stories

  • As a developer I would like to know which components of the system are used the most so I can streamline the processes.
  • As a support developer I would like to know which parts add complexity to the system for minimal gain and could possibly be removed, de-prioritised.

For which metrics, as many of the following as possible that are achievable without changing the templates. I think for now it is enough to just record counts of these pages/actions.

  • Any group link on homepage

  • Clicking on username (to go to profile)

  • In user profile, clicking on Edit Profile

  • Clicking Save Changes on Edit Profile page

  • Clicking on any dataset link on User Profile page

  • Any of the group links on /group

  • Clicking any of the right hand sidebar tags on /group/X

  • Visiting /group/history/X

  • Compare Button on /group/history/X

  • Compare Button on /dataset/history/X

  • Tags on right hand sidebar of /dataset/X

  • Download button on any /dataset/X/resource/* page

  • Data API button on any /dataset/X/resource/* page

Tasks

[ ] Analysis/Clarification?

[ ] Code/Config? changes

[ ] Documentation

Estimates

1340017689000000 1343042712000000
#2553 enhancement toby toby demo phase 2 closed fixed Create a get snippet api action

just passes template name

?template_name=...

1340020613000000 1342090078000000
#2556 enhancement aron.carroll aron.carroll demo phase 1 closed fixed Update module styles on the demo theme

They've become inconsistent as the design has changed.

  • Remove white stripe
  • Make text sizes consistent
  • Make white space around text boxes consistent
1340035028000000 1340212090000000
#2557 enhancement aron.carroll aron.carroll demo phase 1 closed fixed Demo issues on the search dataset page
  • Crosses have disappeared
  • Formats should stretch across the page
1340035222000000 1340185609000000
#2558 enhancement aron.carroll aron.carroll demo phase 1 closed fixed Demo site add dataset has missing functionality
  • Needs tags
  • Needs groups
  • Needs slug
  • Licenses links to something
  • Needs tooltips (Ira to write some tooltips)
1340035280000000 1340615257000000
#2559 enhancement toby aron.carroll demo phase 2 closed fixed Demo theme add resource has missing functionality
  • Show resources in the sidebar
  • Allow people to go backward and forward
  • Have a back button on each form
  • Lose resource type
  • Add extras as optional metadata
  • Remove save
  • Add back/Previous
  • Add Another
1340035336000000 1342084940000000
#2560 enhancement toby aron.carroll demo phase 2 closed fixed Demo theme add metadata is missing functionality
  • Hide remove button when adding new field
  • Finish takes you to the newly created dataset
1340035384000000 1342084988000000
#2561 enhancement aron.carroll aron.carroll demo phase 1 closed fixed Demo theme edit dataset is missing functionality 1340035457000000 1341497328000000
#2563 enhancement aron.carroll aron.carroll demo phase 1 closed fixed Add font based icons to the demo theme

Allowing them to be displayed in many sizes, colours and resolutions.

http://www.zurb.com/playground/foundation-icons

1340035831000000 1341501320000000
#2564 enhancement aron.carroll shevski demo phase 1 closed fixed Updates to additional info fields on datasets

E.g. http://s031.okserver.org:2375/en/dataset/adur_district_spending/resource/04127ad5-77e5-4a08-9f40-12d3c383e460

When there are no maintainer/contact details or extra fields we should hide the additional info box completely. Otherwise hide the last updated and licence fields which are already displayed in sidebar.

Update sidebar to provide context - so 'CSV' -> 'CSV format' + 'unknown' -> 'Last updated: unknown'

1340038534000000 1340118952000000
#2565 enhancement aron.carroll shevski demo phase 1 closed fixed Social links to open in new tab/JS lightbox

Share this (twitter/fb) links open in new tab (no JS) or nice lightbox of some description in demo

1340039322000000 1340116053000000
#2566 enhancement toby shevski demo phase 1 closed fixed add back buttons to create dataset process 1340039366000000 1340373308000000
#2567 enhancement aron.carroll shevski demo phase 1 closed fixed remove resource type field from add data step

No real need/use for this for demo/ODS yet

1340039447000000 1340120447000000
#2568 enhancement aron.carroll shevski ckan-sprint-2012-06-25 closed fixed Crop/shorten titles in breadcrumb headings

So that they don't interfere with buttons such as here: http://s031.okserver.org:2375/en/dataset/afterfibre/resource/5d19f9fa-c5a4-426c-84de-c624d6e8c3b3

1340039534000000 1340108132000000
#2569 enhancement toby shevski demo phase 2 closed fixed add other resources to sidebar of resource pages

Allow user to navigate directly from one resource page to another via resource box in sidebar

1340039608000000 1342085235000000
#2570 enhancement aron.carroll shevski ckan-sprint-2012-06-25 closed fixed add 'back to dataset' button to resource pages

Suggest making this consistent with http://s031.okserver.org:2375/dataset/adur_district_spending/related by adding same button in top right of resource pages

1340039680000000 1340107841000000
#2571 enhancement kindly toby demo phase 1 closed fixed implement logic.action.create.resource_create()

This function is incomplete

If you want I can do this but I need guidance over how to do this properly. ie would I go through lib.dictization.model_save.package_resource_list_save() which looks wrong to me as I'd need the package. resource_dict_save() seems better but to be honest the total lack of docstrings etc makes me feel ill.

1340102259000000 1340369783000000
#2574 enhancement kindly toby demo phase 1 closed fixed look at package states

we want to be able to add new datasets but not have them indexed or seem by people

is the vdm.state the place to do this

1340115771000000 1342092416000000
#2575 enhancement toby amercader ckan-v1.9 closed fixed Licenses have i18n issues (was Inconsistent language on license dropdown)

License titles at least for some of them need translating. This wants to be done in a more efficient and simple manner than currently exists.

the original problem was:

The license dropdown on the dataset form shows titles in Swedish by default. Changing the language seems to default to English, but after refreshing the page a couple of times it shows a wrong language again.

Thanks to pudo for reporting.

1340125845000000 1343216544000000
#2576 enhancement aron.carroll toby demo phase 1 closed fixed resource side box in dataset resource view broken

assuming you have datahub data

http://localhost:5000/en/dataset/2008_facility_ghg_emissions_by_province_territory/resource/28650645-8878-4826-9405-f20b9dfa4c12

also the breadcrumb becomes overly long too

1340199857000000 1340617688000000
#2577 enhancement ross ross ckan-v1.9 closed fixed Dataproxy raises 500 when it can't get CSV

When given a url parameter for a file it cannot fetch, the app raises a 500 instead of something useful.

Better error reporting in the JSON would be useful

1340207124000000 1346669735000000
#2578 defect toby toby demo phase 4 closed fixed demo theme breaks the tests

The demo branch fails huge numbers of tests.

many are going to be template based - these need to be sorted - ideally we need to get them to work with legacy/new templates but see how we go on that one

anyhow this is not a priority whilst we are branched but needs resolving before we merge into master

1340276924000000 1347901892000000
#2580 enhancement kindly toby demo phase 1 closed fixed create resource validation

david I've got the add resource working but it is happy to add empty resources which implies that it isn't doing validation correctly.

I'm not sure what the validation rules are so hard to test this - I'm coming through as an api call

let me know if i can help

1340285208000000 1342092353000000
#2581 enhancement toby toby demo phase 2 closed fixed allow state = 'draft'

pass some stuff through the context

1340287298000000 1342074635000000
#2584 enhancement aron.carroll toby demo phase 1 closed fixed edit profile needs new theme

http://localhost:5000/user/edit/<my user name>

1340359925000000 1340620576000000
#2586 enhancement toby toby demo phase 1 closed fixed edit dataset - tags broken

tags is list not string

1340361630000000 1340380561000000
#2587 enhancement shevski toby demo phase 1 closed fixed author/maintainer not shown if email missing

is this the expected behaviour seems crap to me, should we just see the author but just no link

1340369450000000 1340376975000000
#2588 enhancement toby toby demo phase 1 closed fixed search index for new package

when package is added it does not seem to get indexed

1340373145000000 1340817441000000
#2589 enhancement toby toby demo phase 2 closed fixed users can view draft datasets

need to add some logic for this

1340373194000000 1342172694000000
#2591 enhancement toby toby ckan-v1.8 closed fixed postgres unicode problems postgres v9.1.4

sqlalchemy fails on postgres 9.1.4 when unicode is returned

see http://docs.sqlalchemy.org/en/rel_0_7/dialects/postgresql.html

1340627776000000 1340813161000000
#2592 enhancement seanh seanh ckan-v1.8 closed fixed Update and simplify source install instructions

Make the same instructions work for Ubuntu Lucid and Precise and make them simpler

Also see #1471

1340633697000000 1341234947000000
#2593 enhancement johnglover johnglover ckan-ecportal closed fixed Setup nginx caching for EC ODP

Add caching config to ecportal-server-setup repository.

1340638428000000 1340721249000000
#2594 enhancement johnglover johnglover ckan-ecportal closed fixed Add EU27 to EC ODP geographical coverage field

EU27 option seems to have been removed at some point, needs to be added back to geographical coverage vocabulary and tested.

1340638576000000 1340716640000000
#2595 enhancement toby aron.carroll demo phase 2 closed fixed Demo add dataset needs to remember which stages have been visited

For example.

  1. Start on stage one
  2. Add dataset click next
  3. Click previous

Expect Stage 1 to be "active", stage two to be "complete"

  1. Start on stage one
  2. Add dataset click next
  3. Click next
  4. Click previous

Expect Stage 2 to be "active", stage one and three to be "complete"

  1. Start on stage one
  2. Add dataset click next
  3. Click next
  4. Click previous
  5. Click previous

Expect Stage 1 to be "active", stage two and three to be "complete"

1340642246000000 1342086346000000
#2596 enhancement toby aron.carroll opendatasuite 1 closed fixed Create demo extension

Should have all supported extensions enabled, those that don't work should be disabled and ticketed. Also needs a customised homepage.

1340642315000000 1345209485000000
#2597 enhancement toby aron.carroll demo phase 1 closed fixed Demo add dataset throws error if tags are empty
  1. Go to new dataset
  2. Add a slug
  3. Click next

Get error.

URL: http://localhost:5000/dataset/new
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/weberror/evalexception.py', line 431 in respond
  app_iter = self.application(environ, detect_start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/dec.py', line 147 in __call__
  resp = self.call_func(req, *args, **self.kwargs)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/dec.py', line 208 in call_func
  return self.func(req, *args, **kwargs)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/fanstatic/publisher.py', line 234 in __call__
  return request.get_response(self.app)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/request.py', line 1053 in get_response
  application, catch_exc_info=False)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/request.py', line 1022 in call_application
  app_iter = application(self.environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/dec.py', line 147 in __call__
  resp = self.call_func(req, *args, **self.kwargs)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/dec.py', line 208 in call_func
  return self.func(req, *args, **kwargs)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/fanstatic/injector.py', line 52 in __call__
  response = request.get_response(self.app)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/request.py', line 1053 in get_response
  application, catch_exc_info=False)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/request.py', line 1022 in call_application
  app_iter = application(self.environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/beaker/middleware.py', line 73 in __call__
  return self.app(environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/beaker/middleware.py', line 152 in __call__
  return self.wrap_app(environ, session_start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/routes/middleware.py', line 130 in __call__
  response = self.app(environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/pylons/wsgiapp.py', line 125 in __call__
  response = self.dispatch(controller, environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/pylons/wsgiapp.py', line 324 in dispatch
  return controller(environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/src/ckan/ckan/lib/base.py', line 258 in __call__
  res = WSGIController.__call__(self, environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/pylons/controllers/core.py', line 221 in __call__
  response = self._dispatch_call()
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/pylons/controllers/core.py', line 172 in _dispatch_call
  response = self._inspect_call(func)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/pylons/controllers/core.py', line 107 in _inspect_call
  result = self._perform_call(func, args)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/pylons/controllers/core.py', line 60 in _perform_call
  return func(**args)
File '/Users/Aron/.virtualenvs/ckan/src/ckan/ckan/controllers/package.py', line 422 in new
  return self._save_new(context)
File '/Users/Aron/.virtualenvs/ckan/src/ckan/ckan/controllers/package.py', line 703 in _save_new
  return self.new(data_dict, errors, error_summary)
File '/Users/Aron/.virtualenvs/ckan/src/ckan/ckan/controllers/package.py', line 430 in new
  data['tag_string'] = ', '.join(h.dict_list_reduce(c.pkg_dict['tags'], 'name'))
TypeError: string indices must be integers, not str
1340642399000000 1340644591000000
#2598 enhancement aron.carroll toby demo phase 1 closed fixed stages css broken in FF

I see X where none should be

1340708102000000 1341218567000000
#2599 enhancement johnmartin aron.carroll demo phase 4 closed fixed Test in IE

can we promote this to phase 3?

1340717662000000 1346756230000000
#2600 defect seanh seanh ckan-v1.8 closed fixed Replace broken "Login to Add an Organization" button

If you're not logged in and you click this button, it takes you to the add group page not the login page. Anyway, the default behaviour everywhere else in CKAN is to hide buttons that you don't have permission to use (e.g. add dataset, edit dataset, etc.)

1340721718000000 1340791910000000
#2601 defect ross seanh closed fixed 500 Server Error when editing datasets with organizations plugins enabled

Add the organizations and organizations_dataset plugins to ini file, run ckan, login, create an organization, create a dataset and put in organization, edit the dataset and set organization to none, try to edit the dataset again (you must be sysadmin to do this) and get a 500:

Error - <class 'genshi.template.eval.UndefinedError'>: [] has no member named "get"
URL: http://127.0.0.1:5000/dataset/edit/fooset
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/weberror/errormiddleware.py', line 162 in __call__
  app_iter = self.application(environ, sr_checker)
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/beaker/middleware.py', line 73 in __call__
  return self.app(environ, start_response)
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/beaker/middleware.py', line 155 in __call__
  return self.wrap_app(environ, session_start_response)
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/routes/middleware.py', line 130 in __call__
  response = self.app(environ, start_response)
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/pylons/wsgiapp.py', line 125 in __call__
  response = self.dispatch(controller, environ, start_response)
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/pylons/wsgiapp.py', line 324 in dispatch
  return controller(environ, start_response)
File '/home/seanh/Projects/ckan/ckan/ckan/lib/base.py', line 221 in __call__
  res = WSGIController.__call__(self, environ, start_response)
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/pylons/controllers/core.py', line 221 in __call__
  response = self._dispatch_call()
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/pylons/controllers/core.py', line 172 in _dispatch_call
  response = self._inspect_call(func)
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/pylons/controllers/core.py', line 107 in _inspect_call
  result = self._perform_call(func, args)
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/pylons/controllers/core.py', line 60 in _perform_call
  return func(**args)
File '/home/seanh/Projects/ckan/ckan/ckan/controllers/package.py', line 499 in edit
  extra_vars=vars)
File '/home/seanh/Projects/ckan/ckan/ckan/lib/base.py', line 148 in render
  return cached_template(template_name, render_template, loader_class=loader_class)
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/pylons/templating.py', line 249 in cached_template
  return render_func()
File '/home/seanh/Projects/ckan/ckan/ckan/lib/base.py', line 101 in render_template
  return literal(stream.render(method=method, encoding=None, strip_whitespace=True))
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/core.py', line 183 in render
  return encode(generator, method=method, encoding=encoding, out=out)
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/output.py', line 57 in encode
  return _encode(''.join(list(iterator)))
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/output.py', line 339 in __call__
  for kind, data, pos in stream:
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/output.py', line 670 in __call__
  for kind, data, pos in stream:
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/output.py', line 771 in __call__
  for kind, data, pos in chain(stream, [(None, None, None)]):
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/output.py', line 586 in __call__
  for ev in stream:
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/core.py', line 288 in _ensure
  for event in stream:
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/template/base.py', line 605 in _include
  for event in stream:
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/template/markup.py', line 327 in _match
  for event in stream:
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/template/base.py', line 545 in _flatten
  for kind, data, pos in stream:
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/template/directives.py', line 169 in _generate
  attrs = _eval_expr(self.expr, ctxt, vars)
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/template/base.py', line 277 in _eval_expr
  retval = expr.evaluate(ctxt)
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/template/eval.py', line 178 in evaluate
  return eval(self.code, _globals, {'__data__': data})
File '/home/seanh/Projects/ckan/ckan/ckanext/organizations/templates/organization_package_form.html', line 110 in <Expression u"{'selected':'selected'} if organization.get('id','') == group['id'] else {}">
  <option value="${group['id']}" py:attrs="{'selected':'selected'} if organization.get('id','') == group['id'] else {}">${group['title']}</option>
File '/home/seanh/Projects/ckan/ckan/ckan/config/environment.py', line 248 in genshi_lookup_attr
  val = cls.undefined(key, owner=obj)
File '/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/genshi/template/eval.py', line 410 in undefined
  raise UndefinedError(key, owner=owner)
UndefinedError: [] has no member named "get"
1340722754000000 1341291379000000
#2602 defect seanh closed fixed Users can set a dataset's organization to None, and then they cannot edit it

With the organizations and organizations_dataset plugins enabled login and create a new dataset, adding it to a group that you are a member of. Edit the dataset and set the group to none. Now you can no longer edit your own dataset. (You can also specify None for the organization when first creating the dataset, same problem.)

1340722892000000 1340805904000000
#2604 enhancement amercader amercader ckan-v1.8 closed fixed Add Requests as requirement for tests

Requests (http://python-requests.org) is really useful to deal with http requests and saves a lot of time.

I propose we include it as a requirement for the tests for the time being, and even for core if necessary at a later stage.

1340790229000000 1340968458000000
#2605 enhancement ross ross ckan-v1.8 closed fixed Problem with user.get_groups

From DR at DGU

Basically get_groups() appears to cache its results, but this falls down when subsequent calls are in a different session. We get this when saving a dataset. get_groups() first gets called in the controller when it is trying to work out what permissions the user has. It later gets called, and by this time c.userobj is detached, so get_groups() fails.

I'm working around this by refreshing c.userobj (from c.user) before calling get_groups(), but I wonder if the get_groups caching could detect the detached session and bypass the cache in this case?

diff at https://gist.github.com/3003117

1340793006000000 1343127369000000
#2606 enhancement toby toby demo phase 1 closed fixed make fanstatic use full path

ckan/main not main

1340795985000000 1340799139000000
#2609 enhancement toby aron.carroll opendatasuite 1 closed fixed Demo theme errors when creating a dataset without a resource
  1. Complete step one of add dataset
  2. Click next without adding any resource data.

Page errors.

URL: http://localhost:5000/dataset/new_resource/asdasd
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/weberror/evalexception.py', line 431 in respond
  app_iter = self.application(environ, detect_start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/dec.py', line 147 in __call__
  resp = self.call_func(req, *args, **self.kwargs)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/dec.py', line 208 in call_func
  return self.func(req, *args, **kwargs)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/fanstatic/publisher.py', line 234 in __call__
  return request.get_response(self.app)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/request.py', line 1053 in get_response
  application, catch_exc_info=False)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/request.py', line 1022 in call_application
  app_iter = application(self.environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/dec.py', line 147 in __call__
  resp = self.call_func(req, *args, **self.kwargs)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/dec.py', line 208 in call_func
  return self.func(req, *args, **kwargs)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/fanstatic/injector.py', line 52 in __call__
  response = request.get_response(self.app)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/request.py', line 1053 in get_response
  application, catch_exc_info=False)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/webob/request.py', line 1022 in call_application
  app_iter = application(self.environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/beaker/middleware.py', line 73 in __call__
  return self.app(environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/beaker/middleware.py', line 152 in __call__
  return self.wrap_app(environ, session_start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/routes/middleware.py', line 130 in __call__
  response = self.app(environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/pylons/wsgiapp.py', line 125 in __call__
  response = self.dispatch(controller, environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/pylons/wsgiapp.py', line 324 in dispatch
  return controller(environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/src/ckan/ckan/lib/base.py', line 258 in __call__
  res = WSGIController.__call__(self, environ, start_response)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/pylons/controllers/core.py', line 221 in __call__
  response = self._dispatch_call()
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/pylons/controllers/core.py', line 172 in _dispatch_call
  response = self._inspect_call(func)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/pylons/controllers/core.py', line 107 in _inspect_call
  result = self._perform_call(func, args)
File '/Users/Aron/.virtualenvs/ckan/lib/python2.7/site-packages/pylons/controllers/core.py', line 60 in _perform_call
  return func(**args)
File '/Users/Aron/.virtualenvs/ckan/src/ckan/ckan/controllers/package.py', line 495 in new_resource
  get_action('resource_create')(context, data)
File '/Users/Aron/.virtualenvs/ckan/src/ckan/ckan/logic/action/create.py', line 240 in resource_create
  raise ValidationError(errors, _error_summary(errors))
ValidationError: {u'URL': u'Missing value'}

http://localhost:5000/dataset/new_resource/asdasd

1340810211000000 1340900271000000
#2611 enhancement aron.carroll shevski demo phase 1 closed fixed Text / link changes

In the footer: Change 'Powered by CityData?' to Powered by DataSuite? (with link to ckan.org/datasuite)

Links in left hand side of footer should change to a link to ckan.org, link to OKFN, link to ckan.org/datasuite/about and link to Pricing Page (on ckan.org .. will be /datasuite/solutions)

In create dataset form, prefilled tag examples should include one example with a space, e.g. "mental health"

Change 'Groups' to 'Publishers' everywhere

Homepage copy/images (Ira to supply?)

1340810740000000 1342008509000000
#2612 enhancement shevski shevski demo phase 2 closed fixed Hide options based on auth

For example, hide the 'edit' button on user profiles http://s031.okserver.org:2375/user/ross2#activity unless I'm logged in as Ross

1340812165000000 1342714613000000
#2614 enhancement aron.carroll toby demo phase 3 closed fixed improve the documentation around less/node

needs to move to a better home

better ubuntu install instructions plus test they work

apt-get install nodejs

integrate with paster

1340815928000000 1343685572000000
#2615 enhancement seanh seanh ckan-v1.8 closed fixed Add activity stream activity when a user starts to follow something 1340874249000000 1341235002000000
#2617 enhancement aron.carroll aron.carroll demo phase 2 closed fixed Move data preview into demo 1340875192000000 1342088744000000
#2618 enhancement toby toby demo phase 4 closed fixed allow nested js resources 1340878063000000 1347901864000000
#2620 enhancement toby aron.carroll demo phase 2 closed fixed Pass a related item into the dataset tempate

See the related sidebar box

http://s031.okserver.org:2375/dataset/adur_district_spending

If a package has related items the first (or a random) related item should be passed into the snippet.

1340897809000000 1342074737000000
#2624 enhancement ross seanh ckan-v1.8 closed fixed Organizations breaks dataset tag editing

Enable the organizations and organizations_dataset plugins, login to ckan, create a group, create a dataset and add it to the group. Edit the dataset, add some tags to it. The new tags are not saved when you submit.

Disable the organizations and organizations_dataset plugins and tag editing works again.

1341226411000000 1341831716000000
#2627 defect seanh seanh ckan-v1.8 closed fixed IDatasetForm.form_to_db_schema() is not called

IDatasetForm's form_to_db_schema() method is not getting called by ckan

1341576508000000 1343125213000000
#2631 enhancement johnmartin aron.carroll demo phase 5 closed fixed Style activity stream in user profile 1341826342000000 1352205778000000
#2632 enhancement toby toby ckan-v1.9 closed fixed check allowed helpers exist

in lib helpers make sure the allowed function lists functions exist or throw an error.

1341827811000000 1342087027000000
#2633 enhancement toby toby demo phase 2 closed fixed for dev always look for templates

so we find newly created templates

1341828058000000 1341830278000000
#2634 enhancement toby toby ckan-v1.8 closed fixed change log - helper function limited in 1.8

make sure documented

1341828248000000 1342085656000000
#2637 enhancement aron.carroll aron.carroll demo phase 2 closed fixed Submit search form when user changes sort order 1341835218000000 1342617226000000
#2638 enhancement toby toby ckan-v1.8 closed fixed add a get from request param helper function 1341844597000000 1342112772000000
#2639 enhancement amercader amercader ckan-v1.8 closed fixed Update recline version for 1.8 release

New recline version has significant improvements like the SlickGrid? based grid view, it'd be good to have it on 1.8.

1341845809000000 1350296205000000
#2640 enhancement amercader amercader demo phase 2 closed fixed Update recline on the demo site

Depends on #2639

1341845911000000 1342112730000000
#2642 enhancement shevski amercader demo phase 3 closed fixed Adapt harvest frontend to new theme 1341846196000000 1345113645000000
#2643 enhancement aron.carroll aron.carroll demo phase 2 closed fixed Demo homepage redesign

Discussion:

https://okfn.basecamphq.com/projects/9558659-demo-ckan-front-end/posts/61696765/comments

1341848685000000 1342617247000000
#2645 enhancement johnglover johnglover ckan-ecportal closed fixed Update server setup to use local files

Server setup scripts need to have two distinct steps:

1) Download all files that aren't in RHEL repositories, create RPMs where necessary (python virtualenv).

2) Install from local files.

1341916281000000 1341996302000000
Note: See TracReports for help on using and creating reports.