{23} Trac comments (3729 matches)

Results (1501 - 1600 of 3729)

Ticket Posixtime Author Newvalue
#1107 1320321170000000 dread Notes to complete this: * ckan/logic/action/get.py:'def package_autocomplete' exists and is the one that should be used * need to ensure all places in the templates and public/scripts use this action directly, not dataset/autocomplete (or its alias package/autocomplete) * ckan/controllers/package.py:'def autocomplete' should be removed. * ckan/config/routes.py dataset/autocomplete should be removed.
#1442 1320275623000000 dread Fixed in cset:819a74bd1c03 for release 1.5. Note release 1.5 doesn't have #1381 feature, so you're not supposed to create with groups anyway, but this will be useful if people try it.
#1436 1320243278000000 johnglover Fixed in branch feature-1371-task-status-logic-layer, will merge with default after 1.5 release later today.
#1440 1320235084000000 dread I've done this. 'db load' now also does 'db upgrade' and 'search-index rebuild'. If you want to debug the load (or don't need the search index, cos it takes ages to do), then you can just do 'db load-only' which does what 'db load' did before. Changed in cset:9e51df5c496b for 1.5 release.
#1441 1320235062000000 dread Fixed in cset:35542f1c60a2 for release 1.5.
#1436 1320230896000000 johnglover This also applies to CKAN core
#1034 1320174353000000 dread Same problem as #1321 I believe
#1373 1320174240000000 dread Squid force caching is now turned off on the main page, and etags sorted out in #1388.
#1388 1320174229000000 dread Etags fixed in cset:a3c8d4f7cf91 for release 1.5.
#1437 1320173795000000 dread Fixed in cset:5d0bf20a1746 for 1.5. Broken since 1.4.3.
#1315 1320173768000000 dread Tidied up in cset:39daf1afd64a for release 1.5.
#1437 1320173496000000 dread This can be fixed with one line of code, so I'm doing it for release 1.5.
#1379 1320161439000000 zephod actually here: https://bitbucket.org/okfn/ckan/changeset/607f3363a8c5
#1379 1320155927000000 zephod Resolved in cset:af694663f30e Now allowing markdown to do its thing, then fixing remaining links afterwards. More success that way.
#1393 1320153590000000 dread Thanks John, reassigning to you for the future.
#1416 1320153507000000 dread This seems to have been fixed in #1229. Added a test for this cset:5d6a3e50fe8f on default to demonstrate it displays a validation error, as rgrp suggests. Note, this ticket is about spammers missing some of the form fields, rather than any normal user usage, where the browser sends all the fields whether you fill them or not.
#1405 1320152291000000 dread Fixed in cset:e68926926bee for release 1.5. David looked for duplicates on thedatahub.org and found one - http://thedatahub.org/group/lodcloud with http://thedatahub.org/dataset/didactalia. I fixed that by opening the dataset, editing, saving.
#891 1320149841000000 johnglover Added cache_url and cache_last_updated to resources after archiving. Not checking for hash value in headers. This process will generally only run when a new resource is added or someone updates a URL, so we don't expect to be regularly downloading the same resource. We will need something along these lines if this is running as a regular cron job, but in that case the logic will be added to the cron job itself (probably a paster command).
#1292 1320145732000000 dread These fixes all went into release 1.5.
#1292 1320145677000000 dread Review process of releases and updating strings (pot) and translations (po) files c.f. http://lists.okfn.org/pipermail/ckan-dev/2011-May/000718.html http://wiki.ckan.net/Release_process updated with basic process Get language changing thing to get home page to mostly work - push to key strings translated (or don't advertise the translation?) Welcome message is translated in all languages. Most language have upped their percentage translated significantly and Swedish and Polish added as well. Review long list of strings for improvement Consolidate any? Get rid of i18n for strings in api About 50% of the strings are templates, 30% are in the logic layer and 20% are in the controllers. Removed a handful from ckan/lib/base.py that were only displayed in the api, but the logic layer ones are generally errors that can be displayed in the Web UI as well as the API, so not ideal to remove. Try and remove javascript Tom did this. Add in extensions This could be done. Have raised ticket #1292 for this, next release. #1374 Fix switching to en from other default language Done #1417 Fix browser language detection Done
#1190 1320143592000000 rgrp A very substantial portion of this got done as part of 0.5 including the webstore #1208 and the majority of automated conversion #1398. #1432 is currently deferred so we're going to close this ticket on basis that item (3) is now out of scope.
#891 1320143424000000 johnglover Almost finished (see http://github.com/okfn/ckanext-archiver). Still to address: - check headers to see if hash / cache / max-age / expires indicates that the resource does not need to be downloaded. - add cache url to resource
#954 1320142744000000 kindly This is basically the complete now with documentation. The child tickets no longer seem to fit and are not essential for completion.
#1401 1320142359000000 rgrp Hi, this is very useful to hear. Can you point out links or even better submit a patch / pull request: http://wiki.ckan.org/Submitting_a_code_patch
#1387 1320142210000000 rgrp This won't happen in v1.5.
#1408 1320141847000000 kindly fixed cset:51c7d51f3c17
#1383 1320141781000000 kindly fixed cset:ecfb0f8b633c
#1431 1320084104000000 dread Fixed in cset:711a68a12d90 for release 1.5.
#1365 1319815052000000 dread Done on defect-1365-search-params for 1.5. No official releases exist with this broken
#1275 1319812967000000 dread Going into release 1.5.
#1256 1319812556000000 dread It sounds like this became an issue with CKAN 1.4.3 and the fix goes into CKAN 1.5.
#1258 1319812452000000 dread I believe this was broken with the introduction of moderated edits in CKAN 1.4.3 and this fix went into 1.5.
#816 1319812324000000 dread And branch feature-816-format-autocomplete
#1428 1319804773000000 dread Fixed in a3b0080467d4 for release 1.5
#816 1319804698000000 dread John did this in cset:1697dfa2552c for release 1.5
#1334 1319798961000000 dread I think this has been a problem since 1.3.3. Fixed in v1.5.
#1248 1319797763000000 dread Fixed in cset:188d27a56c89c35f97f3a79fdd0a6460223f86cf on branch release-v1.4.3. This was only seen in CKAN 1.4.3beta.
#1077 1319797284000000 dread I guess this is not a priority now.
#1306 1319797204000000 dread These are expressed as functional API tests - see tests/functional/api/test_action.py. There's not a lot of difference (apart from Paste coming in there) so no real need to duplicate API and logic layer tests, or to switch them to talk directly to the logic layer.
#1419 1319795920000000 dread This seems to work better today...! myopenid works for me fine with my existing account and by reregistering. My google id works only if I reregister, and I think that is because I hadn't registered before. Closing.
#1416 1319794595000000 rgrp In normal user submission this would result in errors reported and no 500. Happy to have this switch to 400 if you think this is a good idea.
#1300 1319794520000000 rgrp Side bar menu is switchable (though not sure how -- zephod has done this!) CSS tidying and labelling of divs done in #1380. So closing!
#1408 1319794384000000 rgrp Suggest that going forward we always boot a site user with the same id as site id (which we may want to leave ckan.site_id blank and force user to choose this going forward?) and give it a password. May need migration or instructions in UPGRADE.txt for existing users.
#1425 1319735012000000 dread Cheers for taking this on Tom
#737 1319730303000000 dread Something like this one on github: {{{ # This is an <h1> tag ## This is an <h2> tag ###### This is an <h6> tag Text styles *This text will be italic* _This will also be italic_ **This text will be bold** __This will also be bold__ *You **can** combine them* Lists Unordered * Item 1 * Item 2 * Item 2a * Item 2b Ordered 1. Item 1 2. Item 2 3. Item 3 * Item 3a * Item 3b Miscellaneous Images ![GitHub Logo](/images/logo.png) Format: ![Alt Text](url) Links http://github.com - automatic! [GitHub](http://github.com) Blockquotes As Kanye West said: > We're living the future so > the present is our past. }}}
#843 1319721601000000 dread Ok I misunderstood this ticket. This is referring to adding a user in e.g. http://thedatahub.org/group/authz/energy-data This UI seems to be updated. You start typing the name, full name or open id of the person and it has a dropdown that autocompletes. This seems to be sufficient for Will's points 1 and 3. Would be still good to have a flash message on account creation to encourage people to add personal their Full name. This is similar to #1413 so I'll close this ticket and add it there.
#843 1319710380000000 dread * "we should show the openid as well to distinguish between users with the same name." - when "Full name" is not distinguishable, maybe best to display the unique 'name' field as a hover-over. * "on account creation, the user should be redirected to their personal details page to encourage them to fill in a human readable name." - yes you always got take to the personal details page. We should use a flash message at this point if they have not filled in the "Full name" field to suggest they click edit and do this. * "List is to long" - this has been addressed - see http://thedatahub.org/user
#1341 1319709997000000 dread Reopening - this is still a serious problem. We can't link to the user page because it is so embarrassing: http://thedatahub.org/user
#1427 1319709925000000 dread Done in cset:ec9a9efc2d40 for release 1.5
#253 1319709714000000 dread Closed by mistake
#1426 1319709236000000 dread Reading http://www.checkupdown.com/status/E409.html I've changed my mind - 409 is ok for an application level validation error.
#1417 1319651617000000 dread Fixed in branch defect-1418-i18n for release 1.5.
#1341 1319649573000000 dread The majority of our 6000 users are still spammers. Can we simply elimenate those who've not made any revisions? Even if we take a few genuine users with it, these are pretty dead accounts anyway.
#1374 1319648726000000 dread This is fixed in branch defect-1418-i18n for release 1.5
#1229 1319645778000000 dread Replace code in home in cset:f19f9c5bec94 on default for release 1.5.1.
#1422 1319645722000000 dread Done in cset:54fc460602d2 on default for 1.5.1 release.
#1229 1319639472000000 dread I found another direct use of the d.b. in the home controller.
#1421 1319639311000000 dread Fixed in cset:109db2176fac for 1.5 release.
#1380 1319627454000000 zephod https://bitbucket.org/okfn/ckan/changeset/f600e0d37f6c
#1392 1319625243000000 johnglover Now on s054.okserver.org
#1378 1319567698000000 zephod https://bitbucket.org/okfn/ckan/changeset/494bbd08364f
#1409 1319567582000000 zephod https://bitbucket.org/okfn/ckan/changeset/c8c62bc8766d
#1321 1319558004000000 dread We should not cache if there are flash messages to show (otherwise they get queued up for the next non-cached page view). Fixed in cset:945e2a6ce74f for release 1.5
#1419 1319548778000000 rgrp I've successfully logged into thedatahub using my openid. Issues may arise especially with google openid due to changes in site (from ckan.net to thedatahub.org). See: http://lists.okfn.org/pipermail/ckan-dev/2011-October/001384.html
#1373 1319542883000000 dread I think this is due to the etags cache not taking into account whether you are logged in. So the page is cached by squid (which is why it's not seen anywhere apart from thedatahub.org).
#1418 1319539691000000 dread Same as #1374
#1415 1319457583000000 nils.toedtmann Arww ... sorry i only now rediscovered James' mail "CKAN Packaging" from Sept 29th where he announced the availability of the repository http://apt.okfn.org/ckan- . This package release already addresses many of the above points. I will test those packages and refine my comments then. Sorry for the noise.
#1383 1319405579000000 kindly We only added the Iresourceurlchange interface as we made the IDomainObjectModification include the Package.
#1409 1319306802000000 rgrp What do we do for people without email addresses (no gravatar or a standard anonymous one?)
#1379 1319306665000000 rgrp This is minor but a real bug (seen now in several datasets). As easy to fix suggest bumping and trying to get into v1.5 (?).
#1410 1319213205000000 zephod Oops: #1409 double posted.
#1381 1319021092000000 amercader Now implemented on 6227142b0460
#1141 1318862773000000 johnglover Well, it runs on datacatalogs.org with the current default so CKAN 1.5, but it needs quite a bit of updating to work with all of the new 1.5 UI changes, and as it has been a low priority for quite a while I haven't scheduled time to work on it. Really I would need to spend a few days on it to tidy it up for standard 1.5.
#1141 1318862183000000 dread What's the status of this now? The ckanext-moderatededits README still says you need a branch of ckan. Can you say which version of CKAN is required instead? I say we close this if ajax call is now in a better place in the API. (I expect it is now, with the logic layer).
#891 1318602128000000 rgrp May only do link-checker and not do full storage in this sprint.
#890 1318599247000000 kindly Invalid due to #1397, We will be using celery instead.
#890 1318529648000000 rgrp May want to close as invalid as obsoleted by more recent queue work.
#1065 1318528721000000 rgrp Reassigning to zephod as he is looking at this. I think most of this is wontfix or will become obsolete with other stuff but worth looking at. Also moving to v1.6 at the same time.
#1383 1318528301000000 rgrp Just to check: I thought conclusion was we do not need IResourceUrlChanged since we would only do archiving for newly created resources?
#1343 1318528138000000 rgrp Remove from ckan-v1.5 since remaining non-complete items (user page improvements and modal login won't get done in v1.5.
#1319 1318527613000000 rgrp Fixed in https://bitbucket.org/okfn/ckan/changeset/130cad62163c
#1386 1318527591000000 rgrp Fixed in https://bitbucket.org/okfn/ckan/changeset/130cad62163c
#1395 1318525201000000 dread This problem is mentioned here: http://docs.ckan.org/en/latest/test.html but you're right, it really should be solved in the install instructions.
#1395 1318520543000000 seanh The exact command that introduced the too-new webob into my virtualenv was: {{{ pip install --ignore-installed -r pyenv/src/ckan/requires/lucid_missing.txt -r pyenv/src/ckan/requires/lucid_conflict.txt }}}
#1393 1318508765000000 johnglover Yes, there are a few of these problems with SQLite which is why the tests are being skipped currently. I'm not exactly sure of the reason, it seems that it sometimes drops tables from memory, but we haven't found a solution. Myself and David Raznick were going to spend some time looking at it but haven't had a chance yet.
#1393 1318505854000000 dread I changed this: {{{ diff -r 47657581fc30 ckan/tests/__init__.py --- a/ckan/tests/__init__.py Wed Oct 12 17:58:19 2011 +0100 +++ b/ckan/tests/__init__.py Thu Oct 13 12:29:54 2011 +0100 @@ -373,7 +373,7 @@ plugins.load('synchronous_search') def is_search_supported(): - supported_db = "sqlite" not in config.get('sqlalchemy.url') + supported_db = True return supported_db def is_regex_supported(): }}} But there seems to be a problem finding the package when trying to index it: {{{ ====================================================================== ERROR: test suite for <class 'ckan.tests.functional.test_search.TestSearch'> ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/nose/suite.py", line 208, in run self.setUp() File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/nose/suite.py", line 291, in setUp self.setupContext(ancestor) File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/nose/suite.py", line 314, in setupContext try_run(context, names) File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/nose/util.py", line 478, in try_run return func() File "/home/dread/hgroot/ckan/ckan/tests/functional/test_search.py", line 21, in setup_class CreateTestData.create_search_test_data() File "/home/dread/hgroot/ckan/ckan/lib/create_test_data.py", line 66, in create_search_test_data cls.create_arbitrary(search_items) File "/home/dread/hgroot/ckan/ckan/lib/create_test_data.py", line 197, in create_arbitrary model.repo.commit_and_remove() File "/home/dread/hgroot/pyenv-ckan/src/vdm/vdm/sqlalchemy/tools.py", line 110, in commit_and_remove self.commit() File "/home/dread/hgroot/pyenv-ckan/src/vdm/vdm/sqlalchemy/tools.py", line 100, in commit self.session.commit() File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/sqlalchemy/orm/scoping.py", line 139, in do return getattr(self.registry(), name)(*args, **kwargs) File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/sqlalchemy/orm/session.py", line 614, in commit self.transaction.commit() File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/sqlalchemy/orm/session.py", line 385, in commit self._prepare_impl() File "/home/dread/hgroot/pyenv-ckan/lib/python2.6/site-packages/sqlalchemy/orm/session.py", line 361, in _prepare_impl ext.before_commit(self.session) File "/home/dread/hgroot/ckan/ckan/model/extension.py", line 103, in before_commit methodcaller('before_commit', session) File "/home/dread/hgroot/ckan/ckan/model/extension.py", line 38, in notify_observers func(observer) File "/home/dread/hgroot/ckan/ckan/model/modification.py", line 45, in before_commit self.notify(obj, DomainObjectOperation.new) File "/home/dread/hgroot/ckan/ckan/model/modification.py", line 70, in notify observer.notify(entity, operation) File "/home/dread/hgroot/ckan/ckan/lib/search/__init__.py", line 93, in notify package_to_api1(entity, {'model': model}), File "/home/dread/hgroot/ckan/ckan/lib/dictization/model_dictize.py", line 231, in package_to_api1 dictized = package_dictize(pkg, context) File "/home/dread/hgroot/ckan/ckan/lib/dictization/model_dictize.py", line 118, in package_dictize raise NotFound NotFound ---------------------------------------------------------------------- Ran 1 test in 2.734s FAILED (errors=1) }}} Any ideas John?
#1387 1318429228000000 dread I'm generally against validation. When doing any bulk import, it either have to ignore validation errors or lose data. If you ignore the errors, you find you can't edit the dataset without correcting the validation error, and you often end up guessing, just to get your other changes in. All in all, I think it is better to nudge users, with javascript pop-ups in the form, or quality scores, rather than hard-and-fast validation.
#1319 1318426807000000 rgrp @dread: hope it is OK to re-assign to me but this is very similar to #1386 (and is a su bticket of #1343)
#1385 1318419159000000 dread Another change needed for this (via Florian): {{{ diff -r 6f27828a4621 ckan/lib/cli.py --- a/ckan/lib/cli.py Wed Oct 12 11:10:32 2011 +0100 +++ b/ckan/lib/cli.py Wed Oct 12 12:23:18 2011 +0100 @@ -132,7 +132,7 @@ pg_cmd += ' -U %(db_user)s' % self.db_details if self.db_details.get('db_pass') not in (None, ''): pg_cmd = 'export PGPASSWORD=%(db_pass)s && ' % self.db_details + pg_cmd - if self.db_details.get('db_host') not in (None, '', 'localhost'): + if self.db_details.get('db_host') not in (None, ''): pg_cmd += ' -h %(db_host)s' % self.db_details if self.db_details.get('db_port') not in (None, ''): pg_cmd += ' -p %(db_port)s' % self.db_details }}}
#1375 1318260008000000 amercader Fixed in 888ed50c098d, using Session.flush() rather than the proposed one.
#1377 1318245795000000 zephod Complete: cset:b216952644aa
#1264 1318245716000000 zephod Complete; cset:b216952644aa
#1264 1318244619000000 zephod Created #1377 to handle bugs revealed while doing this work.
#1364 1318199135000000 kindly fixed cset:294a0b6577b0
#97 1318181317000000 rgrp Duplicate of: https://github.com/okfn/datapkg/issues/5
#100 1318181227000000 rgrp Resolving as wontfix since not really sure any point to this.
#306 1318181194000000 rgrp Duplicate of https://github.com/okfn/datapkg/issues/4
#1369 1318165086000000 rgrp Completed and merged in https://bitbucket.org/okfn/ckan/changeset/e75158acdcfa
#1320 1318164603000000 rgrp Completed in https://bitbucket.org/okfn/ckan/changeset/f9dfb0506594
#1357 1318164458000000 rgrp Completed and merged into default in https://bitbucket.org/okfn/ckan/changeset/9ea072d67245
Note: See TracReports for help on using and creating reports.