{23} Trac comments (3729 matches)

Results (301 - 400 of 3729)

← 1 2 3 4 5 6 7 8 9 10 11 12 13 14 →
Ticket Posixtime Author Newvalue
#2680 1342541256000000 toby we can do anything however in my opinion admin stuff like that should be phase 3 as not/really needed for the demos
#2680 1344509493000000 toby closing this ticket as remaining work too vague undelete group added as #2830
#2681 1343115619000000 toby This should be just `basic` formats csv html xls etc it's for non technical and what we output with the resources
#2689 1342617293000000 toby fixed on s031
#2691 1342541384000000 toby @shevski closing as a duplicate http://trac.ckan.org/ticket/2664 - if you can work out how to get that 404 error please create a new ticket explaining how to reproduce - thanks
#2691 1342604273000000 toby fixed and cherry picked into stable
#2692 1342617328000000 toby fixed on s031
#2698 1343378378000000 toby I think this would be really helpful/nice
#2699 1342788074000000 toby We should look at this next weekish
#2699 1344507133000000 toby @ira, This is probably void now due to yesterdays dev meeting but will keep alive - moving out of phase 3 as not happening anytime soon and dependent on ross's organisation work will probably move to ckan 2.0 milestone
#2700 1343378577000000 toby auto submit done @shevski can you elaborate on the other issues else will close this ticket
#2700 1344245069000000 toby @ira, languages are in their own language Capitalisation is English Imperialism so I think we shouldn't do this
#2700 1344258748000000 toby @aron, re flags it'd be nice to have more as the languages are not so fixed maybe that's too much work for this phase and is more wishlist @shevski, The language capitalisations should be correct they are from babel not us anyhow
#2700 1344358941000000 toby @aron you should have the flags close if complete
#2701 1343949850000000 toby > Would be good to decide on the "one" way to do this. As the new extension guru/deity I say helper functions are the future - my word is the law a) a missing helper just returns '' so they can be added to templates even when not implemented, a missing template gives a 500 b) helper functions hide the implementation which I think is a good thing c) helpers are just soooooooo cool - plus they are new and shiny (what am I saying?) As far as moving the phase I'm not too fussed we can be ahead on phase 4
#2701 1343949913000000 toby track is shit - missing helpers return `''`
#2702 1343378761000000 toby @shevski can you rewrite this tickets so i can understand it - also is this several tickets?
#2703 1342687332000000 toby created on dev branch
#2704 1342707398000000 toby @ira, again not sure this makes sense from a ux perspective @aron, reassign to me if you want it doing should be trivial
#2704 1342710830000000 toby @ira, this isn't really needed then! there is no point doing work if we need to do it again editing resources is easy enough now anyway I suggest we just close this ticket as a won't fix and #2705 as well while we're at it. I'm also not happy about these being added to the phase 2 milestone when we are at the end of finishing it and these are not bugfixes or critical functionality
#2704 1342716968000000 toby need some thought
#2704 1343948227000000 toby @aron, I don't like auto submit as people may think (reasonably) that their changes are discarded. We could catch all clicks and then ask the user if they've changed something but this feels a little crazy - better than the browser dialog. hmmm maybe we should discuss this ticket with the other backlog of undecided/unsure personally I think we need to review the whole edit/view/delete logic as it feels real poor from my perspective - I need to edit something to delete it - that is a wtf imho let's work out what we are doing before wasting energy on this
#2705 1342707341000000 toby @ira, I'm not sure about this if some one is editing a resource moving to edit the dataset seems wrong - a back to resource makes sense to me but not moving to the edit page @aron, If you want this then assign it to me if you're busy
#2705 1342716980000000 toby need some thought
#2706 1342707718000000 toby @aron, I've done this for you
#2707 1344504846000000 toby Formmating done other requests moved to new tickets as low priority for effort needed Title fixes translations etc http://trac.ckan.org/ticket/2822 Ordering of fields http://trac.ckan.org/ticket/2823
#2710 1342779460000000 toby @aron, we need to have this styled a little better when non-js user maybe it needs a little thought so that the lightbox gets a snippet and the non-js user gets the snippet embedded in a page so consisten styling and looks like part of ckan
#2710 1342784018000000 toby @aron I've done this - it needs a bit of work ie breadcrumb and you won't like what I did with the css classes/js- a better solution is needed but this gives a quick example that we can improve on let me know your thoughts https://github.com/okfn/ckan/commit/cec57f36094327611ff9bc8935c061a61ca3e961
#2714 1342706752000000 toby @ira, this isn't a phase 2 item - moving to phase 3 can you view the document when you download it? The message says it thinks it is corrupt
#2714 1342794216000000 toby @aron what was the problem?
#2715 1342716931000000 toby live on s031
#2716 1342716474000000 toby fixed and on s031
#2718 1342785406000000 toby @shevski can you use links to s031 for stuff like this as it is the testing serve and i can play with the data more - unless the error is specific to demo.ckan.org ------------- with this issue it is actually wider than you suggest as I cannot edit the group that the dataset is in either. We need to discuss this one as I don't know the best approach should groups select datasets or datasets groups or both - how do we remove datasets from groups - who can do this etc - maybe next week?
#2718 1342788150000000 toby related to #2699
#2720 1343214149000000 toby minor fix so seems good to do it now
#2721 1343031299000000 toby @ira, this is an issue for sysadmins only - i'll look at it anyhow
#2721 1343037422000000 toby moving to phase 3 a s fundamental ckan issue needs team discussions
#2722 1343036871000000 toby @ira I have disabled the sort order of group datasets in phase 2 as it is totally broken - I'll re-add it in phase 3 Also the comment you made you added bug2 - text covers order by box -PLEASE DO NOT DO THIS - all it does is make the tickets really hard to deal with - if this becomes a habit I will close all such tickets as INVALID as it makes trac unusable for developers - THIS IS REALLY IMPORTANT - cheers @aron, can you watch for feature creep in tickets and let me know if it happens - thanks
#2722 1343062752000000 toby @ira, It is much easier to work with tickets that only cover one thing - If something is found then the easiest thing is to add a new ticket. If you feel it's related to another ticket then you can add that to the new ticket eg related to #1234 If tickets need combining it is easy for us devs to do it. Basically adding something to a ticket is generally a bad thing. Sometimes it's fair enough if something is missing for a new feature being reviewed etc - but even then a new ticket is generally not a problem. Small tickets are nice to work on as we can close them quick etc. The old [super] style tickets have been banned as they generally lead to owners becoming demotivated and unproductive. It's always nice if you can find if a ticket already exists but I don't mind you opening a few duplicates if you can't find the ticket - for the demo you can probably just skim the tickets in the milestones as there aren't too many - but as you know I try to review them quite often. Also please don't reopen really old tickets just add a new one If it's been closed in the last month or so then feel free to re-open if you're sure it's not just waiting for release - you can always check with the last owner of the ticket. hope that makes sense
#2722 1344358667000000 toby @aron, can you re-add the dropdown and sort the overlap issue not sure which template it's in
#2724 1343030687000000 toby 1) this is because it is an incomplete dataset that has not been fully added 2) please explain where you mean - we need a url 3) These should not be seen reassigning to toby
#2725 1343030773000000 toby @ira, This is a ckan issue not demo-theme I think we need a ckan day - wider team to look at many of these style issues
#2726 1343030906000000 toby @ira, I think this is probably linked to the qa plugin and auto detecting formats rather than believing the user.
#2727 1343031501000000 toby i'll do this
#2728 1343031111000000 toby @ira, This is because you are a sysadmin - not sure why ckan does this but i'll look at it with the other group search tickets moving to phase 3 as not a user viewable issue
#2728 1345023944000000 toby Issue with not re-indexing datasets when group is updated - needs proper fix as part of phase 4
#2730 1343031481000000 toby i'll do this
#2730 1343032612000000 toby fixed will put on demo site later today
#2734 1343061727000000 toby Shevski, I think this is an old dataset it works fine with new ones. I think this is a corrupt data issue. also HTML, is fine as a format please reopen if you can reproduce with a dataset that has been created since the update today
#2734 1343063266000000 toby @ira, can you try to work out exactly how to cause this problem starting with `add a dataset` and let me know how you break things tell me all the fields you filled in - also try to get it to happen using as little effort as possible eg add dataset http://s031.okserver.org:2375/dataset/new title = mooooo click next:add data resource = moo format = csv click `save & add another` click on resource just created in sidebar to edit change format to `HTML,` click `Save & add another` etc that all works fine for me what am i doing wrong? thanks also please try using a non sysadmin account
#2734 1343121694000000 toby cool I can reproduce fix will be today
#2734 1343126896000000 toby @ira, fixed and uploaded to s031 re-open if still broken
#2737 1343135305000000 toby @ira, that url is broken. I'll fix this
#2738 1343124741000000 toby the resource has no webstore_url and therefore no data api I assume that some data is in the datastore but personnaly I don't know the data closing as this is the correct behaviour as far as is known - Ie complete guess ;p but that is how it is done in ckan core
#2739 1343135348000000 toby we need all the help text - moving to phase 3
#2740 1343135455000000 toby i'll fix this
#2743 1343130830000000 toby @ira, I've changed the wording on the button too 'Add Dataset to Group' Adds the group auto-magically this is live on s031 for testing fun
#2749 1343232304000000 toby I like the block page_title approach but not too fussed as long as this instance is working
#2751 1344015002000000 toby This is now possible via the `paster trans mangler` the initial verdict is that our translation coverage is extremely poor and we need a full template review - maybe there is a jinja2 i18n solution but I think not without `{% trans %}` Moving to phase 4 - also I'm just holding this ticket and will be allocating to aron's successor Publishers vs Groups is more complex than I think is appreciated, is it really worth the time and effort just to make everyone using ckan confused? Anyhow that discussion is not part of this ticket as it is not in-scope
#2751 1344243046000000 toby @aron, The pip install polib is needed this is a deployment requirement so not in the pip-requirements.txt Not sure where it should live we use it elsewhere so may already be in there somewhere not sure why you needed the egg_inf
#2752 1343222618000000 toby fixed in stable
#2754 1343226309000000 toby @shevski as a reminder url please - I'll find the page but it makes my job harder
#2755 1344505304000000 toby this is dependent on #2790 (pending) and #2356 (waiting merge) other fixes have been done therefore closing this even if the effects won't be seen till those fixes are merged
#2765 1343735917000000 toby @aron, I've added a data summary The data errors for empty fields are not happening due to our use of repoze.who for logins which is crap and doesn't provide feedback re loggin details so not possible without hacking repoze which i'm not doing. Could you look at cleaning up the error summary we don't supply a field name (key) as not relevant it would be nice if we could hide the : also removing the invalid fields message would be good to hide maybe add this as an option to the macro
#2769 1343377760000000 toby @shevski, we will probably want a design for this - maybe wait till we have the basics up and running
#2769 1343734083000000 toby rough cut down needs some design love but new ticket for that http://trac.ckan.org/ticket/2778
#2774 1343993956000000 toby @aron I've created some js translations note that they are untranslated except for zh_TW which is mangled. At the moment they are just a json blob in public/base/i18n/<locale>.js What more do you need? It seems to me that you just need either `some_var = {json}` or `some_function({json})` let me know your preference or do we want this purely as an ajax call? If it's ajax I think we want a common approach like in http://trac.ckan.org/ticket/2698 which I prefer to a unhelpful response
#2774 1344009350000000 toby for now shall we just include it in the page? let me know how you want it included eg var = {}, fn({}), $(fn({})) etc
#2779 1343818990000000 toby @aron, pkg_dict.state I think the options are active - all good draft/draft-complete - partially created dataset deleted - deleted
#2780 1345023811000000 toby This is a new feature moving to phase 4
#2781 1343901395000000 toby @aron, This is possible via /ckan-admin/config but renders badly with the demo theme disabled due to hiding behind that black rectangle - maybe we can do something?
#2781 1343947526000000 toby @aron please try with ckan.plugins = stats in your .ini ie without the demo theme being used
#2782 1343805253000000 toby @ira, I'm just closing this a) Because the ticket doesn't really mean anything what is `properly` also a link to some random website does not help. The ticket should tell me exactly what is wanted not be some sort of treasure hunt. b) This is major feature creep - we have agreed the tickets for phase 3 small things/bug fixes are fine but this possibly a massive thing. For weird stuff like this maybe you should save them up for when we have a meet up. You need to get buy-in from developers I need to have some sort of pride in what I do. c) I don't think this is a good idea from a technical perspective - maybe if you create a meaningful ticket it may make more sense. d) Also I'm not doing anything involving maps till we have proper attribution of the map we are using on the demo site because I have morals, I thought okfn did too but I'm not sure any more. Sorry to have to do this but it is for my sanity. As I have repeatedly said the tickets are really important as they are the basis of all the work that I do. They need to be of a reasonable standard.
#2782 1343811113000000 toby @ira, I'm happy to discuss things on irc/email if you are unsure about things. If There are tickets that you are not sure about when they are wanted, then add them to phase 4 as they can then be ignored for now - anything added to phase 3 is a "this needs doing now" thing and as we have agreed exactly what we are doing in this phase (last week) then adding new features will likely get a negative reaction. So if not sure add it to phase 4 - aron and I may do some phase 4 tickets if we feel they will be quick and easy. As I've said small things like the breadcrumb is wrong on page xxx or bugfix tickets are fine as broken stuff needs fixing. Sometimes it may not be clear how much work something will be or who the person who needs to fix it is - so just ask first. The main problem with this ticket is that it is unclear what the ticket is about. cheers
#2783 1343817744000000 toby closing after discussion with kindly
#2783 1343818702000000 toby Milestone ckanhosted deleted
#2787 1344543473000000 toby Closing as too general and part of any plugin update
#2793 1343897811000000 toby fixed but commit tagged as 2650 in error
#2802 1344258233000000 toby @aron I've done most of this to test get strings {{{ python setup.py extract_messages }}} mangle the zh_TW creates .po/.mo files - I may need to fix plurals {{{ paster trans mangle -c .ini }}} create .js files only zh_TW will be correct due to other .po/.mo files being 1.7 ones {{{ paster trans js -c .ini }}} /api/i18n/zh_TW should be correct please note we do not have en.js I'm returning {} I think this is the correct response (maybe something else as we should just use the default _('...') strings - maybe we need to do something else for what it's worth pojson does not provide the format you wanted so I adapted it reassign if you need fixes
#2805 1344254760000000 toby Arg I think this is my fault
#2812 1344445200000000 toby @ira, do you want this change?
#2812 1344509156000000 toby changed
#2812 1344523785000000 toby @markw I think you are talking about a different ticket closing
#2812 1344524290000000 toby @markw, Actually I see you also want some text changes please don't add unrelated discussions to tickets as it causes noise is disruptive and I just end up closing tickets as won't fix etc. I have updated the text as it was assigned to me and so i am still keeping this closed as I did as requested. Can you an ira sort this out between yourselves and create a new ticket when you have agreement Thanks
#2813 1344445419000000 toby http://demo.ckan.org/dataset/afterfibre group box wants a title link is not clickable maybe reorder stuff
#2817 1344544901000000 toby works in dev branch - may not be on s031 yet also please include urls in bug reports if possible - thanks
#2818 1344545331000000 toby check schema
#2818 1345482572000000 toby @ross, This is an issue with the related items schema - I'm not quite sure what all the rules should be eg does visulisation need image url? or is normal url ok? Could you review the schema and ensure that we require/don't require the correct items. If you provide the rules I can help do the schema if you want but I don't know them cheers Toby
#2819 1344545479000000 toby works in dev branch for /apps http://localhost:5000/dataset/1-kmwaterfractionfromnationaltopographicdatabasemapscanada/related
#2826 1344528004000000 toby fixed, issue was url_for_static @ira, good to test the site in english ie url like /en/dataset change language to something then english it will help catch these issues
#2827 1344549139000000 toby Fixed and pushed to s031
#2828 1344507533000000 toby @ira this is the correct behaviour as this is a partially added dataset - rewritten ticket as it has a nice number :)
#2832 1344542984000000 toby duplicate of #2718 closing
#2836 1344853957000000 toby @aron, I'd love it if we could pass it as an arg ie form.input(...., extra_info=<something escaped if not literal()>) also while we're at it I'd also really like form.input(...., help_info=<something>) that would give a (?) icon with a :hover {display:block} div - that make sense?
#2836 1344859911000000 toby I'd quite like some general css like this <span class="hover-for-help">[thing to hover over] <div class="help-text">Help text</div> </span> This is for the qa extension but seems like a general need .hover-for-help .help-text{ display:none; } .hover-for-help:hover .help-text{ display:block; position:absolute; padding:3px; }
#2837 1344847819000000 toby http://localhost:5000/testing/primer essentially it's a black not grey outline also errored one isn't red
#2839 1344854522000000 toby this is fixed in https://github.com/okfn/ckan/pull/88
#2844 1345454527000000 toby paster db clean fixed in https://github.com/okfn/ckan/pull/107
#2852 1345103409000000 toby @ira, Please review the fix I think adriá did
#2852 1345103634000000 toby I think it should stay red but you can argue
← 1 2 3 4 5 6 7 8 9 10 11 12 13 14 →
Note: See TracReports for help on using and creating reports.