{23} Trac comments (3729 matches)

Results (501 - 600 of 3729)

← 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 →
Ticket Posixtime Author Newvalue
#2471 1352206679000000 johnmartin I can't context on this. Closing.
#2470 1338284041000000 johnglover Search results validated against schema. Added a class implementing IPackageController, in after_search results are replaced with package dicts got from package_show. A bit heavy-handed, but works for now. Maybe we should just call package_show in the package_search logic function in core?
#2469 1340639702000000 seanh Closing this, has been broken down into individual tickets, see ckanbuild milestone
#2468 1339757934000000 rgrp DONE. (Closed on github)
#2467 1340981885000000 amercader Fixed (mainly by Aron)
#2466 1338467285000000 seanh Looks like we need to upgrade to Trac 0.12 and then install this plugin: http://trac.edgewall.org/wiki/SpamFilter
#2464 1338910189000000 johnglover Fixed for now, but had to keep group type as 'organization' as the string is hardcoded into the publisher auth profile in 1.7.1.
#2461 1344543838000000 toby stop the error
#2458 1343596843000000 shevski Stats important for prototypes & be good to demo a key feature
#2458 1343737692000000 shevski Do we need a design for this? Or can we just use the same format as datahub.io/stats but within the new template?
#2458 1343818531000000 aron.carroll This will be up on s031 by the end of the day for feedback
#2458 1344254847000000 shevski This looks great. 4 small things: 1. clicking on a tag in 'top tags' takes you to old unstyled page, e.g. http://s031.okserver.org:2375/en/tag/economics. Should take you to search faceted by that tag. 2. I'd love to be able to link directly to e.g. the 'top tags' view - any way to do this? 3. Is there any way to rate datasets at the moment? If not, can we hide that option for now? 4. On 'Revisions to Datasets per week' can we rename this 'Dataset revisions per week' and can we change the orange icon/index in the table to 'all dataset revisions' instead of referencing 'packages'
#2458 1344262256000000 aron.carroll Made changes as of 9729f1c 1. Clicking a tag now takes you to the search page 2. When clicking the tabs the location now updates so you can bookmark pages. 3. Not sure how datasets are rated. 4. Text changes made.
#2457 1352206516000000 johnmartin I can't get access to said project. Can someone please give me access so I can triage this?
#2456 1339670080000000 aron.carroll Closing this as the page is up. Issues should be reported as new tickets.
#2455 1338998214000000 aron.carroll Fixed as of 1dbe4df
#2454 1338993375000000 aron.carroll Implemented the templates for this. There are currently no decent error messages for missing fields, would be nice if we could have more specific error messages. eg. invalid username, username required, password required etc.
#2454 1338994536000000 toby I am against providing much more that you did something bad things like invalid username leak info - people should not know if usernames exist. Maybe I'm a bit mean about this. I'd be happier to add some javascript check on the form post that checks for no password etc - maybe that's not so practical
#2454 1339431487000000 toby @aron, I'd like to close this as a won't fix - your thoughts
#2454 1339493727000000 aron.carroll Hmm, I totally agree with you on the missing username front but it would be nice at least to provide the errors in the same way we do the other forms. Currently it just displays a flash message which is unexpected. I'd suggest we add a generic "failed to login, invalid fields" in the error_summary block. Then more specific "this field is required" when a required field is left empty.
#2454 1339495000000000 toby @aron, I'm going to leave this open for the moment but not make the requested change as I need to think of the best way forward. The flash message error is quite hard coded into the logic and I need to think of a nice solution.
#2454 1340710442000000 toby needs discussion and low importance
#2453 1343377952000000 toby @aron, can we close this as being too general - and have specific tickets?
#2452 1343377943000000 toby @aron, can we close this as being too general - and have specific tickets?
#2451 1343378027000000 toby @aron, can we close this as being too general - and have specific tickets?
#2451 1352206567000000 johnmartin I can't get access to said project. Can someone please give me access so I can triage this?
#2450 1339670997000000 aron.carroll Closing this, issues should be created as new tickets
#2449 1339670041000000 aron.carroll Closing this as the page is up. Issues should be reported as new tickets.
#2448 1339669678000000 aron.carroll Done. Any issues should be created as new tickets.
#2447 1343377924000000 toby @aron, can we close this as being too general - and have specific tickets?
#2446 1352206530000000 johnmartin I can't get access to said project. Can someone please give me access so I can triage this?
#2446 1352658819000000 shevski gave john basecamp project access
#2445 1338375577000000 ross Yup. Will look at this Thurs when I'm back in.
#2445 1338378161000000 toby @Ross you will need to do this based off the feature-2375-demo-theme branch - you can use that branch or one split from it. new templates want to be in templates/... the old templates live in templates_legacy if you need to copy them across that's fine talk to aron or I if you need to know anything
#2445 1338472050000000 ross Okay, the 303 on validation failure seems a little excessive though given that we're posting to that URL. Is a 200 okay?
#2445 1338472161000000 ross Am working in feature-2445-add-related-new
#2445 1338472624000000 toby @ross the validation error seems correct to use 200 for the created the 303 seems ok but i'd just use pylons redirect myself Also did aron say we want this as a javascript free add item form
#2445 1338472966000000 ross He didn't say but I assumed yes given current impl uses dodgy JS->API.
#2445 1338473161000000 aron.carroll I generally take the approach that a form submitted via POST should always redirect to a page. This prevents accidental user resubmissions when hitting refresh as well as the annoying popup saying "are you sure you want to re-submit". http://en.wikipedia.org/wiki/Post/Redirect/Get Looking at the rest of CKAN it doesn't do this so I'll leave it up to you.
#2445 1338473309000000 ross redirects are fine, of course, but redirect on validation failure seems painful ? Also templates in templates_legacy?
#2445 1338474490000000 toby @aron I'm fine with the redirect thinking it's just the specific 303 rather than just whatever pylons does. @ross, templates_legacy are there for ckan users who have their own templates as we are completely rewriting all the existing templates there is a lovely .ini setting to switch between the new and legacy modes
#2445 1338542340000000 ross I *think* this is done in feature-2445-add-related-new although I may have missed something, if you could take a look and let me know if it is what you wanted.
#2445 1338911121000000 aron.carroll Thanks Ross this is exactly what I wanted. Just wondering about the use of the c.form variable to insert the form into the page. I know we do this with the dataset and groups to support legacy templates, do we need to do this going forward? I'd rather each action just rendered one template and leaves it up to that to render the rest. Toby, there's a couple of TODO statements in the code where the breadcrumbs need fixing. I think the templates just need access to the package dict. https://github.com/okfn/ckan/blob/feature-2375-demo-theme/ckan/templates/related/pages/form_page.html#L6 https://github.com/okfn/ckan/blob/feature-2375-demo-theme/ckan/templates/related/edit.html#L5 Also if you generate an error message on one of the forms (leave the title blank) the error string comes out wrapped in quotes. eg. u'title is missing' Also might be of interest, I've converted the templates to use Jinja, and this is a good example of the conversion. https://github.com/okfn/ckan/commit/d779addf6e48be67695b35c031393e2d90d8c22f
#2445 1338911190000000 aron.carroll Oh forgot to mention I've merged the code into feature-2375-demo-theme. We should delete the feature-2445-add-related-new branch.
#2445 1338975600000000 toby @aron, this is as good a place as anywhere to answer your question about the c.form thing. a) some of this we are sort of stuck with. datasets for example can be of different types and have different forms for different datasets. so they need to be rendered separately. I have no idea why or how much this is used but it exists as an option to complicate everything, not much we can do about it. b) I think trying to do pages as a single rendering is not going to be easy because of the way ckan has been created maybe we can change this over time. One major issue for me is that ckan does lots of crazy stuff for some reasons but these reasons are not apparent from the code. Maybe there is some documentation somewhere but I'm not convinced. anyhow we should maybe close this ticket now. You've added some stuff in the comment for me to do maybe that should be added as a new ticket?
#2445 1338982754000000 toby closing as todos moved to other tickets and also completed
#2444 1339669652000000 aron.carroll Done. Any issues should be created as new tickets.
#2442 1338302281000000 aron.carroll Functionality to be added: * Group module needs to display group/publisher title, logo and description if dataset has an associated group. * Popular icon only needs to be displayed if dataset is popular. (say if it has 10+ views for the moment) * Popular icon needs localised text passed in to snippet (See TODO comment above helper https://github.com/okfn/ckan/blob/feature-2375-demo-theme/ckan/templates/package/read.html#L46) * Related module needs to show most recent item or fallback content.
#2442 1338305764000000 toby make readable * Group module needs to display group/publisher title, logo and description if dataset has an associated group. * Popular icon only needs to be displayed if dataset is popular. (say if it has 10+ views for the moment) * Popular icon needs localised text passed in to snippet (See TODO comment above helper https://github.com/okfn/ckan/blob/feature-2375-demo-theme/ckan/templates/package/read.html#L46) * Related module needs to show most recent item or fallback content.
#2442 1338379591000000 toby popular localised need to get live tracking data and fixup (in progress) groups now shown including multiple with link to group page related items I'd like some data for this I'll see if I can add some
#2442 1338381909000000 toby now has actual tracking data to get data install ckanext-googleanalytics from source in analytics package dir run `paster loadanalytics internal 2012-01-01 -c ../ckan/development.ini` you may need to change .ini file name then in ckan dir `paster search-index rebuild -r -c dev.ini` It needs a refactor to make it easier to use
#2442 1338383819000000 toby new helper function for popular h.popular(type_, number, min=1, title=None) just related items left now
#2442 1338477973000000 toby @aron, related items on dataset page has been added it's really basic and just displays the fields that seem useful. we may need to add the add related item feature first as they are hard to add. please make it beautiful
#2442 1339670612000000 aron.carroll Closing, issues should be opened as new tickets
#2441 1338287243000000 aron.carroll Order by needs hooking up to form. Currently it's just a @<select>@ element containing a single entry, it needs the other possible options added. Let me know if you want more details.
#2441 1338291362000000 toby @aron, this is now in a snippet (jinja2 allows the selected="selected" more easily) needs some work still eg translation stuff and also maybe completely rewrite the snippet at some point. Anyhow the functionality is there. I added the button for no javascript working. I'm assigning to you for beautification etc on live demo http://s031.okserver.org:2375/dataset?q=&sort=title_string+asc
#2441 1338306828000000 aron.carroll There's already a submit button in the form (it's the question mark) it's up for discussion on Basecamp if this is clear, apparently it's not. I'm going to throw this back to you to implement the popular badges, I'll tidy that form up later. Perhaps we can get a helper such as h.isPackagePopular(pkg) that can be customised on a per instance basis.
#2441 1338306866000000 aron.carroll Not question mark sorry, I meant magnifying glass (inside the search box)
#2441 1338384362000000 toby popular badges on package list - may make them optional/configurable at some point but good enough for now. see http://trac.ckan.org/ticket/2442 for details With the `order button` this is for none javascript users i'm not sure the magnifying glass looks like the thing to press to reorder the results. I'd hide it when javascript enabled. Do what you will @aron I'm assigning this to you close or reassign to me if you need extras adding
#2441 1339670118000000 aron.carroll Closing this as the page is up. Issues should be reported as new tickets.
#2440 1339421746000000 aron.carroll Has some styling as of b0153ba but needs content to be applied. Toby, can you pull in the top 10 tags, as well as n of the most "popular" datasets and n of the most recent datasets. Actually just providing the functionality as helpers would be great. Do we actually have "featured" datasets implemented at the moment? Not sure what we're going to use for the box on the top left when on a new base CKAN instance.
#2440 1339423966000000 toby @aron, tags what functionality do we want for this? I can just reuse the facet_list snippet but then we have all sorts of interactivity. Do we want this more a static list of tags (linked to somewhere but no add remove stuff)? seems more sensible I think featured datasets I've no idea I'll try to discover
#2440 1339430956000000 toby you may want to look at your css as the dataset is generated by the package_list snippet I've made all packages popular for now
#2440 1339497700000000 aron.carroll Fixed this up, last thing I think we should do is ensure that the datasets passed to the homepage have descriptions.
#2440 1339498655000000 toby dataset descriptions is a data issue but I'll keep this open for now. We can probably do an exclude if needed.
#2440 1339499074000000 aron.carroll Sure, but this is more about displaying nice complete examples on the homepage.
#2440 1339581622000000 toby I am changing this to assigned not accepted as this makes trac easier to use
#2440 1340373461000000 toby i'm closing we can make tickets for specific issues
#2439 1338214158000000 icmurray The `fields` argument doesn't provide any extra functionality that the `query` argument can't provide. 1. Figure out what the reason for this argument is, just to make sure. 2. Deprecate it, and change any internal uses of it to use `query` field instead.
#2438 1338212234000000 icmurray Proposed solution: Add a new q field which can be specified multiple times. Each q parameter is a string: `{field}:term`. `:` characters are escaped in the `{field}` by `\:`. Mark the `fields` parameters as deprecated.
#2438 1340736112000000 icmurray Ready to be merged [1] Brief synopsis of changes: - altered return type of the action: from Resource domain objects to dictized resources. This is required if this action is to be made accessible through the action api as the domain object is not json-serializable. The 'old' return type is still available by passing in a flag in the context. In fact, this is required as the search layer uses this action, and deals with the domain objects directly. - decided that escaping the ':' (as described in above comments) wasn't necessary as resource fields shouldn't have ':' characters in them anyway. - improved action's docstring - 'fields' parameter has been deprecated ( see #2603 ). Use of it by the search layer has been removed in favour of the new 'query' parameter. But it still works, and correctly maintains backward compatibility. [1] https://github.com/okfn/ckan/pull/37
#2437 1338484676000000 seanh Please add to the file started to doc/coding-standards.rst Also, for the Python coding standards see http://wiki.okfn.org/Coding_Standards as a starting point
#2437 1338487089000000 seanh I've also added the commit message guidelines as they reference a trac plugin I'm going to get installed. I'll leave the rest to you. I remembered that http://wiki.ckan.org/Main_Page has a bunch of pages under Developer Resources that should probably be updated and merged into these coding standards and deleted from the wiki
#2434 1341234522000000 seanh We've moved to AWS hosting with docs generated by Jenkins instead, see: http://trac.okfn.org/ticket/1254 There are still two issues to resolve: 1. Automatically updating the symlink so that docs.ckan.org always redirects to the latest stable version 2. Finding somewhere to put links to all the other versions
#2434 1350296272000000 amercader Seems to be working again, closing.
#2433 1337960203000000 toby the affected actions =============== package_list package_relationship_create revision_show group_list package_update_validate It would be nice to get this fixed and I'm loathed to suggest adding a version 4 hack. If we make this change it will break things for existing users. This behaviour has existed since the action api was added as far as I'm aware So should we a) leave it forever and document b) break things and fix it - when 1.7.1 or 1.8?
#2433 1338397268000000 toby after discussion it has been agreed to keep the existing behaviour and improve documentation as it is likely to break existing applications etc
#2432 1338205526000000 aron.carroll It would be great to use something like http://trac-hacks.org/wiki/SimpleTicketPlugin to remove most of the options when creating a ticket. Suggestions to remove theme, repository, component and type unless they're actually useful.
#2432 1338325120000000 shevski Where do new tickets go to await triaging? Is priority set by whoever creates the ticket? Does this get revised? Will we have a field for dev time estimate or where will this go?
#2431 1338397906000000 seanh https://github.com/davglass/github-trac
#2430 1338397815000000 seanh http://trac-hacks.org/wiki/MasterTicketsPlugin
#2428 1341234933000000 seanh This awaiting merge, pull request: https://github.com/okfn/ckan/pull/46
#2428 1341314475000000 seanh Merged. The only thing I didn't do was add a test case that runs pip freeze and tests that all the right versions of deps are installed.
#2424 1338193269000000 ross Duplicate of #2413
#2423 1338193199000000 ross Duplicate of #2414
#2422 1337945204000000 seanh Closing because I'm not able to reproduce and it turned out floapps had publisher auth on which was overriding his rights auth
#2420 1337950422000000 toby merged into master
#2419 1337863024000000 toby @aron the reason for this is that controller/package.py renders the form `package/new_package_form.html` as part of it's work and then makes this available a `c.form` to the template. I'm not sure I like this as an approach but it is how it is currently done. If you split your form into a new template `package/new_package_form.html` then you get all the errors etc. I think for now we should do this and then look at if doing it all in one template pass might be more sensible. reassign to me if you want me to do this else I'll leave it with you
#2418 1337875172000000 toby all facets now shown and selected have <li class="active"> @aron styling of active facets with long names breaks. we could make the names shorter in snippet/facet_list.html via truncate or make the selected taggy thing wider
#2417 1337864155000000 toby fixed in demo-theme branch
#2416 1338464207000000 toby commit 37622d5 does this but probably in the wrong place but works for now. Need to revisit at some point.
#2416 1340710252000000 toby moving to phase 2 as not causing problems but still needs proper fix
#2414 1337869578000000 ross LXML is currently used for markdown_extract and check_solr_schema_version Changing check_solr_schema_version should be possible, Used in markdown_extract to just strip HTML tags.
#2414 1338471374000000 ross Merged by kindly
#2411 1338210872000000 toby This is a long term goal
#2410 1338193633000000 ross Tim Lebo and Keith Alexander are both now looking at how they can implement this themselves, so for now this is wontfix. We can reopen this as part of any future work with VoID
#2409 1337688965000000 ross This is in the Package controller and may be related to upcoming ticket on removal of autoneg.
#2408 1341497601000000 aron.carroll This will be done as part of adding javascript in phase 2
#2408 1343657014000000 aron.carroll Fixed in df502fd9269859c73458f4ad8de75939220e0315
#2407 1340633440000000 amercader This will require some thought. Bumping to 1.9.
← 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 →
Note: See TracReports for help on using and creating reports.