{23} Trac comments (3729 matches)

Results (1501 - 1600 of 3729)

Ticket Posixtime Author Newvalue
#838 1295259773000000 rgrp I'm going to close this ticket as almost everything done and remaining ticket can be done on its own.
#2774 1344008312000000 aron.carroll I'm happy to just make ajax requests to public/base/i18n/<locale>.js, however this will use the language set in the <html lang> attribute. So if this file doesn't exist then we'll get a 404 and show the english. If we want something more sophisticated, determine an appropriate fallback etc, then I think the API is the way to go. Or we could get CKAN to determine the appropriate language file and include it in the page source...
#1044 1300712223000000 dread I'm happy to leave the inconsistencies in SITE_READ for now, since this will be resolved when authz is centralised between WUI and API in the dictization refactor. I'm also happy to leave both TestSiteRead and TestLockedDownUsage as they complement each other nicely actually. So I think all that remains for this ticket is to add a paragraph to the authz documentation about SITE_READ. Pudo would you mind doing this? It's well worth noting where it applies and where it doesn't.
#817 1289997628000000 cygri I'm not allowed to create attachments for some reason. Here's the screenshot: [[Image(http://richard.cyganiak.de/2010/ckan/ckan-resources-table-proposal.png)]] http://richard.cyganiak.de/2010/ckan/ckan-resources-table-proposal.png
#803 1289489024000000 dread I'm not sure a template is needed for the test script - surely repeated stuff can just be factored out? Creating the model dump file: * 'hg up' to ckan as it was at the last model migration * 'paster db clean', 'paster db init', 'paster create-test-data' * 'pgdump' * 'hg up default' * Check in the dumped file Do we really want a script to mess with our repo like this? Isn't it just safer to do manually with good instructions?
#1583 1324484387000000 rgrp I'm not sure star rating is the key thing I want to know and I also think it will be visually very confusing (I associate stars with ratings now with some automatic quality assessment + (IMO) 5 star isn't that useful). I'm much more interested in things like: * Is this down (all the time) * Has this been down recently * When was this last modified (not quality per se ...) This is an area where referring back to the original user stories (if any) around QA is really useful. I guess my feeling would be some of this should be about providing e.g. helper methods so that theme designers can incorporate things into their design with some work putting this into default CKAN theme.
#1284 1315214358000000 rgrp I'm not sure this is the sort of thing we need tests for (we can have too many tests!). Something worse discussing ...
#1127 1305458020000000 rgrp I'm obviously a strong +1 but feel we should stick with the CEP name (we have PEP and DEP and CREP really does sound weird compared to CEP). Also I think we may need to do a bit more to clarify when you just do a good ticket and when one does a CEP (looking at what has occurred already). I think this may be one reason to keep CEPs separate in drafting from trac as will clearly distinguish CEPs from standard tickets.
#2331 1343814758000000 rgrp I'm re-opening this. This is a reasonably significant UX problem -- not just a philosophical difference. It is just *weird* to get *more* results as I add search terms rather than less. Please can we have this fixed ...
#2304 1335878372000000 seanh I'm setting the priority of this high just because it's a low-hanging fruit for this sprint, as it was almost done last sprint.
#1006 1300372286000000 thejimmyg I'm updating the branching policy now. David has closed stable and closed metastable. Marking as fixed.
#366 1299845116000000 dread I'm very pleased that this now works when you try to edit a package that is not allowed. Are there other circumstances we should cover or can we close this?
#1214 1309982828000000 dread I'm working through these on branch defect-1214-api-improvements. "Server returns text/html for errors" - now fixed in cset:0a533a8da3df
#1802 1329490081000000 dread I've achieved CKAN running with paster and without SOLR (using simple_search). Running locally on an old XP machine, performance seems fine - no noticeable issues. I installed most things into a pyenv using pip. pyutilib, psycopg2 and lxml were slightly problematic, but I have workarounds. I had problems pip and svn and the Cygwin window, so reverted to DOS prompt. I still had the Cygwin tools installed though, so next step is to try it without these at all - they are a big overhead.
#1494 1326103951000000 seanh I've added a controller function for getting a user's activity stream as rendered html to ckan/logic/action/get.py in this commit: https://github.com/okfn/ckan/commit/30264997c7fe34324381123d6741d404baa67c1e I'm proposing to leave it at that for now and not actually hook this controller function up to an API call, as I'm not sure how useful an API call for getting rendered HTML will be (we already have an API call for getting the user's activity stream a JSON).
#1044 1300449905000000 dread I've added in tests for SITE_READ and corrected the 403 response - see branch bug-1044-site-read. The tests have uncovered some inconsistencies in the use of SITE_READ between reading/editing a package in the Web interface vs the REST API. Friedrich, do you want to take a look at ckan/tests/functional/test_authz.py:TestSiteRead.test_pkggroupadmin_read for details and have a think about how this should best work. How about making SITE_READ more widespread in the WUI, to protect read/editing/searching things, in addition to the READ and EDIT RoleActions. Once that is decided, it should be pretty easy to refer to the tests and document SITE_READ.
#1044 1302096155000000 dread I've added in the docs for this in cset:013da53052d1 ready for release 1.3.3.
#2791 1343906884000000 aron.carroll I've added no-wrap as of 1db2037. Not sure what we should do about short titles/long tag lines though.
#1054 1300989764000000 dread I've added some tests in the branch: defect-1054-resource-order
#1284 1315212603000000 dread I've added tests for this (to prevent yet another regression!) in cset:1b77ce8ce560. Closing.
#2437 1338487089000000 seanh I've also added the commit message guidelines as they reference a trac plugin I'm going to get installed. I'll leave the rest to you. I remembered that http://wiki.ckan.org/Main_Page has a bunch of pages under Developer Resources that should probably be updated and merged into these coding standards and deleted from the wiki
#2208 1332251880000000 seanh I've attached a ckan.pot file. To make it, I edited setup.py in CKAN core like this: https://gist.github.com/2135849 and then ran python setup.py extract_messages. (And I had ckanext-ecportal installed at ~/pyenv/src/ckanext-ecportal.) I guess I may need to run this again when the ckanext-ecportal source is finalised, so leaving this ticket open for now.
#1430 1320339962000000 amercader I've been digging more on this one. To reproduce it, you just have to edit the same dataset in both sites (production and testing). Just after editing the dataset, the search index will get mixed site_ids. I checked the jetty logs (see attached files) and just after editing a dataset there are two POST requests to update the index. The request logs don't show the requests params so it's hard to tell what the second call does (it probably is the commit): https://bitbucket.org/okfn/ckan/src/97e1e90d66d7/ckan/lib/search/index.py#cl-144 In any case, it's clear that the problem may be related with the datasets in the two cores sharing the same id. We are currently using the dataset id as uniqueKey in SOLR, i.e in our schema.xml, we are defining: {{{ <uniqueKey>id</uniqueKey> }}} According to the SOLR docs: "If a document is added that contains the same value for this field as an existing document, the old document will be deleted." http://wiki.apache.org/solr/SchemaXml#The_Unique_Key_Field I would expect the uniqueKey not to be mixed between cores, but it looks like it happens otherwise. Maybe we should generate a solr_id specific to each document for each site, as described here: http://wiki.apache.org/solr/UniqueKey#UUID_techniques (Note that apart from the testing/production site use case, at some point sites involved in harvesting could also end up with datasets with the same id.) Again, I'm not a SOLR expert, so the problem could be a completely different one!
#1788 1333133365000000 zephod I've been performing a full sweep of the site to rebuild the markup & stylesheets using Bootstrap, and in doing so have managed to close off this ticket. Bootstrap allows us to delegate lots of clever functionality and layouts to Twitter's tried-and-tested code, making it easier to be compatible with IE7. It has brought up plenty of issues: Lots of Javascript was broken; plenty of pages generate broken doctypes causing the browser to go into quirks mode (which in turn causes the page to explode all over the screen); most dynamic content would fail to generate properly in one way or another.... (see the #1788 branch for a log of issues encountered). I've been refactoring our JS and have managed to strip ckanjs, too, because the only significant element we'd used was the File Upload view (which also now works in IE7). test.ckan.net has been redeployed on master; I'm browsing the site in IE7 and everything is looking great :-)
#1298 1321199769000000 seanh I've been working on this in this branch: https://github.com/seanh/ckan/commits/feature-1298-activities-table
#2550 1341767370000000 icmurray I've done some initial work on this. I think the best way is to define extra tables in the datahub extension. (Rather than: using groups; or modifying the user table; or defining extras for users (in core)). Initially, I've created a new domain object, PaidService, which captures the different levels of account a user may have. And then attached users to this through a secondary table. I think the advantages of this approach are: - the PaidService table can contain supplementary info about that account type: eg - amount of storage allowed; or cost to sign up etc... - allows us to use a modular payment system if biz decide that would be favourable. ie - users belong to multiple PaidServices which are independant of one another, rather than a linear hierarcy (eg - "sign up for storage, but not for privacy" vs. "sign up for enterprise level rather than basic level") The thing that's held me up today is being able to run tests: I'm having a sqlalchemy issue with defining extra mappings on the User table; which then gets dropped when initializing the test setup. I've gotten to the bottom of the problem, and will ask kindly's advice. In the meantime, I could do with some user stories please. I think I have a fairly good idea of what's likely to be needed by this ticket; but to what extent should this be exposed to a sysadmin (adding payment schemes; adding users to payment schemes; users seeing which payemtn services they're paying for (public to other users or not?); user's seeing history of payments? sysadmins seeing list of users for each service level?) - should this be: through a dashboard? through paster commands? through the api? all 3? Do we want modular payments or a linear hierarchy of payment schemes? How does is this suppossed to fit in with organizations? Do organizations purchase on behalf of users as well as individuals being able to make purchases? Do we need to be able to deativate a user's paid service if their payment hasn't come through?
#1002 1311173185000000 thejimmyg I've done this in my branch and it will get merged in.
#1440 1320235084000000 dread I've done this. 'db load' now also does 'db upgrade' and 'search-index rebuild'. If you want to debug the load (or don't need the search index, cos it takes ages to do), then you can just do 'db load-only' which does what 'db load' did before. Changed in cset:9e51df5c496b for 1.5 release.
#1491 1322563620000000 seanh I've finished some work on this ticket here, ready to be reviewed: https://github.com/seanh/ckan/compare/defect-1491-visible-strings-need-internationalisation
#1708 1327493457000000 dread I've got a fix for this and am just looking to see where this problem started now.
#1496 1326104045000000 seanh I've implemented this in the activity streams branch: https://github.com/okfn/ckan/tree/feature-1515-activity-streams
#316 1291831177000000 thejimmyg I've just tested this on ckan.net and it gives a sensible message: There was an error while searching. Please try another search term.
#146 1291829862000000 thejimmyg I've just tested this too and it works for me. Let's close this ticket.
#699 1294412194000000 thejimmyg I've just verified that the search pages navigation does not respect the checkboxes. Could you have a look please Friedrich?
#1211 1315910650000000 dread I've listed what was checked into this branch 6 weeks ago and is going into release 1.4.3. Is this ticket ready to close now or are there future plans?
#1413 1322479113000000 seanh I've made a first attempt at this here: https://github.com/seanh/ckan/compare/feature-1413-ask-users-to-add-email-address I used flash_notice() to ask the user to add an email whenever they visit their account page, if they don't have one already. This means they'll see the notice when they login, because after login they are redirected to their account page. Issues: Is it okay to approximate 'once they log in' as 'whenever they visit their account page' like this? Do I need to do something to support i18n for the string I added? I looked at users of flash_*() elsewhere and they seemed to be hardcoding the strings in English.
#868 1294753596000000 dread I've merged in David Raznick's patches: * no_autoflush_deletes.diff cset:2b9591172182 * postgres_speed.diff cset:fa1b7e3a4e0f * vdm_purge_no_autoflush.diff vdm cset 8accdd0b9b7f I've also merged in Seb's fork: cset:68d63fda4814 which closes this ticket, achieving test speeds of under 3 minutes!
#1486 1322077524000000 seanh I've merged the fix for this into my feature-1298-activities-table branch, will merge it all into master at once: https://github.com/seanh/ckan/commits/feature-1298-activities-table
#1141 1308828928000000 dread I've merged this into default in preparation for release 1.4.2, but there may be a couple of useful additions that could be done on this or another branch/ticket. Getting a package at a specified revision is really useful. This can be used: * links in the package history (#103) (while in there, the 'moderated' flag should be shown in the package history too if not already) * should also be added to the package API (as a replacement for the AJAX call?) The history_ajax call looks like an almost duplicate of the Package Revision API. Can these be merged and put just in the API?
#908 1296730578000000 pudo I've moved the uswgi/nginx part to #952, closing this issue since the problem it describes has been fixed.
#252 1296477560000000 dread I've no idea what this is
#1444 1323089960000000 dread I've not looked at this yet, but now detection is disabled, less important.
#1591 1325764196000000 dread I've now completed the upgrade for datacatalogs.org. All that remains now is DGU. Reassigning to Ian as I'm away shortly.
#459 1282921783000000 dread I've now fixed this. default: 1.1 metastable: 1.1 stable: 1.1 / 1.0.2 (two heads) ultrastable: 1.0.2
#1486 1323172027000000 seanh I've now merged my feature-1298-activities-table branch into my super branch for activity streams, so my fix for this defect is now merged into the activity streams super branch and will be merged when that branch is merged. See the activity streams super ticket: #1515 Resolving this ticket now
#1167 1311178516000000 thejimmyg I've now written a 20 page guide on using CKAN on Amazon EC2. I haven't explicitly created an AMI, but I don't think we should do that anyway for a few reasons: * it is fiddly * there is no advantage to the user as CKAN installation is so easy and so well documented * we don't want to have to maintain the image going forward * we might not want to promote a non-open approach The guide will form part of Anna PS's work on the overall documentation but you can also see the original version here: https://bitbucket.org/okfn/ckan-debs-public/src/489a5ecf369f/ec2/
#1054 1300992195000000 dread I've put in a potential fix for this into the branch - do take a look and see what you think.
#1214 1310072808000000 dread I've put the fixes onto test.ckan.net - repoen the ticket if there are any issues.
#1002 1322515684000000 dread I've redone these changes in cset:91258a6296db71d78a on master, aiming for 1.5.2.
#1008 1298821826000000 rgrp I've removed the eval in cset:1b8fedeb7ab0 - the more general question about caching should go in a separate ticket.
#1172 1312991332000000 dread I've started this on branch defect-1172-exceptions
#2771 1343392265000000 seanh I've started working on this on a branch, will get it finished as soon as I can
#1419 1319548778000000 rgrp I've successfully logged into thedatahub using my openid. Issues may arise especially with google openid due to changes in site (from ckan.net to thedatahub.org). See: http://lists.okfn.org/pipermail/ckan-dev/2011-October/001384.html
#1370 1335273643000000 toby I've talked to David and we both feel that this should not be a part of core.
#2391 1338397982000000 seanh I've told them how to do it themselves and offered to help if they get stuck
#1329 1316624026000000 zephod I've tried to do this wherever I could as I looked through ckan.pot for broken pieces of string. Generally it triggers errors unless things are very neatly structured (no nested links or ${a.variable} accesses, it seems) but things are quite a lot tidier. cset:d5bf4c7ba293 Does that count as 'fixed', or is this a permenant issue?
#318 1276438907000000 wwaites I've updated ckanrdf to strip out datatypes and use this ll.url on external references so that should be sufficient to hold off talis. Still need to work particularly on validating dates though...
#1724 1329302302000000 seanh I've updated tag_search() and tag_autocomplete() and added tests for them. So this ticket is finished now on branch feature-1698-tag-taxonomies
#1719 1328532877000000 dread I've updated test.ckan.org with this fix and am afraid there are still broken images on http://test.ckan.net/revision
#2701 1343920287000000 aron.carroll I've updated the disqus extension (in development branch) and added the snippet to the development branch of the demo plugin. Toby, not sure about the way the disqus plugin is implemented via a helper vs the spacial plugin using a snippet. Would be good to decide on the "one" way to do this.
#1240 1325473312000000 rgrp IMO this is non-urgent and can move out of v1.6 as we have enough more important stuff to do.
#1610 1325773944000000 rgrp IMO this is very low priority at the moment (also I guess this ticket which is webstore only should go in http://github.com/okfn/webstore/issues -- though that is something of a moot question)
#1319 1315476057000000 shevski Ideally we should also verify people's email addresses. Do we think that's overkill?
#913 1299841413000000 rgrp If at all possible this should uris from the OKF licenses registry at http://licenses.opendefinition.org/
#2863 1345123824000000 shevski If by default it doesn't happen, then that's fine & we can close this. Any way for me to see how permissions are set?
#691 1294412929000000 thejimmyg If we did implement this we'd need to link new sample package to previous sample package of continuous series. So closing #748.
#2587 1340375763000000 shevski If we have a name then yes, should be even without link.
#2710 1343318314000000 aron.carroll Ignore above comment, I didn't have datastore.enabled = 1 in the ini
#1602 1328175521000000 rgrp Image (pre)viewing done in https://github.com/okfn/ckan/commit/2b08425c3aef424d4192838e418b7ad9ccc6a129.
#1692 1338204395000000 johnglover Image URL attribute added to groups (http://trac.ckan.org/ticket/2275). Won't add a similar attribute to dataset at present. Another option is to display the group image on dataset page.
#2220 1332950550000000 toby Implementation of this has been carried out at the page level. ckan.page_cache_enabled is config option to enable it requires redis need to document it somewhere
#2305 1340879812000000 seanh Implemented by Sven
#1776 1328805695000000 seanh Implemented create_tag() and delete_tag() logic action functions. If you specify a vocabulary_id in the params you can use these to add tags to vocabs, one at a time. There are not yet functions for adding or removing multiple tags in a single API call.
#851 1293025112000000 wwaites Implemented curlReq that does a curl request and returns statements similar to or analogous to httpReq. Require curate<=0.8 This in a cron job is sufficient to go through all the packages and update them with a broken link tag now: {{{ curate -r https://github.com/wwaites/curate/raw/master/examples/tagging.n3 -s -k API_KEY }}}
#1673 1327941049000000 ross Implemented in 31199375a34e04af8158e60335816236029ff96e as part of the feature-1669-publisher-profile branch.
#2684 1342539637000000 aron.carroll Implemented in 9ae7f13
#2584 1340620576000000 aron.carroll Implemented in 9bebf3d
#1593 1333385052000000 icmurray Implemented in branch [https://github.com/okfn/ckan/commits/feature-1593-create-feeds-from-search-results feature-1593-create-feeds-from-search-results] Not quite close as I've only included links to the atom feed in the <head>. Will do that this week.
#1511 1325605964000000 seanh Implemented in branch feature-1515-activity-streams and ready for review. Relevant changes: ckan/lib/dictization/model_dictize.py: Added functions activity_dictize(), activity_list_dictize(), activity_detail_dictize(), activity_detail_list_dictize(). ckan/logic/action/get.py: Added functions user_activity_list() and activity_detail_list(). ckan.tests.models.test_activity.py: Now uses user_activity_list() and activity_detail_list() functions instead of accessing the model directly to get activity streams.
#1495 1325606124000000 seanh Implemented in branch feature-1515-activity-streams and ready for review. See #1511 first as this builds directly on that. Relevant changes are in commit 3d328aa0: https://github.com/okfn/ckan/commit/3d328aa07f038287d4ecb3a9ba6facc9fabbddd2
#1087 1320866159000000 dread Implemented in cset:0b7e2b0bed44 as status_show logic action, heading for 1.5.1 release. Took 0.5h
#2661 1342524525000000 aron.carroll Implemented in d980ec7. But we really need to go over the delete implementation as it could be much cleaner.
#884 1293319984000000 wwaites Implemented in feature-884-rmsource branch at https://bitbucket.org/ww/ckan/changeset/50cbfc5a6bee
#2379 1340033026000000 ross Implemented in master
#1755 1328630657000000 ross Implemented in v1.0-dev of ckanext-dgu and feature-1645-apply-simple-theme of ckanext-dgutheme
#1807 1330809641000000 seanh Implemented the recently-changed-datasets activity stream on branch feature-1807-recently-changed-datasets in CKAN and merged it into master (but the default templates don't make use of it). Added the recently-changed-datasets activity stream to the front page template on branch master in ckanext-ecportal.
#2454 1338993375000000 aron.carroll Implemented the templates for this. There are currently no decent error messages for missing fields, would be nice if we could have more specific error messages. eg. invalid username, username required, password required etc.
#739 1296592842000000 thejimmyg Implemented today. May want a better implementation later.
#542 1283278896000000 wwaites Implemented with: * cset:2bbc186459cb * cset:eba23cc027e5 * cset:e89e0b82b24e * cset:943ed812e237
#2330 1336149571000000 icmurray Implemented, providing two methods of passing an action's parameters. Either, each parameter is specified as a url parameter, eg {{{ curl }}} or, for cases where a more complex data_dict is required, the data_dict can be parsed as a json-encoded dict in a single url-parameter called ``data_dict``, ie: {{{ curl{'q':'police'} }}} As part of this ticket: - I noticed that all module-public members of the action modules were being loaded as actions (including functions imported from other modules). So I've cleared up the action modules to prevent this. - I've cleaned up the action modules to use ``get_or_bust()`` when accessing a passed in data_dict outside before it's been validated by a schema. This provides better error messages for clients. - provided a decorator, ``@side_effect_free``, for users implementing their own actions through the IActions interface to be able to expose their custom/overridden actions as a GET request through the action API.
#1485 1323186842000000 ross Implementing an initial IPackageController in ckanext-example
#129 1267719162000000 dread Implementing this would make it less likely that new code would be written to be insecure. But it would also make a lot of things harder. Decided not to do it.
#318 1280737620000000 rgrp Important but low priority according to CO so bumping into next milestone (v1.2). NB: did not seem able to update milestone in trac interface! (Perhaps due to agilo stuff?)
#2204 1334077936000000 rgrp Important comment: not sure how much we have thought through using this for storing queries / views / visualizations coming from our data viewer. In particular, wonder if this necessitates some kind of support for arbitrary json data ... Also (@icmurray): does this interact with our desire to do embedding?
#669 1291715237000000 pudo Important sub-task: check in schema.xml from eu4 somewhere.
#1704 1327425354000000 johnglover Importer made and added to ckanext-ecportal/scripts. Still has to be run on the test server with Eurostat JSON datasets.
#1290 1314270894000000 dread Improved on option 2. For requests to Home controller, the first thing it does is check the user. I catch SQL errors that are to do with missing tables and that now produces a template-less error saying the site is off-line and then mentions database initialisation. Done in cset:484e50c4f989 on default for ckan 1.4.4.
#2690 1342542394000000 aron.carroll Improved spacing and alignment in 679e2d0
#1409 1324047722000000 dread In 1.5.1 release.
#1450 1330019974000000 dread In CKAN 1.6.
Note: See TracReports for help on using and creating reports.